Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 509908 - net-misc/connman-1.23 fails configure due missing openconnect
Summary: net-misc/connman-1.23 fails configure due missing openconnect
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tony Vroon (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-09 09:42 UTC by Ralph Sennhauser (RETIRED)
Modified: 2015-03-11 06:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ralph Sennhauser (RETIRED) gentoo-dev 2014-05-09 09:42:31 UTC
Connman 1.23 is checking for openconnect which isn't installed on this particular system and fails as follows:

  [..]
  checking for openconnect... no
  configure: error: openconnect binary not found

I suggest to add a openconnect useflag to control whether support is desired or not and adding the needed dependency when needed.
Comment 1 Ralph Sennhauser (RETIRED) gentoo-dev 2014-05-09 18:47:50 UTC
Just realized the useflag is there, just the dep is missing and that's how I run into this.
Comment 2 Tony Vroon (RETIRED) gentoo-dev 2014-05-13 11:29:10 UTC
That sounds like it can be fixed without a revbump. Please commit with my blessing.
Comment 3 Balint SZENTE 2015-03-10 13:26:18 UTC
(In reply to Ralph Sennhauser from comment #1)
> Just realized the useflag is there, just the dep is missing and that's how I
> run into this.

True, the configure script is checking for the openconnect binary.

openconnect? ( net-misc/openconnect )

must be added to the RDEPEND for every ebuild.
Comment 4 Yixun Lan archtester gentoo-dev 2015-03-10 15:21:24 UTC
+  10 Mar 2015; Yixun Lan <dlan@gentoo.org> connman-1.27.ebuild,
+  connman-1.28.ebuild, metadata.xml:
+  fix openconnect dep, bug 509908, add Balint SZENTE as maintainer

note, I only fixed at version 1.27, 1.28, and plan to go stable for 1.27, so can drop all old versions.
Comment 5 Yixun Lan archtester gentoo-dev 2015-03-11 05:06:45 UTC
similar to bug 539012, on my second thought, the USE is not necessary.
because we don't have to re-compile connman with openconnect support or without

better use pkg_postinst(), what do you think?
Comment 6 Balint SZENTE 2015-03-11 06:07:37 UTC
(In reply to Yixun Lan from comment #5)
> similar to bug 539012, on my second thought, the USE is not necessary.
> because we don't have to re-compile connman with openconnect support or
> without
> 
> better use pkg_postinst(), what do you think?

I think it is not quite the same situation. In connman's case openconnect support (module or builtin) must be explicitly enabled, otherwise it will not be compiled in at all. And if it is enabled, then the configure script will also check the presence of the binary.

So, even if you have openconnect installed, if you don't "--enable-openconnect[=builtin]" for connman, the vpn will not work.

The situation is the same with pptp and l2tp support as well.

If you just put a warning in pkg_postinst(), then the original issue (comment 1) will remain and connmain will fail to merge on a fresh system where these packages are not installed yet.

So in my opinion the USE flag is apropriate and necessary, because it is not nice to compile in openconnect/pptp/l2tp support by default for everybody, even if one don't need it.
Comment 7 Yixun Lan archtester gentoo-dev 2015-03-11 06:30:58 UTC
(In reply to Balint SZENTE from comment #6)
> I think it is not quite the same situation. In connman's case openconnect
> support (module or builtin) must be explicitly enabled, otherwise it will
> not be compiled in at all. And if it is enabled, then the configure script
> will also check the presence of the binary.
p support by default for everybody,
> even if one don't need it.

ok, reasonable! sorry for I didn't carefully check there was a openconnect configuration option.