Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 509838 - media-video/makemkv - add support for libaacs/libbdplus emulation
Summary: media-video/makemkv - add support for libaacs/libbdplus emulation
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: James Le Cuirot
URL: http://www.makemkv.com/forum2/viewtop...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-05-08 09:48 UTC by James Le Cuirot
Modified: 2015-03-08 11:00 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
makemkv-path.patch (makemkv-path.patch,373 bytes, patch)
2014-05-08 09:48 UTC, James Le Cuirot
Details | Diff
makemkv.ebuild.patch (makemkv.ebuild.patch,1.25 KB, patch)
2014-05-08 09:49 UTC, James Le Cuirot
Details | Diff
makemkv.ebuild.patch (makemkv.ebuild.patch,907 bytes, patch)
2014-05-11 09:05 UTC, James Le Cuirot
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Le Cuirot gentoo-dev 2014-05-08 09:48:55 UTC
Created attachment 376570 [details, diff]
makemkv-path.patch

Recent versions of MakeMKV support emulation of libaacs and libbdplus, which is a truly fantastic feature. I was able to stick a recent (MKB v35) Blu-ray in the drive and it just played through VLC, no ripping necessary.

This is currently broken in the Gentoo build though. It looks for the binaries in /bin, /usr/bin, and /usr/local/bin, but not /opt/bin, so the attached patch is needed.

Upstream instructs users to replace their existing symlinks in /usr/lib, which is obviously bad. I came up with a better solution to create symlinks in /usr/lib/makemkv and the end user can then simply set LD_LIBRARY_PATH to this location when they need it. I also tried LD_PRELOAD but unfortunately this doesn't work, probably because libbluray loads the other libraries using dlopen. I have added a note about setting LD_LIBRARY_PATH.
Comment 1 James Le Cuirot gentoo-dev 2014-05-08 09:49:08 UTC
Created attachment 376572 [details, diff]
makemkv.ebuild.patch
Comment 2 James Le Cuirot gentoo-dev 2014-05-08 21:13:18 UTC
Hold that thought, turns out there's some other variables you can set.

http://git.videolan.org/gitweb.cgi/libbluray.git/?a=commit;h=ecbdd7e603bd2623fda9d9e72056516fc3c4c61a

I'll update this soon.
Comment 3 James Le Cuirot gentoo-dev 2014-05-11 09:05:39 UTC
Created attachment 376714 [details, diff]
makemkv.ebuild.patch

This updated patch leaves out the symlink stuff and advises the user to set LIBAACS_PATH and LIBBDPLUS_PATH instead.

Unfortunately MakeMKV has just stopped working for me after updating from glibc 2.17 to 2.19 and I now have to invoke it via a debootstrapped Ubuntu but that's a different issue.
Comment 4 James Le Cuirot gentoo-dev 2014-06-24 20:25:54 UTC
Just a BTW, 1.8.11 is out and it's a simple bump. It's extremely important as 1.8.10 doesn't work with glibc 2.18+.
Comment 5 Account removed 2014-08-18 16:11:49 UTC
1.8.12 is available.
please give this bug a bit love, $maintainer
Comment 6 Matthew Marlowe (RETIRED) gentoo-dev 2014-08-22 22:08:01 UTC
I'm a little leery of adding anything to the ebuilds that manually requests the users to set environment variables or that is for specific use cases not controlled by a use flag.

If the patch is important enough that we should incorporate, we should probably include the automatic setting of environment variables in the install phase.
Comment 7 James Le Cuirot gentoo-dev 2014-08-22 22:18:37 UTC
The patch should be applied regardless. Whether the ebuild assists with the environment variables or not, they should still work as expected.

They effectively let the user choose between MakeMKV and libaacs/libbdplus. I thought that this is something they might want to do on a disc-by-disc basis, which is why I didn't suggest a USE flag but I personally wouldn't mind if it was done that way. The user can still the disable the flag and set the environment variables manually if they want to.
Comment 8 James Le Cuirot gentoo-dev 2014-09-12 06:55:44 UTC
I've just seen yet another user on the forums waste several hours because this patch wasn't applied. Please add this at the very least.
Comment 9 James Le Cuirot gentoo-dev 2015-03-08 11:00:31 UTC
Fixed in 1.9.1.