Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 509730 - ~net-misc/wicd-1.7.2.4 USE="-X gtk" should still depend on dev-python/pygtk
Summary: ~net-misc/wicd-1.7.2.4 USE="-X gtk" should still depend on dev-python/pygtk
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Thomas Kahle (RETIRED)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-05-06 20:29 UTC by Guillaume BRUN
Modified: 2014-05-07 05:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
New ebuild - gtk USE now triggers X (file_509730.txt,4.77 KB, text/plain)
2014-05-06 21:00 UTC, Guillaume BRUN
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Guillaume BRUN 2014-05-06 20:29:24 UTC
When emerging net-misc/wicd on hardened/linux/amd64 profile (at least, probably more profiles affected), X USE flag is disabled by default while gtk USE is enabled, causing RDEPEND not to pull pygtk because of excessive nesting.

I submitted an example patch that fixes the issue and allow wicd-gtk to work when X USE flag is disabled.

The patch is available here:
http://bpaste.net/show/261030/
Comment 1 Guillaume BRUN 2014-05-06 20:45:03 UTC
I edited the patch since it didn't work as intended. Here is the new patch:

http://bpaste.net/show/261036

The full ebuild for version 1.7.2.4-r2:

http://bpaste.net/show/261038
Comment 2 Guillaume BRUN 2014-05-06 21:00:42 UTC
Created attachment 376520 [details]
New ebuild - gtk USE now triggers X
Comment 3 Jeroen Roovers (RETIRED) gentoo-dev 2014-05-06 22:35:04 UTC
Comment on attachment 376520 [details]
New ebuild - gtk USE now triggers X

Looks like a CRLF with no newline at the end...


--- wicd-1.7.2.4-r2.ebuild      2013-03-14 06:50:02.981687530 +0100
+++ -      2014-05-07 00:33:39.128858599 +0200
@@ -22,6 +22,7 @@
 SLOT="0"
 KEYWORDS="amd64 ~arm ~mips ppc ppc64 x86"
 IUSE="X ambiance +gtk ioctl libnotify mac4lin ncurses nls +pm-utils"
+REQUIRED_USE="gtk? ( X )"
 
 DEPEND="nls? ( dev-python/Babel )"
 # Maybe virtual/dhcp would work, but there are enough problems with
@@ -29,12 +30,12 @@
 # first if none are installed.
 RDEPEND="
        dev-python/dbus-python
-       X? ( gtk? ( dev-python/pygtk
+       X? ( 
+               gtk? ( dev-python/pygtk )
                || (
                        x11-misc/ktsuss
                        x11-libs/gksu
                        kde-base/kdesu
-                       )
                )
        )
        || (
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2014-05-06 22:37:51 UTC
(In reply to Guillaume BRUN from comment #1)
> I edited the patch since it didn't work as intended. Here is the new patch:
> 
> http://bpaste.net/show/...

Do not use external sites when you can simply attach files here.
Comment 5 Thomas Kahle (RETIRED) gentoo-dev 2014-05-07 05:31:31 UTC
+  07 May 2014; Thomas Kahle <tomka@gentoo.org> wicd-1.7.2.4-r2.ebuild,
+  wicd-1.7.2.4-r3.ebuild:
+  fix wrong dep nesting (bug 509730)

Should be fixed.  Thanks.