Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 509634 - kde-base/dolphin thumbnail use flag missing kdebase-kioslaves
Summary: kde-base/dolphin thumbnail use flag missing kdebase-kioslaves
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: InOverlay, InVCS
Depends on:
Blocks:
 
Reported: 2014-05-05 18:39 UTC by turtle
Modified: 2014-05-12 02:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description turtle 2014-05-05 18:39:25 UTC
After emerging dolphin on a minimal gentoo setup (handbook thumbnail -aqua -debug -semantic-desktop) I get no thumbnails. Tracking this issue down I realised I did not have kdebase-kioslaves, I would expect the 'thumbnail' useflag to pull this in no?
Cheers
Turtle

Here is a 1 line patch for the ebuild:

--- dolphin-4.11.5.ebuild.old   2014-05-05 11:37:05.895550921 -0700
+++ dolphin-4.11.5.ebuild       2014-05-05 11:25:33.678376417 -0700
@@ -30,6 +30,7 @@
 "
 PDEPEND="
        thumbnail? (
+               kde-base/kdebase-kioslaves
                $(add_kdebase_dep thumbnailers)
                || (
                        $(add_kdebase_dep ffmpegthumbs)
Comment 1 Maciej Mrozowski gentoo-dev 2014-05-05 22:30:15 UTC
Hmm, if anything, I would see kioslaves to be added as runtime dependency of any thumbnailer plugin instead.
Comment 2 Maciej Mrozowski gentoo-dev 2014-05-05 23:45:06 UTC
@KDE

I propose the following cleanup:
1. add kdebase-kioslaves as RDEPEND of all thumbnailers:
- kde-base/ffmpegthumbs
- kde-base/mplayerthumbs
- kde-base/thumbnailers
- media-video/kffmpegthumbnailer
- ??
2. remove any PDEPEND to dolphin/konqueror from all thumbnailers (mplayerthumbs for the record)
3. favour +ffmpeg over 'mplayer' in kdemultimedia-meta (current setup in that meta "conflicts" with default preference in dolphin ebuild)
Comment 3 Maciej Mrozowski gentoo-dev 2014-05-05 23:47:49 UTC
Also I have no idea why there's kffmpegthumbnailer at all since ffmpegthumbs works pretty well..
Comment 4 turtle 2014-05-06 19:37:47 UTC
(In reply to Maciej Mrozowski from comment #2)
> @KDE
> 
> I propose the following cleanup:
> 1. add kdebase-kioslaves as RDEPEND of all thumbnailers:
> - kde-base/ffmpegthumbs
> - kde-base/mplayerthumbs
> - kde-base/thumbnailers
> - media-video/kffmpegthumbnailer
> - ??
> 2. remove any PDEPEND to dolphin/konqueror from all thumbnailers
> (mplayerthumbs for the record)
> 3. favour +ffmpeg over 'mplayer' in kdemultimedia-meta (current setup in
> that meta "conflicts" with default preference in dolphin ebuild)

Oh yeah that makes more sense to me