Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 509514 - gnome-base/gnome-control-center-3.12.1: fails to build with -gnome-online-accounts
Summary: gnome-base/gnome-control-center-3.12.1: fails to build with -gnome-online-acc...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: NeedPatch
Depends on:
Blocks: gnome-3.12
  Show dependency tree
 
Reported: 2014-05-04 08:23 UTC by poncho
Modified: 2014-06-27 09:10 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gnome-control-center-build.log (build.log,10.81 KB, text/srt)
2014-05-04 08:23 UTC, poncho
Details
gnome-control-center-3.12.1-optional-goa-fix.patch (gnome-control-center-3.12.1-optional-goa-fix.patch,601 bytes, patch)
2014-06-22 19:04 UTC, Émeric Maschino
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description poncho 2014-05-04 08:23:32 UTC
Created attachment 376314 [details]
gnome-control-center-build.log

gnome-base/gnome-control-center-3.12.1:2  USE="bluetooth colord cups v4l -debug -gnome-online-accounts -i18n -kerberos" INPUT_DEVICES="-wacom"

checking for BACKGROUND_PANEL... no
configure: error: Package requirements (gtk+-3.0 >= 3.11.1
 glib-2.0 >= 2.39.91
 gthread-2.0
 gio-2.0
 gio-unix-2.0
 gsettings-desktop-schemas >= 3.9.91 libxml-2.0 gnome-desktop-3.0
                  gdk-pixbuf-2.0 >= 2.23.0
                  goa-1.0 >= 3.9.90
                  grilo-0.2 >= 0.2.6) were not met:

No package 'goa-1.0' found

The background panel depends on goa since upstream added Flickr support.
See https://git.gnome.org/browse/gnome-control-center/commit/configure.ac?h=gnome-3-12&id=2e86e9e018e4b1ef5205c82b0b05363bd9e37288
Comment 1 Émeric Maschino 2014-06-22 17:07:19 UTC
Just hit this one that is really a blocker on ia64. Indeed, gnome-online-accounts relies upon webkit-gtk whose JS engine is completely broken on ia64 (https://bugs.webkit.org/show_bug.cgi?id=129992).
Comment 2 Émeric Maschino 2014-06-22 19:04:12 UTC
Created attachment 379420 [details, diff]
gnome-control-center-3.12.1-optional-goa-fix.patch
Comment 3 Émeric Maschino 2014-06-22 19:07:30 UTC
(In reply to poncho from comment #0)
> gnome-base/gnome-control-center-3.12.1:2  USE="bluetooth colord cups v4l
> -debug -gnome-online-accounts -i18n -kerberos" INPUT_DEVICES="-wacom"
> 
> checking for BACKGROUND_PANEL... no
> configure: error: Package requirements (gtk+-3.0 >= 3.11.1
>  glib-2.0 >= 2.39.91
>  gthread-2.0
>  gio-2.0
>  gio-unix-2.0
>  gsettings-desktop-schemas >= 3.9.91 libxml-2.0 gnome-desktop-3.0
>                   gdk-pixbuf-2.0 >= 2.23.0
>                   goa-1.0 >= 3.9.90
>                   grilo-0.2 >= 0.2.6) were not met:
> 
> No package 'goa-1.0' found

OK, this first one is trivial: gnome-control-center-3.12.1-optional.patch seems incomplete and forgot to remove unconditional check on goa-1.0. I've attached a patch (attachment #379420 [details, diff]) to fix this. Don't forget to copy the patch in the files/ hierarchy and add it in ebuild (cf. line with arrow):

	# Make some panels and dependencies optional; requires eautoreconf
	# https://bugzilla.gnome.org/686840, 697478, 700145
	epatch "${FILESDIR}"/${PN}-3.12.1-optional.patch
------>	epatch "${FILESDIR}"/${PN}-3.12.1-optional-goa-fix.patch

	# Fix some absolute paths to be appropriate for Gentoo
	epatch "${FILESDIR}"/${PN}-3.10.2-gentoo-paths.patch

Or feel free to merge it with gnome-control-center-3.12.1-optional.patch. This would be a cleaner solution in my opinion.

Anyway, it seems that g-o-a disabling in g-c-c isn't complete, as even with --disable-goa correctly handled, you'll then hit the following error:

/bin/sh ../../libtool  --tag=CC   --mode=compile ia64-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../.. -I../../ -DG_LOG_DOMAIN="\"background-cc-panel\"" -DPANEL_ID="\"background\"" -pthread -I/usr/include/gnome-desktop-3.0 -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/grilo-0.2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -I/usr/include/gsettings-desktop-schemas  -DGNOMELOCALEDIR="\"/usr/share/locale\"" -DDATADIR="\"/usr/share\"" -DGNOME_DESKTOP_USE_UNSTABLE_API     -mtune=itanium2 -O2 -pipe -c -o cc-background-grilo-miner.lo cc-background-grilo-miner.c
libtool: compile:  ia64-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../.. -I../../ -DG_LOG_DOMAIN=\"background-cc-panel\" -DPANEL_ID=\"background\" -pthread -I/usr/include/gnome-desktop-3.0 -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/grilo-0.2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -I/usr/include/gsettings-desktop-schemas -DGNOMELOCALEDIR=\"/usr/share/locale\" -DDATADIR=\"/usr/share\" -DGNOME_DESKTOP_USE_UNSTABLE_API -mtune=itanium2 -O2 -pipe -c cc-background-grilo-miner.c  -fPIC -DPIC -o .libs/cc-background-grilo-miner.o
cc-background-grilo-miner.c:24:21: fatal error: goa/goa.h: No such file or directory
compilation terminated.
make[4]: *** [cc-background-grilo-miner.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: Leaving directory `/var/tmp/portage/gnome-base/gnome-control-center-3.12.1/work/gnome-control-center-3.12.1/panels/background'
make[3]: *** [all] Error 2
make[3]: Leaving directory `/var/tmp/portage/gnome-base/gnome-control-center-3.12.1/work/gnome-control-center-3.12.1/panels/background'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/var/tmp/portage/gnome-base/gnome-control-center-3.12.1/work/gnome-control-center-3.12.1/panels'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/gnome-base/gnome-control-center-3.12.1/work/gnome-control-center-3.12.1'
make: *** [all] Error 2

So, dependencies on g-o-a seem to remain here and there.
Comment 4 Pacho Ramos gentoo-dev 2014-06-22 19:19:15 UTC
That is because the patch also needs to skip compilation of cc-background-grilo-miner.c as it needs goa... and that is the cause it's checked unconditionally in configure.ac :(
Comment 5 Pacho Ramos gentoo-dev 2014-06-25 10:08:25 UTC
Probably we could skip "background" from panels/Makefile.am... but I am not sure how will it really work :|
Comment 7 Alexandre Rostovtsev (RETIRED) gentoo-dev 2014-06-26 02:45:43 UTC
Fixed by adding some more #ifdefs to our *-optional patch.

+*gnome-control-center-3.12.1-r1 (26 Jun 2014)
+
+  26 Jun 2014; Alexandre Rostovtsev <tetromino@gentoo.org>
+  +gnome-control-center-3.12.1-r1.ebuild,
+  +files/gnome-control-center-3.12.1-optional-r1.patch:
+  Really don't use gnome-online-accounts when USE=-gnome-online-accounts (bug
+  #509514, thanks to poncho and Émeric Maschino).