Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 508920 - >=sys-power/upower-0.99 re-keywording request
Summary: >=sys-power/upower-0.99 re-keywording request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Freedesktop bugs
URL:
Whiteboard:
Keywords:
Depends on: 510096
Blocks: gnome-3.12
  Show dependency tree
 
Reported: 2014-04-27 22:43 UTC by Gilles Dartiguelongue (RETIRED)
Modified: 2014-05-31 20:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gilles Dartiguelongue (RETIRED) gentoo-dev 2014-04-27 22:43:58 UTC
Hi,

This is required by Gnome 3.12.
I recommend re-adding the keywords but keeping this version masked with Gnome 3.12 as not all packages supports the new API and dbus interfaces.

This will probably have an impact on other desktops but I have no idea how to deal with it right now.
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2014-05-10 21:40:34 UTC
I plan on re-keywording this and unmask Gnome 3.12 in a few days (maybe tomorrow) if no-one objects.
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2014-05-11 05:19:01 UTC
(In reply to Gilles Dartiguelongue from comment #1)
> I plan on re-keywording this and unmask Gnome 3.12 in a few days (maybe
> tomorrow) if no-one objects.

I planned on waiting until rest of the year because xfce4-power-manager and none of the other reverse deps are compatible with the new API yet

So I definately object
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2014-05-11 05:19:50 UTC
This is to be considered experimental release, not to be used yet
Comment 4 Pacho Ramos gentoo-dev 2014-05-11 08:51:07 UTC
(In reply to Samuli Suominen from comment #2)
> (In reply to Gilles Dartiguelongue from comment #1)
> > I plan on re-keywording this and unmask Gnome 3.12 in a few days (maybe
> > tomorrow) if no-one objects.
> 
> I planned on waiting until rest of the year because xfce4-power-manager and
> none of the other reverse deps are compatible with the new API yet
> 
> So I definately object

I have seen opensuse is using a xfce4-power-manager git snapshot to support upower-0.99
Comment 5 Pacho Ramos gentoo-dev 2014-05-11 08:54:10 UTC
Well, since Fedora, Arch and openSuSE (at least) already migrated to upower-0.99 some time ago I think we can look at them for the rest of packages pending to migrate :/
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2014-05-11 17:03:20 UTC
xfce4-power-manager-1.2.0_p20140511 in Portage, but that covers only Xfce and GNOME then, everything else is still undone, so keywording is still out of question
Comment 7 Alexandre Rostovtsev (RETIRED) gentoo-dev 2014-05-11 22:34:34 UTC
(In reply to Samuli Suominen from comment #6)
> everything else is still undone

everything else = what? The traditional way to resolve issues like this is to make a list of what is broken with 0.99, tell maintainers where to get patches (upstream git, Fedora, etc.), wait a bit and then unmask.
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2014-05-12 03:22:29 UTC
(In reply to Alexandre Rostovtsev from comment #7)
> (In reply to Samuli Suominen from comment #6)
> > everything else is still undone
> 
> everything else = what? The traditional way to resolve issues like this is
> to make a list of what is broken with 0.99, tell maintainers where to get
> patches (upstream git, Fedora, etc.), wait a bit and then unmask.

it's easy with packages that use shared library, but upower works (mostly) using dbus calls, and nobody has even announced this level of major change in the mails, the bugzilla, or possibly the ML to give the respective maintainers chance to test it (not everyone is on freedesktop-bugs alias)

so yeah, I don't have a full list to give you without manual testing of each reverse dependency, which is why this needs extra long testing period to begin with

you can possibly speed up the testing by sending out those mails to maintainers, i'll do that myself later if nobody else will, but there is no hurry since xfce4-power-manager didn't remove support for old API, only added support for newer API too, as upstream correctly assumed it's unrealistic everything would be ported at the same time
Comment 9 Pacho Ramos gentoo-dev 2014-05-12 06:12:38 UTC
Well, I can try to review all packages rdepending on upower to see if they have patches in other distros to support newer upower (will take some time as I don't have much time until weekends but I volunteer to do that :))
Comment 10 Samuli Suominen (RETIRED) gentoo-dev 2014-05-12 18:32:30 UTC
I think we will stay with 0.9.23 (the 0.9 upower git branch) for long as sys-apps/openrc is the default in Gentoo as per bug 510096
Comment 11 Samuli Suominen (RETIRED) gentoo-dev 2014-05-12 18:34:01 UTC
(In reply to Samuli Suominen from comment #10)
> I think we will stay with 0.9.23 (the 0.9 upower git branch) for long as
> sys-apps/openrc is the default in Gentoo as per bug 510096

I might introduce some sys-power/upower-legacy for the 0.9 branch at later time, and make it block the systemd-only sys-power/upower
Will need to think about this and investigate futher, but keywording is out of question at this time
Comment 12 Alexandre Rostovtsev (RETIRED) gentoo-dev 2014-05-12 20:26:52 UTC
(In reply to Samuli Suominen from comment #10)
> I think we will stay with 0.9.23 (the 0.9 upower git branch) for long as
> sys-apps/openrc is the default in Gentoo as per bug 510096

Oh wow. So 0.99 doesn't let non-systemd systems suspend at all :/

In this case, we probably need to patch gnome-3.12 to support the 0.9 branch. Because the alternative is convincing all desktops to switch to systemd right now, and that seems unrealistic.
Comment 13 Pacho Ramos gentoo-dev 2014-05-15 07:48:36 UTC
(In reply to Alexandre Rostovtsev from comment #12)
> (In reply to Samuli Suominen from comment #10)
> > I think we will stay with 0.9.23 (the 0.9 upower git branch) for long as
> > sys-apps/openrc is the default in Gentoo as per bug 510096
> 
> Oh wow. So 0.99 doesn't let non-systemd systems suspend at all :/
> 
> In this case, we probably need to patch gnome-3.12 to support the 0.9
> branch. Because the alternative is convincing all desktops to switch to
> systemd right now, and that seems unrealistic.

Per:
http://permalink.gmane.org/gmane.comp.gnome.release-team/2707

Looks like we would need to at least revert a lot of changes in gnome-control-center and, now that even ubuntu/debian world moved to systemd and "power management" doesn't "matter" on BSD setups, I am unsure if we would be able to keep that reversions for a long time (if we are even able to revert the dep at first).

Have you think about having two different packages with blockers between them? The "legacy-upower" and the new one. That way, packages having support for both could rdepend on new upower if "systemd" USE is set and old one if not. Packages requiring old one could rdepend on that and the same for new upower
Comment 14 Pacho Ramos gentoo-dev 2014-05-15 07:50:09 UTC
Oops, I just seen that it's similar to Samuli's suggestion in comment #11 (sorry, once I read the full thread I was googling for some time and forget it :S)
Comment 15 Samuli Suominen (RETIRED) gentoo-dev 2014-05-26 20:03:57 UTC
OK, let's see what is done:

1. sys-power/upower-pm-utils is in Portage which means 0.9 git branch with --enable-deprecated enabled
2. >=sys-power/upower-0.99 ebuild adjusted accordingly, removed sys-power/pm-utils dependency which was bogus, but did NOT force sys-apps/systemd because it actually works for not-in-portage-yet xfce4-power-manager and xfce4-session git masters because Xfce upstream actually moved the pm-utils support that upower had, over directly to the apps, which is likely what other upstreams will do too eventually
3. Fixed dependencies for xfce-*/*, sys-apps/uevt, x11-plugins/wmbattery, ... to allow sys-power/upower-pm-utils, most others are still UNDONE

What is most certainly undone and prevents keywording:

Item 1:

From list of http://qa-reports.gentoo.org/output/genrdeps/rindex/sys-power/upower the packages need to be converted to:

If they support both, 0.9 and 0.99, with, or without pm-utils:

|| ( sys-power/upower sys-power/upower-pm-utils )

If they support only old upower API:

|| ( <sys-power/upower-0.99 sys-power/upower-pm-utils )

If they support only new upower API:

>=sys-power/upower-0.99

Item 2:

Need to create a new xfce4-power-manager, xfce4-session, and likely more git snapshots for integrated pm-utils support so they will continue to work together with 0.99 even without systemd

Item 3:

A lot of testing, and propably forgot a lot of things, but keywording is totally out of question, you better make GNOME work with 0.9.x for now
Comment 16 Pacho Ramos gentoo-dev 2014-05-26 21:21:39 UTC
Will help on testing other reverse deps, but I think we will need to keyword it in the "near" future as I don't see how to make Gnome 3.12 work with old upower (specially now that we are the only distro needing that :( )

Regarding systemd dependency, I guess it's right to not pull it from upower-0.99 itself but from the utility relying on systemd to hibernate/suspend (as gnome stuff) 

(Well, I am updating since yesterday to 3.12 but got blocked by some build failures and my webkit-gtk friends that take hours to compile and got rebuilt again due icu update :@)
Comment 17 Eric Koegel 2014-05-30 17:26:05 UTC
If this helps, using http://qa-reports.gentoo.org/output/genrdeps/rindex/sys-power/upower (which was really helpful), I've written some patches for XFCE:

xfce-extra/xfce4-weather-plugin-0.8.3
https://bugzilla.xfce.org/show_bug.cgi?id=10922

xfce-extra/xfce4-systemload-plugin-1.1.1
https://bugzilla.xfce.org/show_bug.cgi?id=10923

xfce-base/xfce4-session-4.11.0
https://bugzilla.xfce.org/show_bug.cgi?id=9952

xfce-base/xfce4-settings-4.11.2
https://bugzilla.xfce.org/show_bug.cgi?id=10918

Just a FYI in case this is useful. They still have to be reviewed/applied.
Comment 18 Samuli Suominen (RETIRED) gentoo-dev 2014-05-30 17:28:38 UTC
(In reply to Eric Koegel from comment #17)
> If this helps, using
> http://qa-reports.gentoo.org/output/genrdeps/rindex/sys-power/upower (which
> was really helpful), I've written some patches for XFCE:
> 
> xfce-extra/xfce4-weather-plugin-0.8.3
> https://bugzilla.xfce.org/show_bug.cgi?id=10922
> 
> xfce-extra/xfce4-systemload-plugin-1.1.1
> https://bugzilla.xfce.org/show_bug.cgi?id=10923
> 
> xfce-base/xfce4-session-4.11.0
> https://bugzilla.xfce.org/show_bug.cgi?id=9952
> 
> xfce-base/xfce4-settings-4.11.2
> https://bugzilla.xfce.org/show_bug.cgi?id=10918
> 
> Just a FYI in case this is useful. They still have to be reviewed/applied.

It is indeed useful! Thanks!

Only rest of the Portage tree left... like anything but Xfce and GNOME :/
Comment 19 Samuli Suominen (RETIRED) gentoo-dev 2014-05-31 20:41:52 UTC
0.99 keyworded, most of the tree converted one way or another