Bug 506212 – x11-wm/awesome-3.5.3 version bump

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Gino McCarty 2014-03-30 03:34:55 UTC]

Hey, awesome 3.5.3 just got released here is an ebuild for the bump
also integrated a patches xsession .desktop file

Reproducible: Always

[Comment 1 Gino McCarty 2014-03-30 03:35:44 UTC]

Created attachment 373872 [details]
awesome-3.5.3

[Comment 2 Gino McCarty 2014-03-30 03:36:21 UTC]

Created attachment 373874 [details, diff]
Fix Xsession DM's to use proper gentoo session files

[Comment 3 Jeroen Roovers (RETIRED) 2014-03-30 03:38:57 UTC]

CC: 	[e-mail] did not match anything

FTFY

[Comment 4 Gino McCarty 2014-03-30 03:45:55 UTC]

awesome seems to have allot of maintainers listed, as well as the proxy maintainer list. If you need an official maintainer I'd be more than happy to step in.

[Comment 5 Bohdan Trach 2014-03-30 17:30:56 UTC]

This ebuild is slightly incorrect, the minimum supported lgi version is 0.7. But anyway, thanks for posting the ebuild.

[Comment 6 Gino McCarty 2014-03-31 01:25:16 UTC]

Created attachment 373954 [details]
awesome-3.5.3

Fixed lgi version

[Comment 7 Maxim Koltsov (RETIRED) 2014-03-31 14:25:13 UTC]

(In reply to Bombino from comment #2)
> Created attachment 373874 [details, diff] [details, diff]
> Fix Xsession DM's to use proper gentoo session files

Hi,
Can you explain the purpose of this patch?

[Comment 8 Gino McCarty 2014-03-31 15:38:57 UTC]

(In reply to Maxim Koltsov from comment #7)
> (In reply to Bombino from comment #2)
> > Created attachment 373874 [details, diff] [details, diff] [details, diff]
> > Fix Xsession DM's to use proper gentoo session files
> 
> Hi,
> Can you explain the purpose of this patch?

In gentoo we have our x11/session files to setup the x environment prior to starting the wm.. This change takes that script into account

Without this change any xdm's that use xsession .desktop files will not property build the environment prior to starting X .. Xrdb, keyboard mapping, xinitrc.d etc...

Some xdm's scripts overlap here but there is no harm in that most do not

[Comment 9 Maxim Koltsov (RETIRED) 2014-03-31 17:13:40 UTC]

(In reply to Bombino from comment #8)
> (In reply to Maxim Koltsov from comment #7)
> > (In reply to Bombino from comment #2)
> > > Created attachment 373874 [details, diff] [details, diff] [details, diff] [details, diff]
> > > Fix Xsession DM's to use proper gentoo session files
> > 
> > Hi,
> > Can you explain the purpose of this patch?
> 
> In gentoo we have our x11/session files to setup the x environment prior to
> starting the wm.. This change takes that script into account
> 
> Without this change any xdm's that use xsession .desktop files will not
> property build the environment prior to starting X .. Xrdb, keyboard
> mapping, xinitrc.d etc...
> 
> Some xdm's scripts overlap here but there is no harm in that most do not

Okay, I'll trust you :)
Commited to the tree.

[Comment 10 Ian Stakenvicius (RETIRED) 2016-01-25 18:25:17 UTC]

(In reply to Harvey Mittens from comment #8)
> (In reply to Maxim Koltsov from comment #7)
> > (In reply to Bombino from comment #2)
> > > Created attachment 373874 [details, diff] [details, diff] [details, diff] [details, diff]
> > > Fix Xsession DM's to use proper gentoo session files
> > 
> > Hi,
> > Can you explain the purpose of this patch?
> 
> In gentoo we have our x11/session files to setup the x environment prior to
> starting the wm.. This change takes that script into account
> 
> Without this change any xdm's that use xsession .desktop files will not
> property build the environment prior to starting X .. Xrdb, keyboard
> mapping, xinitrc.d etc...
> 
> Some xdm's scripts overlap here but there is no harm in that most do not

...no, this shouldn't be done.  The script in /etc/X11/Sessions/ is specifically for chooser.sh and allowing the XSESSION environment variable and/or the ~/.xsession file to determine what WM or DE is started in startx or by XDM.  

Startx or the DM are what should handle processing of all the various bits like Xrdb and xinitrc.d and so forth, not the /etc/X11/Sessions/ scripts; if awesome's script is doing that then there are bigger problems.  Recommend reverting that patch with extreme prejudice.

[Comment 11 Coacher 2016-01-25 18:32:52 UTC]

Fellow awesome co-maintainers, currently I am working on a revbump for awesome. It should be ready in the next few days. I am going to exclude this patch there and fix some other minor issues as well. Please avoid doing a revbump immediately wrt the comment above to prevent revbump spamming. ETA is 3-5 days.

[Comment 12 Coacher 2016-02-03 03:00:52 UTC]

(In reply to Coacher from comment #11)
> Fellow awesome co-maintainers, currently I am working on a revbump for
> awesome. It should be ready in the next few days. I am going to exclude this
> patch there and fix some other minor issues as well. Please avoid doing a
> revbump immediately wrt the comment above to prevent revbump spamming. ETA
> is 3-5 days.

https://github.com/Coacher/gentoo/commit/09b4626dff541091c1f8694e50e5f5ca35862758, which is a part of https://github.com/gentoo/gentoo/pull/774