Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 506068 - app-text/qpdfview-0.4.11 version bump
Summary: app-text/qpdfview-0.4.11 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2014-03-28 12:45 UTC by José Romildo Malaquias
Modified: 2014-09-28 09:03 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Version bump ebuild (qpdfview-0.4.9.ebuild,2.08 KB, text/plain)
2014-03-29 09:15 UTC, Sébastien Szymanski
Details
Add pdf handler patch (qpdfview-0.4.9-add-pdf-handler.patch,404 bytes, patch)
2014-03-29 09:15 UTC, Sébastien Szymanski
Details | Diff
qpdfview 0.4.10 ebuild (qpdfview-0.4.10.ebuild,2.02 KB, text/plain)
2014-05-04 19:30 UTC, Sébastien Szymanski
Details
fix build without sql patch (qpdfview-0.4.10-fix-without-sql-build.patch,353 bytes, patch)
2014-05-04 19:31 UTC, Sébastien Szymanski
Details | Diff
qpdfview-0.4.11.1.ebuild (qpdfview-0.4.11.1.ebuild,2.28 KB, text/plain)
2014-09-16 13:52 UTC, Alpha Bravo
Details
qpdfview-0.4.11.1.ebuild some issues fixed (qpdfview-0.4.11.1.ebuild,2.34 KB, text/plain)
2014-09-18 11:25 UTC, Alpha Bravo
Details
qpdfview-0.4.11.1.ebuild at-most-one of fitz pdf (qpdfview-0.4.11.1.ebuild,2.35 KB, text/plain)
2014-09-18 14:52 UTC, Alpha Bravo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description José Romildo Malaquias 2014-03-28 12:45:04 UTC
qpdfview-0.4.9 has already been released. Please update portage.

Release notes:

Version 0.4.8:
Fixed building without SQLite support.
Fixed a performance problem when switching tabs could take seconds.
Added zoom functionality to the presentation view.
Added optional functionality to restore closed tabs.

Version 0.4.9:
Adds experimental Fitz plug-in.
Adds option to switch multiple-page layouts into right-to-left mode.
Adds support to use X11 selection buffer instead of clipboard.
Comment 1 Sébastien Szymanski 2014-03-29 09:15:03 UTC
Created attachment 373804 [details]
Version bump ebuild

Here an ebuild for this version. The changes are:

- update PLOCALES
- add fitz use flag. This flag adds a dependency on mupdf:0/.13
- remove fix-sqlite-build.patch
- add add-pdf-handler.patch. This patch is needed to make Fitz rendering work. 
- remove -lmupdf-js-none in fitz-plugin.pro
Comment 2 Sébastien Szymanski 2014-03-29 09:15:45 UTC
Created attachment 373806 [details, diff]
Add pdf handler patch
Comment 3 Davide Pesavento (RETIRED) gentoo-dev 2014-03-29 13:42:13 UTC
(In reply to Sébastien Szymanski from comment #1)
> - remove fix-sqlite-build.patch

why? was it applied upstream?

> - remove -lmupdf-js-none in fitz-plugin.pro

why?
Comment 4 Sébastien Szymanski 2014-03-29 17:54:35 UTC
(In reply to Davide Pesavento from comment #3)
> (In reply to Sébastien Szymanski from comment #1)
> > - remove fix-sqlite-build.patch
> 
> why? was it applied upstream?

Yes.

> 
> > - remove -lmupdf-js-none in fitz-plugin.pro
> 
> why?

Well, it doesn't build with it so I tried without it. ldd doesn't report any missing library.
Comment 5 Franz Trischberger 2014-04-01 06:47:05 UTC
(In reply to Davide Pesavento from comment #3)
> (In reply to Sébastien Szymanski from comment #1) 
> > - remove -lmupdf-js-none in fitz-plugin.pro
> 
> why?

commit 11187eb5f0220e3822cde16d632e158f51b850b3
Author: Tor Andersson <tor.andersson@artifex.com>
Date:   Thu Mar 20 14:13:06 2014 +0100

    Add MuJS submodule, implementation and build.
    
    Adds simpler choice of Javascript library to makefiles.
    Will prefer in order: MuJS, JavaScriptCore, V8, none based
    on HAVE_MUJS, HAVE_JSCORE, and HAVE_V8.
    
    For simplicity, we build mujstest even with no javascript implementation.
Comment 6 Franz Trischberger 2014-04-01 07:08:17 UTC
And the ebuilds also seem to touch mupdf js-none lib - though I need some more cups of coffee to understand that sed line °|°
Comment 7 Adam Reichold 2014-05-04 08:41:10 UTC
Hello everyone,

we just released version 0.4.10 of qpdfview and also updated the (experimental) Fitz plug-in for the API changes of MuPDF version 1.4, i.e. we don't link against "libmupdf-js-none.a" and call "fz_register_document_handler". Hope this helps.

Best regards, Adam.
Comment 8 Sébastien Szymanski 2014-05-04 19:30:12 UTC
Created attachment 376360 [details]
qpdfview 0.4.10 ebuild

Hello,

I have updated the ebuild to qpdfview 0.4.10. The changes are:

- fitz use flag dependency is now mupdf:0/1.4.
- remove add-pdf-handler.patch.
- add fix-without-sql-build.patch to fix build when building without sql_lite support.
Comment 9 Sébastien Szymanski 2014-05-04 19:31:20 UTC
Created attachment 376362 [details, diff]
fix build without sql patch
Comment 10 Adam Reichold 2014-05-05 15:05:41 UTC
Hello again,

sorry for messing up the SQLite-less build again. Will merge that patch upstream as soon as possible.

Best regards, Adam.
Comment 11 Franz Trischberger 2014-06-15 07:57:26 UTC
I did not find a way how to select pdf backend if both poppler and mupdf are available. So I assumed those can not be present at the same time and deactivated poppler if mupdf USE-Flag is set in my Overlay [0]. Is this assumption correct?

[0] https://github.com/ff2000/gentoo-overlay/blob/master/app-text/qpdfview/qpdfview-0.4.10.ebuild (this also forces Qt5)
Comment 12 Adam Reichold 2014-06-19 21:13:56 UTC
(In reply to Franz Fellner from comment #11)
> I did not find a way how to select pdf backend if both poppler and mupdf are
> available. So I assumed those can not be present at the same time and
> deactivated poppler if mupdf USE-Flag is set in my Overlay [0]. Is this
> assumption correct?
> 
> [0]
> https://github.com/ff2000/gentoo-overlay/blob/master/app-text/qpdfview/
> qpdfview-0.4.10.ebuild (this also forces Qt5)

Hello Franz,

yes this is correct, the MuPDF plug-in is disabled by default, but if it is enabled, it will override the Poppler plug-in. (They are technically both present, but there is no setting to select one of them explicitly.)

Best regards, Adam.

P.S.: Please note that the MuPDF/Fitz plug-in is still considered somewhat experimental.
Comment 13 Adam Reichold 2014-06-20 14:38:29 UTC
(In reply to Adam Reichold from comment #12)
> (In reply to Franz Fellner from comment #11)
> > I did not find a way how to select pdf backend if both poppler and mupdf are
> > available. So I assumed those can not be present at the same time and
> > deactivated poppler if mupdf USE-Flag is set in my Overlay [0]. Is this
> > assumption correct?
> > 
> > [0]
> > https://github.com/ff2000/gentoo-overlay/blob/master/app-text/qpdfview/
> > qpdfview-0.4.10.ebuild (this also forces Qt5)
> 
> Hello Franz,
> 
> yes this is correct, the MuPDF plug-in is disabled by default, but if it is
> enabled, it will override the Poppler plug-in. (They are technically both
> present, but there is no setting to select one of them explicitly.)
> 
> Best regards, Adam.
> 
> P.S.: Please note that the MuPDF/Fitz plug-in is still considered somewhat
> experimental.

Sorry, I got mixed up: Because it is considered experimental, the Poppler plug-in is preferred over the Fitz plug-in.
Comment 14 Adam Reichold 2014-07-20 08:23:24 UTC
Hello,

qpdfview version 0.4.11 was just released after three weeks of beta testing and can hopefully be packaged without excessive patching.

Best regards, Adam.
Comment 15 Alpha Bravo 2014-09-16 13:52:43 UTC
Created attachment 384840 [details]
qpdfview-0.4.11.1.ebuild

The attached qpdfview-0.4.11.1.ebuild additionally enables building with Qt5 by the respective USE flag.
Comment 16 Alpha Bravo 2014-09-18 11:25:59 UTC
Created attachment 385000 [details]
qpdfview-0.4.11.1.ebuild some issues fixed
Comment 17 Franz Trischberger 2014-09-18 13:49:20 UTC
Look at comment #19: If you offer USE="fitz" give the user the chance to actually use fitz ;) You need to DISABLE pdf (aka. poppler-backend), otherwise USE="fitz" has no effect.

@ Adam Reichold: is there a TODO which tasks need to be done to make fitz-backend non-experimental? Are there still features missing or is it just (public) testing?
Comment 18 Alpha Bravo 2014-09-18 14:52:43 UTC
Created attachment 385032 [details]
qpdfview-0.4.11.1.ebuild at-most-one of fitz pdf
Comment 19 Ben de Groot (RETIRED) gentoo-dev 2014-09-27 01:44:16 UTC
Latest version in tree now. Thanks for your contributions!
Comment 20 Adam Reichold 2014-09-28 09:03:05 UTC
(In reply to Franz Fellner from comment #17)
> @ Adam Reichold: is there a TODO which tasks need to be done to make
> fitz-backend non-experimental? Are there still features missing or is it
> just (public) testing?

Hello Franz,

there is no TODO since the reason not just technical: I wrote the Fitz plug-in because of a feature request some time ago but it is basically missing a maintainer since because I am mostly occupied with the application and the Poppler plug-in. So there is almost no testing of this code from my side.
I am also reluctant to mark this as non-experimental since MuPDF/Fitz is currently packaged as a static library without a stable API or ABI.

Best regards, Adam.