Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 505818 - dev-db/redis-2.8.8 version bump
Summary: dev-db/redis-2.8.8 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Low enhancement (vote)
Assignee: Ultrabug
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-26 01:09 UTC by Johan Bergström
Modified: 2014-03-31 09:25 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
redis-2.8.8.ebuild (redis-2.8.8.ebuild,2.92 KB, text/plain)
2014-03-26 01:40 UTC, Johan Bergström
Details
redis-2.8.8-hiredis.patch (redis-2.8.8-hiredis.patch,1.84 KB, patch)
2014-03-26 01:42 UTC, Johan Bergström
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Bergström 2014-03-26 01:09:08 UTC
Rename works for me.

Changelog:


# UPGRADE URGENCY: HIGH for Redis, LOW for Sentinel. There is a potentially
                   critical bug fix causing data loss in Redis but it requires
                   a combination of disk full and the use of the
                   SHUTDOWN command.

* [FIX] Fixed data loss when SHUTDOWN was used with a disk full condition.
* [FIX] Fixed a memory leak in the SORT syntax error processing.
* [FIX] When Sentinel down-after-milliseconds parameter is modified at runtime
        now it gets propagated to all the slaves and sentinel instances
        of the master.
* [FIX] `install_server.sh` script finally fixed.
* [FIX] Different fixes to maxclients handling.

* [NEW] Sentinels are now able to send update messages in a peer-to-peer
        fashion even if no Redis instances are available. Now the Sentinel
        liveness property that the most updated configuration in a given
        partition is propagated to all the Sentinels is extended to partitions
        without reachable instances.
* [NEW] Sentinel safety properties are now ensured in a crash-recovery system
        model since some state is persisted on disk before replying to other
        nodes, and reloaded at startup.
* [NEW] Sentinel now uses CLIENT SETNAME so that it is easy to identify
        Sentinels using CLIENT LIST among other clients.
* [NEW] Sentinel failure detection and reconnection code improved.
* [NEW] Use all 24 bits (instead of 22) for the Redis objects LRU field.
        Note that the new LRU algorithm using eviction pools was not backported
        from unstable for safery / code maturity concerns.
* [NEW] Majory speedup for the INFO command (it is now 6 times faster).
* [NEW] More Sentinel unit tests.
* [NEW] New command DEBUG ERROR returns the specified error. Example:
        DEBUG ERROR "LOADING database". This is handy to write Redis client
        libraries unit tests.
* [NEW] redis-cli now supports multi-line editing via updated linenoise lib.

Thanks to Matt Stancliff and Jan-Erik Rediger for the work done in the context
of this release.
Comment 1 Johan Bergström 2014-03-26 01:40:48 UTC
Created attachment 373538 [details]
redis-2.8.8.ebuild

In the spirit of gentoo, I decided to decouple hiredis from the ebuild. We now dep on dev-libs/hiredis (which is slightly newer) and link to it.
Comment 2 Johan Bergström 2014-03-26 01:42:41 UTC
Created attachment 373540 [details, diff]
redis-2.8.8-hiredis.patch
Comment 3 Johan Bergström 2014-03-26 01:44:22 UTC
I guess what we additionally could do is add IUSE=static which would build and link against bundled jemalloc and hiredis. What does the other maintainers think?
Comment 4 Johan Bergström 2014-03-26 02:07:15 UTC
I'm actually getting some errors in specific redis-cli commands. If you're trigger happy on bumping, leave hiredis patch out of it.
Comment 5 Johan Bergström 2014-03-26 02:39:54 UTC
if interested:

redisReaderGetReply (r=0x7ffff6818080, reply=0x7fffffffdff0) at hiredis.c:655
655	        r->len = sdslen(r->buf);

#0  redisReaderGetReply (r=0x7ffff6818080, reply=0x7fffffffdff0) at hiredis.c:655
#1  0x00007ffff7bd65c4 in redisGetReplyFromReader (c=0x7ffff6816020, reply=<optimized out>) at hiredis.c:1139
#2  0x00007ffff7bd668b in redisGetReply (c=0x7ffff6816020, reply=0x7fffffffe038) at hiredis.c:1166
Comment 6 Ultrabug gentoo-dev 2014-03-31 08:51:32 UTC
Due to my limited time availability, I'm inclined to leave this ebuild as such and only do a version bump, would that be acceptable to you ?

If so, I'll bump this and this will give you more time to accomodate a possible hiredis split (which tbh sounds too zealous to me).
Comment 7 Johan Bergström 2014-03-31 08:59:45 UTC
Hey,
just verbumping is fine. The hiredis build will have to wait until I've managed to update hiredis in deps/ upstream. Thanks for helping out.
Comment 8 Ultrabug gentoo-dev 2014-03-31 09:25:27 UTC
kthx mate, done

+*redis-2.8.8 (31 Mar 2014)
+
+  31 Mar 2014; Ultrabug <ultrabug@gentoo.org> +redis-2.8.8.ebuild:
+  version bump fix #505818 thx to Johan Bergström
+