Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 504354 - [science overlay] sci-visualization/gnuplot cvs trunk has removed the emacs support files
Summary: [science overlay] sci-visualization/gnuplot cvs trunk has removed the emacs s...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-12 22:00 UTC by James Cloos
Modified: 2014-03-22 23:31 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Drop installation of Emacs support files (0001-Don-t-install-Emacs-support-files-as-the-they-have-b.patch,8.93 KB, text/plain; charset=utf-8)
2014-03-22 09:57 UTC, Ulrich Müller
Details
Add libcaca flag, remove thin-splines flag. (0002-Add-libcaca-USE-flag-thanks-to-James-Cloos-cloos-jhc.patch,2.44 KB, text/plain; charset=utf-8)
2014-03-22 10:02 UTC, Ulrich Müller
Details

Note You need to log in before you can comment on or make changes to this bug.
Description James Cloos 2014-03-12 22:00:02 UTC
All of the USE=emacs and USE=xemacs code should be removed from gnuplot-4.7.9999.ebuild.

The emacs support files are now their own package with HOMEPAGE at:

 https://github.com/bruceravel/gnuplot-mode

with one release at:

 https://github.com/bruceravel/gnuplot-mode/archive/0.6.1.tar.gz
Comment 1 James Cloos 2014-03-13 07:12:22 UTC
And when working on this, it would be useful to add a caca USE flag, conditionally R?DEPENDing on media-libs/libcaca, and adding:

"$(use_with caca caca "${EPREFIX}/usr/$(get_libdir)")" \

to the econf call.

The oldest version of libcaca in portage is already new enough for gnuplot trunk,
so a simple DEPEND is enough.

Without the explicit --with-caca gnuplot’s configure fails to find it, which suggests that if said configure is fixed to use pkg-config or caca-config it will start including caca support w/o an explicit dependency....
Comment 2 Christoph Junghans (RETIRED) gentoo-dev 2014-03-13 20:03:37 UTC
James, could you please do a pull-request to include these changes on <https://github.com/gentoo-science/sci>
Comment 3 Ulrich Müller gentoo-dev 2014-03-21 14:27:20 UTC
(In reply to James Cloos from comment #0)
> All of the USE=emacs and USE=xemacs code should be removed from
> gnuplot-4.7.9999.ebuild.
> 
> The emacs support files are now their own package with HOMEPAGE at:
> 
>  https://github.com/bruceravel/gnuplot-mode
> 
> with one release at:
> 
>  https://github.com/bruceravel/gnuplot-mode/archive/0.6.1.tar.gz

In fact, there are two gnuplot-mode packages for Emacs around, and both are actively maintained:

- gnuplot.el by Bruce Ravel and Phil Type (now at version 0.7.0)
  http://xafs.org/BruceRavel/GnuplotMode

- gnuplot-mode.el by Michael McCourt
  http://astro.berkeley.edu/~mkmcc/software/gnuplot-mode.html

The former seems to be what used to be included with gnuplot. Should we add one of them (or both) to the app-emacs category? I guess that would imply that we drop Emacs support (which is rather outdated) from the regular ebuild.
Comment 4 Ulrich Müller gentoo-dev 2014-03-21 14:38:08 UTC
(In reply to Ulrich Müller from comment #3)
> The former seems to be what used to be included with gnuplot. Should we add
> one of them (or both) to the app-emacs category?

Actually, it would mean that we restore the package, see bug 159726. Makes me wonder if the package should be called app-emacs/gnuplot (it's called "gnuplot" in MELPA) or app-emacs/gnuplot-mode (its former package name).
Comment 5 Ulrich Müller gentoo-dev 2014-03-22 09:57:41 UTC
Created attachment 373250 [details]
Drop installation of Emacs support files

Here's a patch for the ebuilds in the science overlay. I've ported the changes to the 4.6 ebuild too.
Comment 6 Ulrich Müller gentoo-dev 2014-03-22 10:02:00 UTC
Created attachment 373252 [details]
Add libcaca flag, remove thin-splines flag.

(In reply to James Cloos from comment #1)
> And when working on this, it would be useful to add a caca USE flag,
> conditionally R?DEPENDing on media-libs/libcaca, and adding:
> 
> "$(use_with caca caca "${EPREFIX}/usr/$(get_libdir)")" \
> 
> to the econf call.

See attached patch. There is a global "libcaca" USE flag already, so I've used this name instead.

I've also removed the "thin-splines" flag because the corresponding configure option doesn't exist any more:

   revision 1.343
   date: 2013/12/26 01:34:33;  author: sfeam;  state: Exp;  lines: +1 -15
   The option --enable-thin-splines no longer does anything; remove it.
Comment 7 Ulrich Müller gentoo-dev 2014-03-22 10:29:43 UTC
@ottxor: If you are o.k. with these changes, can you apply them please? I don't have commit access to the proj/sci repo.

I tend to drop Emacs support also from the ebuild in the main tree and restore app-emacs/gnuplot-mode instead. (Oh, man, if I think about all the hassle we went through to get this working properly in the gnuplot ebuild. Why didn't we think of the obvious solution before?)

CCing xemacs team, maybe you want to add an app-xemacs/gnuplot-mode too?
Comment 8 Christoph Junghans (RETIRED) gentoo-dev 2014-03-22 15:31:25 UTC
@ulm: Great work, I will take care of it later today.