Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 504232 - media-video/atomicparsley-wez: new package (fork of media-video/atomicparsley)
Summary: media-video/atomicparsley-wez: new package (fork of media-video/atomicparsley)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-11 16:34 UTC by Paolo Pedroni
Modified: 2014-03-11 19:08 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Quick and dirty ebuild for media-video/atomicparsley-0.9.6 (atomicparsley-0.9.6.ebuild,550 bytes, text/plain)
2014-03-11 16:34 UTC, Paolo Pedroni
Details
Correct ebuild for atomicparsley-0.9.6 (atomicparsley-0.9.6.ebuild,494 bytes, text/plain)
2014-03-11 16:54 UTC, Paolo Pedroni
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paolo Pedroni 2014-03-11 16:34:42 UTC
Created attachment 372394 [details]
Quick and dirty ebuild for media-video/atomicparsley-0.9.6

I found a (presumed) fork of the AtomicParsley project on bitbucket. It solves a lot of the problems with the current portage version (mainly segfaults).

Its build system is now autotools based and it doesn't need any of the original patches.

I wrote a quick and dirty ebuild that I am attaching here. I'm sure it can be improved (I wonder why the -fno-strict-aliasing flag is not actually appended, BTW) as I'm not a very good ebuild writer, but it's a starting point.
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2014-03-11 16:40:12 UTC
(In reply to Paolo Pedroni from comment #0)
> Created attachment 372394 [details]
> Quick and dirty ebuild for media-video/atomicparsley-0.9.6
> 
> I found a (presumed) fork of the AtomicParsley project on bitbucket. It
> solves a lot of the problems with the current portage version (mainly
> segfaults).

i'm not convinced of this.
this is one of the things I dislike about the easy use of github, people fork something and throw random patches there and they never the properly reviewed like this.

> I wrote a quick and dirty ebuild that I am attaching here. I'm sure it can
> be improved (I wonder why the -fno-strict-aliasing flag is not actually

because the append-flags line should be before `econf` in src_configure()

possible you could just grab the useful patches from there separately for review, so we could apply them on top of 0.9.0?
Comment 2 Paolo Pedroni 2014-03-11 16:53:21 UTC
(In reply to Samuli Suominen from comment #1)

> i'm not convinced of this.
> this is one of the things I dislike about the easy use of github, people
> fork something and throw random patches there and they never the properly
> reviewed like this.

Consider that the original project has been dead for a long while (last release in 2006), while the one I found has several contributors, is alive and well (judging by the bitbucket page). This is reported also in the original project forum.

> 
> > I wrote a quick and dirty ebuild that I am attaching here. I'm sure it can
> > be improved (I wonder why the -fno-strict-aliasing flag is not actually
> 
> because the append-flags line should be before `econf` in src_configure()

Thanks. I learn something new everyday. Amended ebuild on the way.

> possible you could just grab the useful patches from there separately for
> review, so we could apply them on top of 0.9.0?

Guess not. Code has been widely refactored and file names have changed (we're talking several releases and more than five years of development). If you don't believe me take a look at the project bitbucket page: https://bitbucket.org/wez/atomicparsley/commits/all

My humble opinion is that this project deserves to supplant the old one in portage.
Comment 3 Paolo Pedroni 2014-03-11 16:54:56 UTC
Created attachment 372396 [details]
Correct ebuild for atomicparsley-0.9.6
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2014-03-11 18:00:45 UTC
i don't doubt this one isn't useful, i'm just not sure if it should be a continuation to the original atomicparsley, perhaps we should rather add it in portage with a name like 'atomicparsley-wez'?
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2014-03-11 19:08:20 UTC
it's in portage :)

*atomicparsley-wez-0.9.6 (11 Mar 2014)

  11 Mar 2014; Samuli Suominen <ssuominen@gentoo.org>
  +atomicparsley-wez-0.9.6.ebuild:
  Initial commit wrt #504232 by Paolo Pedroni