Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 504124 - dev-java/java-config-wrapper: java-check-environment and java-1.5-fixer should source functions.sh from /lib/gentoo/functions.sh
Summary: dev-java/java-config-wrapper: java-check-environment and java-1.5-fixer shoul...
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Java (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on: 549508
Blocks: init.d_functions.sh
  Show dependency tree
 
Reported: 2014-03-10 20:40 UTC by Kirill Elagin
Modified: 2016-05-02 20:46 UTC (History)
9 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
java-config-wrapper-0.16-dont_source_functions_sh_from_etc_initd.patch (java-config-wrapper-0.16-dont_source_functions_sh_from_etc_initd.patch,389 bytes, patch)
2014-03-19 15:31 UTC, Lars Wendler (Polynomial-C) (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kirill Elagin 2014-03-10 20:40:24 UTC 
See bug 504116.
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2014-03-19 15:31:31 UTC 
Created attachment 373032 [details, diff]
java-config-wrapper-0.16-dont_source_functions_sh_from_etc_initd.patch

possible fix...
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-12-21 19:13:03 UTC 
<QA hat>

This is a trivial fix that doesn't come with any real backwards compatibility dangers. In fact, it improves safety of packages through replacing implicit dependency on private API of a medium-sized package by explicit dependency on small, dedicated package.

That said, 9 months (1.5yr in case of glibc) to apply the fix is definitely too long. Therefore, I'm setting a deadline on fixing the remaining bugs to 2014-12-27. If the bugs aren't fixed till that point, I will be committing simple 'sed' statements to replace the inherits.

</QA hat>
Comment 3 Georgi Georgiev 2015-04-16 13:56:00 UTC 
(In reply to Michał Górny from comment #2)
> <QA hat>
...
> That said, 9 months (1.5yr in case of glibc) to apply the fix is definitely
> too long. Therefore, I'm setting a deadline on fixing the remaining bugs to
> 2014-12-27. If the bugs aren't fixed till that point, I will be committing
> simple 'sed' statements to replace the inherits.
...
> </QA hat>

What happened to the deadline?
Comment 4 James Le Cuirot gentoo-dev 2015-04-16 14:09:18 UTC 
To be honest, I think the whole package can just go away. java-1.5-fixer is definitely obsolete and java-check-environment has limited usefulness now. The only other file is java-config, which should just symlink to java-config-2 now. I'll try to look at this at the weekend.
Comment 5 James Le Cuirot gentoo-dev 2016-02-18 17:07:48 UTC 
Right, after two inappropriate pull requests for this on GitHub and multiple moans at various people to get them to deal with this properly, I finally got off my arse and dealt with it myself. java-config has been revbumped so that it no longer depends on java-config-wrapper. I will last-rite java-config-wrapper when that goes stable.
Comment 6 Georgi Georgiev 2016-02-18 17:12:27 UTC 
(In reply to James Le Cuirot from comment #5)
> Right, after two inappropriate pull requests for this on GitHub and multiple
> moans at various people to get them to deal with this properly, I finally
> got off my arse and dealt with it myself. java-config has been revbumped so
> that it no longer depends on java-config-wrapper. I will last-rite
> java-config-wrapper when that goes stable.

You are the best! :hug:
Comment 7 James Le Cuirot gentoo-dev 2016-05-02 20:46:02 UTC 
java-config-wrapper has been last-rited.