Build fails due to illegal requests to object members. This is a @preserved-rebuild of the package after an openconnect update. Reproducible: Always Steps to Reproduce: 1/a. emerge -1 networkmanagement 1/b. emerge @preserved-rebuild #after a recent update Actual Results: Compilation fails. Expected Results: Successful build. Portage 2.2.8-r1 (default/linux/amd64/13.0/desktop/kde, gcc-4.8.2, glibc-2.18-r1, 3.13.5-gentoo x86_64) ================================================================= System uname: Linux-3.13.5-gentoo-x86_64-Intel-R-_Core-TM-_i5-3230M_CPU_@_2.60GHz-with-gentoo-2.2 KiB Mem: 16318476 total, 12883152 free KiB Swap: 2096576 total, 2096576 free Timestamp of tree: Sat, 08 Mar 2014 07:00:01 +0000 ld GNU ld (GNU Binutils) 2.24 distcc 3.1 x86_64-pc-linux-gnu [disabled] app-shells/bash: 4.2_p45-r1 dev-java/java-config: 2.2.0 dev-lang/python: 2.7.6, 3.3.4 dev-util/cmake: 2.8.12.2 dev-util/pkgconfig: 0.28 sys-apps/baselayout: 2.2 sys-apps/openrc: 0.12.4 sys-apps/sandbox: 2.6-r1 sys-devel/autoconf: 2.13, 2.69 sys-devel/automake: 1.11.6, 1.12.6, 1.14.1 sys-devel/binutils: 2.24-r2 sys-devel/gcc: 4.8.2 sys-devel/gcc-config: 1.8 sys-devel/libtool: 2.4.2 sys-devel/make: 4.0-r1 sys-kernel/linux-headers: 3.13 (virtual/os-headers) sys-libs/glibc: 2.18-r1 Repositories: gentoo java proaudio ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="* -@EULA" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=native -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/themes/oxygen-gtk/gtk-2.0" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-march=native -O2 -pipe" DISTDIR="/usr/portage/distfiles" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://ftp-stud.hs-esslingen.de/pub/Mirrors/gentoo/ http://gentoo.inf.elte.hu/ http://gd.tuwien.ac.at/opsys/linux/gentoo/ " LANG="en_US.UTF-8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j4" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/var/lib/layman/java /var/lib/layman/pro-audio" USE="X a52 aac acl acpi alsa amd64 avx bash-completion berkdb bindist bluetooth branding bzip2 c++0x cairo cdda cdr cli consolekit cracklib crypt cups cxx dbus declarative dri dts dvd dvdr emboss encode exif fam firefox flac fortran gdbm gif gles gles1 gles2 gphoto2 gpm gtk hardened iconv ipv6 java6 jpeg jpeg2k kde kipi lcms ldap libnotify lm_sensors mad mmx mng modules mp3 mp4 mpeg multilib ncurses networkmanager nls nptl ogg opengl openmp pam pango pcre pdf phonon plasma png policykit posix ppds qt3support qt4 readline sdl semantic-desktop session smp spell sse sse2 sse3 sse4_1 ssl ssse3 startup-notification svg tcpd threads tiff truetype udev udisks unicode upower usb vaapi vim-syntax vorbis wifi wxwidgets x264 xcb xcomposite xinerama xml xpm xscreensaver xv xvid xvmc zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="keyboard mouse evdev wacom synaptics joystick" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LIRC_DEVICES="alsa_usb" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" QEMU_SOFTMMU_TARGETS="x86_64 arm" QEMU_USER_TARGETS="x86_64 arm" RUBY_TARGETS="ruby19 ruby20 ruby21" SANE_BACKENDS="plustek" USERLAND="GNU" VIDEO_CARDS="intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, SYNC, USE_PYTHON
Created attachment 372114 [details] Build log
It seems the problem is caused by an API change in the openconnect package. See git commit: http://git.infradead.org/users/dwmw2/openconnect.git/commitdiff/9d660c6c118a9f19acad81af8340d455bf775348
Created attachment 372122 [details, diff] Quick patch to the new API of openconnect This patch is to build kde-misc/networkmanagement-0.9.0.10 against net-misc/openconnect-5.99.
Take a look at how networkmanager handles both the old and new openconnect API in the same source: https://git.gnome.org/browse/network-manager-openconnect/tree/auth-dialog/main.c?h=nm-0-9-8 #if OPENCONNECT_CHECK_VER(3,0) #define NEWGROUP_SUPPORTED 1 #define AUTHGROUP_OPT(form) (void *)(form)->authgroup_opt #define AUTHGROUP_SELECTION(form) (form)->authgroup_selection #define FORMCHOICE(sopt, i) ((sopt)->choices[i]) #define IGNORE_OPT(opt) ((opt)->flags & OC_FORM_OPT_IGNORE) #else #define NEWGROUP_SUPPORTED 0 #define AUTHGROUP_OPT(form) NULL #define AUTHGROUP_SELECTION(form) 0 #define FORMCHOICE(sopt, i) (&(sopt)->choices[i]) #define IGNORE_OPT(opt) 0 #define OC_FORM_RESULT_ERR -1 #define OC_FORM_RESULT_OK 0 #define OC_FORM_RESULT_CANCELLED 1 #define OC_FORM_RESULT_NEWGROUP 2 #endif Probably networkmanagement should introdice something like this FORMCHOICE macro.
networkmanagement is deprecated upstream so there probably won't be much activity there. The sucessor, plasma-nm, has a patch that might be of interest though: http://quickgit.kde.org/?p=plasma-nm.git&a=commit&h=947f56f1cd21a72fa0f88e1c42ac8c19e23864d0
@Lamarque As you are the upstream maintainer, could you provide a patch?
I can port the patch in comment #5 to networkmanagement and release Plasma NM 0.9.0.11 (there are some other commits that are queued for the next release already). I do not have an openconnect server that I can test the patch and finish the OC_FORM_RESULT_NEWGROUP implementation though.
I hit this build failure and move to kde-misc/plasma-nm
(In reply to Lamarque V. Souza from comment #7) > I can port the patch in comment #5 to networkmanagement and release Plasma > NM 0.9.0.11 (there are some other commits that are queued for the next > release already). I do not have an openconnect server that I can test the > patch and finish the OC_FORM_RESULT_NEWGROUP implementation though. @Lamarque Thanks for your fast response, we have stabilized plasma-nm in the meanwhile. Do you think we should just "last rite" networkmanagement as plasma-nm is the successor?
Yes, it makes sense. I already deprecated networkmanagement and will release new versions only on distributions request during the transition to plasma-nm. There has been no new feature in Plasma NM 0.9.0.x series for quite some time, just bugfixing.
(In reply to Lamarque V. Souza from comment #10) > Yes, it makes sense. I already deprecated networkmanagement and will release > new versions only on distributions request during the transition to > plasma-nm. There has been no new feature in Plasma NM 0.9.0.x series for > quite some time, just bugfixing. Why to deprecate networkmanagement? Its interface is much better, imho, and I don't see anything that plasma-nm can do better or that networkmanagement can't do while plasma-nm can.
(In reply to Denis Sokolovsky from comment #11) > Why to deprecate networkmanagement? Its interface is much better, imho, and > I don't see anything that plasma-nm can do better or that networkmanagement > can't do while plasma-nm can. networkmanagement is officially Plasma NM <= 0.9.0.x, plasma-nm is Plasma NM >= 0.9.8.x. They are developed by the same developers and plasma-nm is the evolution of networkmanagement. The source code of plasma-nm is smaller, cleaner and easier to maintain. Those alone are good reasons to deprecate networkmanagement. plasma-nm interface also takes less space on the screen (a constant complaint about networkmanagement), is more touchscreen friendly (that is usefull for Plasma Active) and it indeed supports some features not present in networkmanagement like: . manual wifi scanning. . activate a connection (for example vpn) when another connection is activated (wifi, wired, etc). . supports other connection types, such as wimax, bond, bridge and vlan. plasma-nm also has better integration with Bluedevil, the bluetooth management software for KDE, when creating bluetooth connections. There is no interest from KDE developers in continuing developing networkmanagement, so I strongly advise everybody to move to plasma-nm. I can still make a final release of Plasma NM 0.9.0.x series upon distributions' request. However, there has been no interested in that so far.
(In reply to Lamarque V. Souza from comment #12) > I can still make a final release of Plasma NM 0.9.0.x series upon > distributions' request. However, there has been no interested in that so far. I'd be interested in that. :-)
> I can still make a final release of Plasma NM 0.9.0.x series upon > distributions' request. However, there has been no interested in that so far. Yes, I'm interested too. Plasma-nm does not play well with corporate VPN with certificates, however networkmanagement works fine. Worst case I will create an overlay and keep this package alive there until plasma-nm is fixed.
(In reply to Zoltan Puskas from comment #14) > > I can still make a final release of Plasma NM 0.9.0.x series upon > > distributions' request. However, there has been no interested in that so far. > > Yes, I'm interested too. Plasma-nm does not play well with corporate VPN > with certificates, however networkmanagement works fine. Worst case I will > create an overlay and keep this package alive there until plasma-nm is fixed. Have you reported this issue to bugs.kde.org? If not then please do it, this is a kind of show stopper issue. I will release Plasma NM 0.9.0.11 today then.
(In reply to Lamarque V. Souza from comment #15) > I will release Plasma NM 0.9.0.11 today then. Thank you! I've added it to the tree. *networkmanagement-0.9.0.11 (23 Apr 2014) 23 Apr 2014; Manuel Rüger <mrueg@gentoo.org> +networkmanagement-0.9.0.11.ebuild, networkmanagement-0.9.0.10-r1.ebuild, networkmanagement-0.9.0.10.ebuild: Version bump. Fixes bug #503898. Restrict to <net-misc/openconnect-5.99 on earlier versions.
