Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 503414 - www-servers/nginx-1.5.13 version bump
Summary: www-servers/nginx-1.5.13 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tiziano Müller (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-04 14:38 UTC by Tomáš Mózes
Modified: 2014-04-15 06:21 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
upstream-check-1.5.11.patch (upstream-check-1.5.11.patch,6.64 KB, patch)
2014-03-06 22:20 UTC, Johan Bergström
Details | Diff
nginx-1.5.11.ebuild (nginx-1.5.11.ebuild,22.06 KB, text/plain)
2014-03-06 22:22 UTC, Johan Bergström
Details
nginx-1.4.6.ebuild (nginx-1.4.6.ebuild,23.37 KB, text/plain)
2014-03-06 23:22 UTC, Johan Bergström
Details
nginx-1.5.11.ebuild (nginx-1.5.11.ebuild,23.46 KB, text/plain)
2014-03-09 23:11 UTC, Johan Bergström
Details
nginx-1.5.11.ebuild (nginx-1.5.11.ebuild,23.45 KB, text/plain)
2014-03-13 03:17 UTC, Johan Bergström
Details
nginx-1.5.11.ebuild (nginx-1.5.11.ebuild,23.44 KB, text/plain)
2014-03-21 06:02 UTC, Johan Bergström
Details
nginx-1.5.12.ebuild (nginx-1.5.12.ebuild,23.44 KB, text/plain)
2014-03-21 06:04 UTC, Johan Bergström
Details
nginx-1.5.13.ebuild (nginx-1.5.13.ebuild,23.55 KB, text/plain)
2014-04-10 00:22 UTC, Johan Bergström
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tomáš Mózes 2014-03-04 14:38:44 UTC
Changes with nginx 1.4.5                                         11 Feb 2014

    *) Bugfix: the $ssl_session_id variable contained full session
       serialized instead of just a session id.
       Thanks to Ivan Ristić.

    *) Bugfix: client connections might be immediately closed if deferred
       accept was used; the bug had appeared in 1.3.15.

    *) Bugfix: alerts "zero size buf in output" might appear in logs while
       proxying; the bug had appeared in 1.3.9.

    *) Bugfix: a segmentation fault might occur in a worker process if the
       ngx_http_spdy_module was used.

    *) Bugfix: proxied WebSocket connections might hang right after
       handshake if the select, poll, or /dev/poll methods were used.

    *) Bugfix: a timeout might occur while reading client request body in an
       SSL connection using chunked transfer encoding.

    *) Bugfix: memory leak in nginx/Windows.
Comment 1 Manuel Rüger (RETIRED) gentoo-dev 2014-03-05 19:48:12 UTC
Changes with nginx 1.4.6                                         04 Mar 2014

    *) Bugfix: the "client_max_body_size" directive might not work when
       reading a request body using chunked transfer encoding; the bug had
       appeared in 1.3.9.
       Thanks to Lucas Molas.

    *) Bugfix: a segmentation fault might occur in a worker process when
       proxying WebSocket connections.
Comment 2 Johan Bergström 2014-03-06 01:37:04 UTC
See bug 503528. I will run through the ebuilds today and see if we have any modules needing updates.
Comment 3 Johan Bergström 2014-03-06 02:04:55 UTC
The patch we carry for http_upstream_check added for 1.5.10 now breaks (testing 1.5.11). I'm not sure how long we should carry an out-of-date patch since upstream hasn't been active for ~6 months.
Comment 4 Agostino Sarubbo gentoo-dev 2014-03-06 10:36:58 UTC
> Summary: www-servers/nginx-1.4.6 version bump → www-servers/nginx-1.{4.6,5.11} version bump

This syntax make harder a search and does not avoid the duplicate.
Comment 5 Johan Bergström 2014-03-06 21:33:40 UTC
@Agostino: Good points. I basically did it because "it's been done before", which in itself is a pretty bad argument. I'll have this in mind moving forward.
Comment 6 Johan Bergström 2014-03-06 22:20:33 UTC
Created attachment 371912 [details, diff]
upstream-check-1.5.11.patch

Re-baked upstream_check patch. Work by Tiziano Müller.
Comment 7 Johan Bergström 2014-03-06 22:22:31 UTC
Created attachment 371914 [details]
nginx-1.5.11.ebuild

Verbump to 1.5.11. For changes and discussion, see https://gist.github.com/jbergstroem/9384885 (not really relevant which is why I left it out of bugzilla)
Comment 8 Johan Bergström 2014-03-06 23:22:39 UTC
Created attachment 371922 [details]
nginx-1.4.6.ebuild

See comments here: https://gist.github.com/jbergstroem/9401337

Please test this and 1.5.11.
Comment 9 Johan Bergström 2014-03-09 23:11:26 UTC
Created attachment 372234 [details]
nginx-1.5.11.ebuild

Updated ebuild. Adds the sticky upstream module (suggestion on better use flag name?) -- https://bitbucket.org/nginx-goodies/nginx-sticky-module-ng/.

There's currently a floating patch that allows the upstream_check module use the sticky module which sounds like a good combination to me. Upstream is looking into it: https://bitbucket.org/nginx-goodies/nginx-sticky-module-ng/issue/3/patch-to-allow

I've also added the ajp module, but it fails to build against 1.5.11. Upstream bug here: https://github.com/yaoweibin/nginx_ajp_module/issues/22
Comment 10 Johan Bergström 2014-03-13 03:17:30 UTC
Created attachment 372538 [details]
nginx-1.5.11.ebuild

Updated ebuild for nginx 1.5.11. This fixes build issues with the ajp module (newer version upstream). Please test/commit to tree.
Comment 11 Manuel Rüger (RETIRED) gentoo-dev 2014-03-18 18:07:01 UTC
SPDY heap buffer overflow
Severity: major
CVE-2014-0133
Not vulnerable: 1.5.12+, 1.4.7+
Vulnerable: 1.3.15-1.5.11

http://nginx.org/en/security_advisories.html?1.5.12
Comment 12 Johan Bergström 2014-03-18 20:55:20 UTC
@Manuel: Thanks for being quick re the bump. We have a slightly different procedure when it comes to security bugs. I just created this: bug 505018.
Comment 13 Johan Bergström 2014-03-18 20:57:55 UTC
Probably not the right place to discuss, but I feel that it is outside of the security scope of nginx -- Tiziano, should we rather do 1.4.4-r1 with the patch since 1.4.7 will contain a fair amount of changes? That way we can stable -r1 at once and introduce 1.4.7/1.5.12 with above ebuilds.
Comment 14 Johan Bergström 2014-03-21 06:02:34 UTC
Created attachment 373164 [details]
nginx-1.5.11.ebuild

Replaced the nginx 1.5.11 ebuild; updated 3rd party modules.
Comment 15 Johan Bergström 2014-03-21 06:04:15 UTC
Created attachment 373166 [details]
nginx-1.5.12.ebuild

While at it, rename to 1.5.12. No other changes.
Comment 16 Johan Bergström 2014-03-23 00:46:04 UTC
Oh yeah, for 1.5.12 you need to rename the upstream patch.
Comment 17 Tiziano Müller (RETIRED) gentoo-dev 2014-03-28 14:15:12 UTC
nginx-1.4.7 is now in the tree, 1.5.12 follows...
Comment 18 Manuel Rüger (RETIRED) gentoo-dev 2014-04-09 14:15:11 UTC
(In reply to Tiziano Müller from comment #17)
> nginx-1.4.7 is now in the tree, 1.5.12 follows...

ping for 1.5.12 :)
Comment 19 Manuel Rüger (RETIRED) gentoo-dev 2014-04-09 14:15:40 UTC
Changes with nginx 1.5.13                                        08 Apr 2014

    *) Change: improved hash table handling; the default values of the
       "variables_hash_max_size" and "types_hash_bucket_size" were changed
       to 1024 and 64 respectively.

    *) Feature: the ngx_http_mp4_module now supports the "end" argument.

    *) Feature: byte ranges support in the ngx_http_mp4_module and while
       saving responses to cache.

    *) Bugfix: alerts "ngx_slab_alloc() failed: no memory" no longer logged
       when using shared memory in the "ssl_session_cache" directive and in
       the ngx_http_limit_req_module.

    *) Bugfix: the "underscores_in_headers" directive did not allow
       underscore as a first character of a header.
       Thanks to Piotr Sikora.

    *) Bugfix: cache manager might hog CPU on exit in nginx/Windows.

    *) Bugfix: nginx/Windows terminated abnormally if the
       "ssl_session_cache" directive was used with the "shared" parameter.

    *) Bugfix: in the ngx_http_spdy_module.
Comment 20 Johan Bergström 2014-04-10 00:22:13 UTC
Created attachment 374646 [details]
nginx-1.5.13.ebuild

Attaching updated ebuild for nginx-1.5.13. Few module updates and fixes for bug 506804, bug 506690. As with previous, rename upstream-check patch since we use ${PN}.

We should backport the bug fixes for 1.4.x as well (libcap dep and move modsecurity configure). Perhaps with next version bump?
Comment 21 Tiziano Müller (RETIRED) gentoo-dev 2014-04-15 06:21:48 UTC
Done. thanks for all your work, Johan!