Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 502178 - =app-office/gnumeric-1.12.11 - crypt-md4.c:145:3: error: implicit declaration of function 'GSF_LE_GET_GUINT32' [-Werror=implicit-function-declaration]
Summary: =app-office/gnumeric-1.12.11 - crypt-md4.c:145:3: error: implicit declaration...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: GNOME Office (OBSOLETE)
URL: https://bugzilla.gnome.org/show_bug.c...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-22 22:42 UTC by David W Noon
Modified: 2014-03-01 07:45 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
app-office:gnumeric-1.12.11:20140222-194744.log.gz (app-office:gnumeric-1.12.11:20140222-194744.log.gz,23.78 KB, application/gzip)
2014-02-22 22:44 UTC, David W Noon
Details
emerge --info (emerge_info.txt,6.26 KB, text/plain)
2014-02-22 22:45 UTC, David W Noon
Details
Patch to crypt-md4.c (crypt-md4.patch,246 bytes, patch)
2014-02-22 22:48 UTC, David W Noon
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David W Noon 2014-02-22 22:42:53 UTC
The following error messages cause the compilation to fail:

crypt-md4.c: In function 'copy64':
crypt-md4.c:145:3: error: implicit declaration of function 'GSF_LE_GET_GUINT32' [-Werror=implicit-function-declaration]
crypt-md4.c:145:3: error: nested extern declaration of 'GSF_LE_GET_GUINT32' [-Werror=nested-externs]

Build log and emerge --info will be uploaded in a few minutes.
Comment 1 David W Noon 2014-02-22 22:44:45 UTC
Created attachment 371092 [details]
app-office:gnumeric-1.12.11:20140222-194744.log.gz
Comment 2 David W Noon 2014-02-22 22:45:25 UTC
Created attachment 371094 [details]
emerge --info
Comment 3 David W Noon 2014-02-22 22:48:56 UTC
Created attachment 371096 [details, diff]
Patch to crypt-md4.c

Added to /etc/portage/patches/app-office/gnumeric-1.12.11

Also added the following lines to the ebuild:

src_prepare() {
        epatch_user
}

After running ebuild ... manifest, the ebuild worked.
Comment 4 Pacho Ramos gentoo-dev 2014-02-27 21:07:17 UTC
It shouldn't pass -Werror at all, looks like --enable-compile-warnings option is not working for gnumeric
Comment 5 David W Noon 2014-02-27 21:28:50 UTC
(In reply to Pacho Ramos from comment #4)
> It shouldn't pass -Werror at all, looks like --enable-compile-warnings
> option is not working for gnumeric

This particular problem is in the source code crypt-md4.c, as there is a #include directive missing.  That is watch the patch corrects.
Comment 6 M Welinder 2014-03-01 00:27:13 UTC
Gnumeric developer here.

Just for the record, the reasoning behind the use of
-Werror=missing-prototypes was discussed here:
https://bugzilla.gnome.org/show_bug.cgi?id=725349

Patch is correct and has been applied in Gnumeric's git repository.
Comment 7 Pacho Ramos gentoo-dev 2014-03-01 07:45:34 UTC
+  01 Mar 2014; Pacho Ramos <pacho@gentoo.org>
+  +files/gnumeric-1.12.11-missing-header.patch, -gnumeric-1.12.10.ebuild,
+  gnumeric-1.12.11.ebuild:
+  Add missing header (#502178 by David W Noon and approved by M Welinder), drop
+  old.
+