Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 499788 - gnome-base/gnome-control-center: drop dependency on smbclient use-flag for >=net-fs/samba-4.0.0
Summary: gnome-base/gnome-control-center: drop dependency on smbclient use-flag for >=...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2014-01-30 15:04 UTC by Torsten Kurbad
Modified: 2014-02-03 17:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
gnome-control-center-3.10.2.ebuild_samba-compatibility.patch (gnome-control-center-3.10.2.ebuild_samba-compatibility.patch,499 bytes, patch)
2014-01-30 15:07 UTC, Torsten Kurbad 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Kurbad 2014-01-30 15:04:52 UTC 
With >=net-fs/samba-4.1.0 being released and in portage, some minor issues still need to be addressed.

One of them being to identify and adapt packages depending on net-fs/samba[smbclient]. This use flag has been dropped for >=net-fs/samba-4.0.0, since the libsmbclient stuff is always installed here along with the client tools.

Find attached a patch for =gnome-base/gnome-control-center-3.10.2 that resolves the issue.

Thanks,
Torsten

Reproducible: Always
Comment 1 Torsten Kurbad 2014-01-30 15:07:10 UTC 
Created attachment 369124 [details, diff]
gnome-control-center-3.10.2.ebuild_samba-compatibility.patch
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2014-01-31 10:07:02 UTC 
samba is not optional, we need to patch to code to make it so.
Comment 3 Torsten Kurbad 2014-01-31 19:42:11 UTC 
(In reply to Gilles Dartiguelongue from comment #2)
> samba is not optional, we need to patch to code to make it so.

Why would you have to patch the code? I never wanted samba to be optional.
My patch concerns the compatibility of the EBUILD when building against samba 4.x. Building against samba 4.x then just works out of the box.
Comment 4 Torsten Kurbad 2014-01-31 19:45:15 UTC 
Btw., the same problem has been solved for other packages in bugs #452048 and #452050.
Comment 5 Pacho Ramos gentoo-dev 2014-02-01 08:59:07 UTC 
+  01 Feb 2014; Pacho Ramos <pacho@gentoo.org>
+  gnome-control-center-3.10.2.ebuild, gnome-control-center-3.8.6.ebuild:
+  Fix dependency on samba client for samba-4 (#499788 by Torsten Kurbad)
+
Comment 6 Gilles Dartiguelongue (RETIRED) gentoo-dev 2014-02-03 14:37:11 UTC 
Looks like I completely missed the point then, sorry.
Comment 7 Torsten Kurbad 2014-02-03 17:08:50 UTC 
(In reply to Gilles Dartiguelongue from comment #6)
> Looks like I completely missed the point then, sorry.

Such things happen. Don't worry! :-)