Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 499294 - x11-drivers/ati-drivers - patch to powermode script contains bug
Summary: x11-drivers/ati-drivers - patch to powermode script contains bug
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-26 02:19 UTC by Zdeněk Žamberský
Modified: 2014-02-16 20:14 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zdeněk Žamberský 2014-01-26 02:19:59 UTC
The patch named "ati-powermode-opt-path-3.patch" which makes few changes to ati-powermode.sh (script for acpid to make power mode changes on laptops) contains bug multiple times.

For example it changes:
-su $user -c '/usr/bin/aticonfig --pplib-cmd="get version"' | grep PPLIB
+su $user -c '$aticonfig --pplib-cmd="get version"' | grep PPLIB

but $aticonfig in ' ' is not evaluated and script doesn't work. One of possible fixes could be change it to:

+su $user -c "$aticonfig --pplib-cmd='get version'" | grep PPLIB

Patch contain similar bug three times.

Reproducible: Always

Steps to Reproduce:
On a laptop as root (with ati-drivers and acpid installed) run:
1. /etc/init.d/acpid stop
2. acpid -d
then plug/unplug power-supply or open/close lid
Actual Results:  
some error messages (from script) occur

Expected Results:  
no error messages should occur
Comment 1 emil karlson 2014-01-31 20:11:39 UTC
Pushed to x11 overlay, did not test, as I have no proper laptop. Thanks for the report and the fix.
Comment 2 Zdeněk Žamberský 2014-02-15 16:51:42 UTC
I finally tested out version from x11 overlay and works as expected (no more errors from the script, only messages that PPLIB execution was successful). Thanx and sorry for a long delay.
Comment 3 Chí-Thanh Christopher Nguyễn gentoo-dev 2014-02-16 20:14:22 UTC
Fixed in CVS.