497620 – >=sys-devel/llvm-3.3-r2 does not install clang-format anymore

Bug 497620 - >=sys-devel/llvm-3.3-r2 does not install clang-format anymore

Summary: >=sys-devel/llvm-3.3-r2 does not install clang-format anymore

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] Development (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Bernard Cafarelli

URL:
Whiteboard:
Keywords:	REGRESSION

Depends on:
Blocks:

Reported:	2014-01-09 10:30 UTC by Oliver Freyermuth
Modified:	2014-06-14 14:04 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Oliver Freyermuth 2014-01-09 10:30:49 UTC

One of the new features of the clang-3.4 distribution is the tool clang-format:
http://llvm.org/releases/3.4/tools/clang/docs/ReleaseNotes.html#clang-format

It resides in the tools-subdirectory of the clang-tree and seems to be enabled by default in the CMakeLists-flags. In the Gentoo-ebuild, only the static-analyzer macros may be extracted when the corresponding USE-flag is set, but all other clang-tools in that directory appear to be silently ignored (unless I am missing something). 

It would be nice to also have an USE-flag to enable installation of all tools (I'd guess they will grow in the future, so adding separate flags for each will probably bloat). 

Reproducible: Always

Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev

2014-01-09 10:36:31 UTC

Duplicate of bug #497428 maybe?

Comment 2 Oliver Freyermuth 2014-01-09 10:46:22 UTC

(In reply to Lars Wendler (Polynomial-C) from comment #1)
> Duplicate of bug #497428 maybe?
#497428 is dealing with the (separately distributed) clang-extra-tools (such as clang-modernize ) which are by now installed by sys-devel/llvm-3.4 . 

The clang-core-tools (such as clang-format ) distributed with the main clang package are not installed yet (apart from the static analyzer). 

I tried to differentiate this bug from #497428 via the "Non-extra" in the bug-title, but apparently I failed miserably ;-).

Comment 3 Michał Górny archtester

2014-01-09 18:19:00 UTC

It seems that I have mistakenly broken their install in -3.3-r2. Will prepare a fix before 3.4 gets unmasked.

Comment 4 Michał Górny archtester

2014-01-10 17:30:59 UTC

+  10 Jan 2014; Michał Górny <mgorny@gentoo.org> llvm-3.4.ebuild,
+  llvm-9999.ebuild:
+  Restore building clang-check and clang-format, bug #497620.

But I've tested -9999 only :).

Not sure if there's a point backporting it to 3.3-r3. We'd have to revbump it to make this effective, and we can instead unmask 3.4 soon enough to save users one more rebuild.

Comment 5 Oliver Freyermuth 2014-01-11 03:56:34 UTC

(In reply to Michał Górny from comment #4)
> +  10 Jan 2014; Michał Górny <mgorny@gentoo.org> llvm-3.4.ebuild,
> +  llvm-9999.ebuild:
> +  Restore building clang-check and clang-format, bug #497620.
> 
> But I've tested -9999 only :).
I just rebuilt llvm-3.4 and (as expected) your fix also works, thanks! 

I don't think there is really a point backporting this to 3.3-r3 but rather save the unnecessary rebuild and instead unmask 3.4 soon: I guess most users aren't even aware of the core tools / would not want to rebuild full llvm just to get them now.

Comment 6 Nikoli 2014-03-08 15:03:29 UTC

Also /usr/bin/clang-check is not installed after updating from llvm-3.3-r1 to llvm-3.3-r3.

Comment 7 Michał Górny archtester

2014-06-14 14:04:30 UTC

(assuming this is fixed in 3.4.1-r1)