Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 497594 - >net-misc/tigervnc-1.2 USE=-internal-fltk needs x11-libs/fltk development snapshot
Summary: >net-misc/tigervnc-1.2 USE=-internal-fltk needs x11-libs/fltk development sna...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Desktop Misc. Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-09 00:55 UTC by Paul B. Henson
Modified: 2016-05-24 08:38 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul B. Henson 2014-01-09 00:55:37 UTC
For all the features to work correctly in tigervnc, one needs a patched version of fltk. You can see the details in the BUILDING.txt file in the tigervnc tarball, here's a summary:

# Export dead key information from FLTK to the apps
# http://www.fltk.org/str.php?L2599
fltk-1_v4.3.x-keyboard-x11.patch
fltk-1_v4.3.x-keyboard-win32.patch
fltk-1_v6.3.x-keyboard-osx.patch

# Notify applications of changes to the clipboard
# http://www.fltk.org/str.php?L2636
fltk-1.3.x-clipboard.patch
fltk-1_v5.3.x-clipboard-x11.patch
fltk-1_v3.3.x-clipboard-win32-fix.patch
fltk-1_v2.3.x-clipboard-win32.patch
fltk-1_v2.3.x-clipboard-osx.patch

# Ability to convert a Fl_Pixmap to a Fl_RGB_Image
# http://www.fltk.org/str.php?L2659
pixmap_v2.patch

# Support for custom cursors
# http://www.fltk.org/str.php?L2660
fltk-1_v5.3.x-cursor.patch

# Improve modality interaction with WM
# http://www.fltk.org/str.php?L2802
fltk-1_v2.3.0-modal.patch

# Window icons
# http://www.fltk.org/str.php?L2816
fltk-1_v3.3.0-icons.patch

# Multihead
# http://fltk.org/str.php?L2860
fltk-1.3.x-screen_num.patch
fltk-1_v3.3.x-multihead.patch

I haven't fully analyzed all of these, so I don't know if it would be better to just apply them all uncondionally, or have a tigervnc use flag or something to control applying them? But it would be nice to get an ebuild that incorporates them, I'm particularly missing multihead right now :(.
Comment 1 Joe Jezak (RETIRED) gentoo-dev 2014-01-20 16:43:46 UTC
* These patches are already upstream, or appear to be scheduled to be appplied and shouldn't be controversial:

http://www.fltk.org/str.php?L2636
fltk-1.3.x-clipboard.patch
fltk-1_v5.3.x-clipboard-x11.patch
fltk-1_v3.3.x-clipboard-win32-fix.patch
fltk-1_v2.3.x-clipboard-win32.patch
fltk-1_v2.3.x-clipboard-osx.patch

http://www.fltk.org/str.php?L2659
pixmap_v2.patch

http://fltk.org/str.php?L2860
fltk-1.3.x-screen_num.patch

* These patches do not change the ABI of fltk:

http://www.fltk.org/str.php?L2660
fltk-1_v5.3.x-cursor.patch (Depends on pixmap_v2.patch)

http://www.fltk.org/str.php?L2816
fltk-1_v3.3.0-icons.patch

* These patches should be looked at a bit first, or wait for upstream:
http://www.fltk.org/str.php?L2599
fltk-1_v4.3.x-keyboard-x11.patch
fltk-1_v4.3.x-keyboard-win32.patch
fltk-1_v6.3.x-keyboard-osx.patch

http://fltk.org/str.php?L2860
fltk-1_v3.3.x-multihead.patch

Hope this helps!
Comment 2 Raúl Porcel (RETIRED) gentoo-dev 2014-02-01 18:20:54 UTC
The patches need to be applied on fltk, not in tigervnc, so reassigning to desktop-misc in case they are interested in applying the patches.
Comment 3 Julian Ospald 2014-02-01 18:57:53 UTC
where are they applied? Maybe it would make more sense to ship a snapshot.
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2014-02-02 11:17:39 UTC
=x11-libs/fltk-1.3.2_p10088 is in the tree. It isn't supposed to go stable, I guess.

It still isn't obvious how this helps tigervnc, except that it was apparently based on fltk snapshots (hence USE=internal-fltk?).
Comment 5 Raúl Porcel (RETIRED) gentoo-dev 2014-02-08 13:38:08 UTC
(In reply to Jeroen Roovers from comment #4)
> It still isn't obvious how this helps tigervnc, except that it was
> apparently based on fltk snapshots (hence USE=internal-fltk?).

Exactly, however in the latest version(1.3.0) they stopped shipping an internal fltk.
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2014-02-08 13:43:11 UTC
(In reply to Raúl Porcel from comment #5)
> (In reply to Jeroen Roovers from comment #4)
> > It still isn't obvious how this helps tigervnc, except that it was
> > apparently based on fltk snapshots (hence USE=internal-fltk?).
> 
> Exactly, however in the latest version(1.3.0) they stopped shipping an
> internal fltk.

Ah, so for 1.3.0 you could set a minimal fltk version?
Comment 7 Raúl Porcel (RETIRED) gentoo-dev 2014-02-09 16:01:57 UTC
(In reply to Jeroen Roovers from comment #6)
> (In reply to Raúl Porcel from comment #5)
> > (In reply to Jeroen Roovers from comment #4)
> > > It still isn't obvious how this helps tigervnc, except that it was
> > > apparently based on fltk snapshots (hence USE=internal-fltk?).
> > 
> > Exactly, however in the latest version(1.3.0) they stopped shipping an
> > internal fltk.
> 
> Ah, so for 1.3.0 you could set a minimal fltk version?

tigervnc-1.3.0-r1 is supposed to go stable for bug 500372, this would mean fltk stable as well...
Comment 8 Paul B. Henson 2015-12-06 01:59:54 UTC
It looks like most if not all of these patches are in the recently stabilized fltk 1.3.3? So maybe it's time to just close this out as resolved.
Comment 9 Pacho Ramos gentoo-dev 2016-05-24 08:38:09 UTC
This was fixed long time ago