Bug 49748 – usb.agent write all ENV vars onto stdout. (Coldplugging)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Francesco Ferrara 2004-05-02 12:39:35 UTC]

usb.agent scan line by line all files *.usermap doing a set $line on it.
but if you write a *.usermap with an empty line in it, usb.agent write all ENV data onto stdout (also in the boot process).
I have resolved with a simple...
--- usb.agent   2004-05-02 21:28:42.698807968 +0200
+++ usb.agent.old       2004-05-02 21:26:29.257094192 +0200
@@ -251,5 +251,4 @@
        case "$line" in
        \#*) continue ;;
-       "") continue ;;
        esac


Reproducible: Always
Steps to Reproduce:
1. insert an empty line onto one of your *.usermap files
2. run /etc/hotplug/usb.rc start
3. look at the ENV variables onto stdout



Expected Results:  
Nothing printed onto stdout

[Comment 1 Francesco Ferrara 2004-05-02 12:54:28 UTC]

Naturally the patch is this:

--- usb.agent.old       2004-05-02 21:26:29.000000000 +0200
+++ usb.agent   2004-05-02 21:28:42.000000000 +0200
@@ -251,4 +251,5 @@
        case "$line" in
        \#*) continue ;;
+       "") continue ;;
        esac

:)

[Comment 2 Greg Kroah-Hartman (RETIRED) 2004-05-03 20:55:10 UTC]

Can you put the patch in an attachment so I can apply it?

[Comment 3 Francesco Ferrara 2004-05-04 02:03:58 UTC]

What parameters do you want (for diff)? 
(AKA what are Gentoo .patch files generated?)

[Comment 4 Greg Kroah-Hartman (RETIRED) 2004-05-04 07:58:36 UTC]

So that I can apply it with a 'patch -p1' would be best.

[Comment 5 Francesco Ferrara 2004-05-04 08:27:36 UTC]

Created attachment 30713 [details, diff]
Correct an empty line in usb.usermap files

[Comment 6 Greg Kroah-Hartman (RETIRED) 2004-09-20 15:52:06 UTC]

Thanks, this is now fixed upstream and will show up in the next release (today or tomorrow.)