Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 497352 - dev-libs/libgit2 - add threads USE flag
Summary: dev-libs/libgit2 - add threads USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tim Harder
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 868336 497358
  Show dependency tree
 
Reported: 2014-01-07 03:44 UTC by Konstantin (elxa)
Modified: 2022-12-14 11:11 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
add "threads" use to dev-libs/libgit2 (libgit2-threads.patch,621 bytes, patch)
2014-01-07 03:46 UTC, Konstantin (elxa)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin (elxa) 2014-01-07 03:44:56 UTC
Excerpt from

https://github.com/libgit2/libgit2/blob/development/CMakeLists.txt

OPTION( THREADSAFE "Build libgit2 as threadsafe" OFF )

The attached patch introduces a use flag "threads" to the ebuild, that builds libgit2 with support for threading.

The latter is required by the just release gitg-0.3.1, a gnome version of GitX, which is a git gui for mac os x.

Reproducible: Always

Steps to Reproduce:
Trying to run the mentioned gitg-0.3.1 after building it results in:

** (gitg:18980): ERROR **: gitg-init.vala:27: libgit2 must be built with threading support in order to run gitg
Trace/breakpoint trap

The lack of threading support in libgit2 and this change in gitg are the reason for that:

https://mail.gnome.org/archives/commits-list/2013-March/msg17910.html
Actual Results:  
libgit2 does not support use "threads"

Expected Results:  
libgit2 should support use "threads".
Comment 1 Konstantin (elxa) 2014-01-07 03:46:52 UTC
Created attachment 367254 [details, diff]
add "threads" use to dev-libs/libgit2

Introduce use flag threads to build libgit2 with threading support.
Comment 2 Konstantin (elxa) 2014-01-07 07:04:18 UTC
I can confirm that with this patch applied and after (re)building dev-libs/libgit2 with USE="threads", dev-vcs/gitg-0.3.1 works as expected.
Comment 3 Justin Lecher (RETIRED) gentoo-dev 2014-02-08 13:37:01 UTC
+*libgit2-0.20.0-r1 (08 Feb 2014)
+
+  08 Feb 2014; Justin Lecher <jlec@gentoo.org> +libgit2-0.20.0-r1.ebuild:
+  Add threads USE flag, #497352
+