Geant 4.10.0 has some problem in the SetNavigatorForTracking method as illustrated in this upstream bug report (specifically also causing issues with sci-physics/geant-vmc ): http://bugzilla-geant4.kek.jp/show_bug.cgi?id=1537 To that bug report, changed (fixed) files are attached and have been accepted by upstream. Because I guess a new release is not imminent in the next weeks it would be nice to have this patch also included into =sci-physics/geant-4.10.00 in Gentoo already. For convenience, I have created a normal .patch-file from those changed files against the vanilla Geant 4.10.0 tarball, as sadly the Geant-repositories are non-public (and I am not in their collaboration for private access). Reproducible: Always
Created attachment 366692 [details, diff] Patch for SetNavigatorForTracking method (credits Ivana Hrivnacova) Created from the changed files attached to: http://bugzilla-geant4.kek.jp/show_bug.cgi?id=1537
Hey, Oliver. Happy new year! Thanks for the patch. It feels not cool to comment out the code block in Lines 59-64 and Lines 70-75, though.
Hey Benda, a happy new year to you, too! I know, as the method is completely reimplemented in the .cc file (including comments), one could of course also completely delete those lines. The block which is commented out contains only documentation-comments (describing the method) and actually only a single line of code (as is also visible in the .patch-file), all of which is replicated by the patch in the .cc file. As upstream's repo is private I sadly cannot see which exact route they have taken (inlining/implementation in header does not work anymore as is described in the upstream bug report). My best guess is they removed the lines in the header file completely. I could of course also recreate the patch with those lines completely removed, would that be nicer?
Hi, Oliver, Thanks. I just throw some random comments to see if you really care about this bug, otherwise I'll wait for the next release. As a temporary bug fix, the not-so-good code style is okay. It's going to disappear anyway. Committed. You are always welcome for more patches. And thanks again! + 06 Jan 2014; Benda Xu <heroxbd@gentoo.org> + +files/geant-4.10.0-TrackingNavigator.patch, geant-4.10.00.ebuild: + backport upstream SetNavigatorForTracking inline function fix, credits Oliver + Freyermuth for reporting bug 496678
