Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 496042 - media-gfx/mandelbulber should install a desktop file
Summary: media-gfx/mandelbulber should install a desktop file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2013-12-26 02:29 UTC by Horea Christian
Modified: 2014-02-08 07:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch tested on 2 of my machines. (file_496042.txt,1.23 KB, text/plain)
2013-12-26 02:29 UTC, Horea Christian
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Horea Christian 2013-12-26 02:29:03 UTC
The media-gfx/mandelbulber upstream package (see next attachment) provides a sane .desktop file. The ebuild currently does not make use of it.

Reproducible: Always
Comment 1 Horea Christian 2013-12-26 02:29:49 UTC
Created attachment 366210 [details]
Patch tested on 2 of my machines.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2013-12-26 15:13:35 UTC
Comment on attachment 366210 [details]
Patch tested on 2 of my machines.

--- mandelbulber-1.12.1.ebuild  2013-04-11 16:13:29.164812017 +0200
+++ -   2013-12-26 16:13:08.882883584 +0100
@@ -17,31 +17,32 @@
 IUSE=""
 RDEPEND="x11-libs/gtk+:2
-       >=media-libs/libsndfile-1
-       >=media-libs/libpng-1.4:0=
-       virtual/jpeg"
+        >=media-libs/libsndfile-1
+        >=media-libs/libpng-1.4:0=
+        virtual/jpeg"
 DEPEND="${RDEPEND}
-       virtual/pkgconfig"
+        virtual/pkgconfig"
 S=${WORKDIR}/${MY_P}
 src_prepare() {
-       epatch \
-               "${FILESDIR}"/${PN}-1.11-qa.patch \
-               "${FILESDIR}"/${P}-memcpy_and_memset.patch
+        epatch \
+                "${FILESDIR}"/${PN}-1.11-qa.patch \
+                "${FILESDIR}"/${P}-memcpy_and_memset.patch
 }
 src_compile() {
-       emake CXX="$(tc-getCXX)" -C makefiles all
+        emake CXX="$(tc-getCXX)" -C makefiles all
 }
 src_install() {
-       dobin makefiles/${PN}
-       dodoc README NEWS
-       insinto /usr/share/${PN}
-       doins -r usr/share/*
+        dobin makefiles/${PN}
+        dodoc README NEWS
+        insinto /usr/share/${PN}
+        doins -r usr/share/*
+        domenu ${PN}.desktop
 }
 pkg_postinst() {
-       elog "Before you run ${PN} please copy /usr/share/${PN}/* to \${HOME}/.${PN}"
-}
+        elog "Before you run ${PN} please copy /usr/share/${PN}/* to \${HOME}/.${PN}"
+}
\ No newline at end of file
Comment 3 Tim Harder gentoo-dev 2014-02-08 07:21:18 UTC
Fixed in 1.21.1.