Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 495168 - =sys-auth/polkit-0.112-r1: should RDEPEND on =dev-lang/spidermonkey-1.8.5*[-debug] for mips
Summary: =sys-auth/polkit-0.112-r1: should RDEPEND on =dev-lang/spidermonkey-1.8.5*[-d...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Nirbheek Chauhan (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-23 22:56 UTC by Anthony Basile
Modified: 2013-12-24 19:02 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Basile gentoo-dev 2013-12-23 22:56:53 UTC
mips is in the same situation as ia64 wrt to spidermonkey 17, see bug #491294.  Basically MacroAssembler is not supported on mips.

I've already masked >=dev-lang/spidermonkey-1.8.6 on mips.  ia64 should problaby do the same there instead of the ugly RDEPEND line

  !ia64? ( dev-lang/spidermonkey:17[-debug] )

What I do need is the following added to polkit-0.112-r1.

--- polkit-0.112-r1.ebuild	2013-09-19 17:08:30.000000000 +0000
+++ polkit-0.112-r2.ebuild	2013-12-23 22:38:05.268096152 +0000
@@ -15,6 +15,7 @@
 IUSE="examples gtk +introspection kde nls pam selinux systemd"
 
 RDEPEND="ia64? ( =dev-lang/spidermonkey-1.8.5*[-debug] )
+	mips? ( =dev-lang/spidermonkey-1.8.5*[-debug] )
 	!ia64? ( dev-lang/spidermonkey:17[-debug] )
 	>=dev-libs/glib-2.32
 	>=dev-libs/expat-2:=
@@ -68,6 +69,7 @@
 		--disable-examples \
 		$(use_enable nls) \
 		$(usex ia64 --with-mozjs=mozjs185 --with-mozjs=mozjs-17.0) \
+		$(usex mips --with-mozjs=mozjs185 --with-mozjs=mozjs-17.0) \
 		"$(systemd_with_unitdir)" \
 		--with-authfw=$(usex pam pam shadow) \
 		$(use pam && echo --with-pam-module-dir="$(getpam_mod_dir)") \




Reproducible: Always
Comment 1 Anthony Basile gentoo-dev 2013-12-23 23:01:40 UTC
I'm cc-ing ia64 team to alert them that they should remove the REDEPEND

   !ia64? ( dev-lang/spidermonkey:17[-debug] )

and add 

    >=dev-lang/spidermonkey-1.8.6

to

    /usr/portage/profiles/arch/ia64/package.mask


@freedesktop team, can I have your blessing to commit --- its the last bug I need fixed so I can update the yeeloong images.
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2013-12-23 23:49:54 UTC
(In reply to Anthony Basile from comment #1)
> I'm cc-ing ia64 team to alert them that they should remove the REDEPEND
> 
>    !ia64? ( dev-lang/spidermonkey:17[-debug] )
> 
> and add 
> 
>     >=dev-lang/spidermonkey-1.8.6
> 
> to
> 
>     /usr/portage/profiles/arch/ia64/package.mask
> 
> 
> @freedesktop team, can I have your blessing to commit --- its the last bug I
> need fixed so I can update the yeeloong images.

doesn't look good.

the ebuild needs to have the control over which version gets pulled in, as it's later used to detemine which pax-mark flags 'm' or 'mr' gets set at the end of src_compile()

Comment #0 however looks okay. feel free to update the ebuild.
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2013-12-23 23:53:34 UTC
and no >= kind of deps with spidermonkey anyway, like some arch might be supported in some version and then again not in some version
as in, the ebuild carefully picks which version gets pulled and for which arch, >= would be too broad, rather it's the KEYWORDS= of specific spidermonkey versions which determine supported arch's on the specific spidermonkey version

feel free to apply the Comment #0 logic in tree -- but you missed one line:

use mips && m='mr'

next to the existing

use ia64 && m='mr'

line
Comment 4 Anthony Basile gentoo-dev 2013-12-24 13:59:40 UTC
(In reply to Samuli Suominen from comment #3)
> and no >= kind of deps with spidermonkey anyway, like some arch might be
> supported in some version and then again not in some version
> as in, the ebuild carefully picks which version gets pulled and for which
> arch, >= would be too broad, rather it's the KEYWORDS= of specific
> spidermonkey versions which determine supported arch's on the specific
> spidermonkey version
> 
> feel free to apply the Comment #0 logic in tree -- but you missed one line:
> 
> use mips && m='mr'
> 
> next to the existing
> 
> use ia64 && m='mr'
> 
> line

Okay I committed the change to the ebuild to the tree to -r2.  What do you recommend for the masking?
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2013-12-24 16:53:31 UTC
(In reply to Anthony Basile from comment #4)
> Okay I committed the change to the ebuild to the tree to -r2.  What do you
> recommend for the masking?

no revbump required, I see you noticed the same and did the change directly to -r1 properly. thanks.

what masking? no masking required whatsoever, the working spidermonkey versions get ~mips and those that don't work, simply don't get keyworded
Comment 6 Anthony Basile gentoo-dev 2013-12-24 19:02:41 UTC
(In reply to Samuli Suominen from comment #5)
> (In reply to Anthony Basile from comment #4)
> > Okay I committed the change to the ebuild to the tree to -r2.  What do you
> > recommend for the masking?
> 
> no revbump required, I see you noticed the same and did the change directly
> to -r1 properly. thanks.
> 
> what masking? no masking required whatsoever, the working spidermonkey
> versions get ~mips and those that don't work, simply don't get keyworded

got it