Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 494474 - media-gfx/photivo-9999 should not set EHG_REVISION
Summary: media-gfx/photivo-9999 should not set EHG_REVISION
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Marios Andreopoulos
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-16 21:37 UTC by Alexander Stein
Modified: 2013-12-17 21:14 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch removing EHG_REVISION (photivo.patch,336 bytes, patch)
2013-12-16 21:38 UTC, Alexander Stein
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Stein 2013-12-16 21:37:32 UTC
Currently there is the line
> EHG_REVISION="default"
in the ebuild which. This effectivly prevents setting this variable on command line. 

Reproducible: Always

Steps to Reproduce:
1. EHG_REVISION=b6e851283ac3 emerge 1 photivo

Actual Results:  
Calculating dependencies... done!

>>> Verifying ebuild manifests

>>> Emerging (1 of 1) media-gfx/photivo-9999
>>> cfg-update-1.8.2-r1: Checksum index is up-to-date ...
>>> Unpacking source...
 * Updating /usr/distfiles/hg-src/photivo/hg from https://photivo.googlecode.com/hg/
pulling from https://photivo.googlecode.com/hg/
searching for changes
no changes found
 * Creating working directory in /tmp/portage/media-gfx/photivo-9999/work/photivo-9999 (target revision: default)


Expected Results:  
Calculating dependencies... done!

>>> Verifying ebuild manifests

>>> Emerging (1 of 1) media-gfx/photivo-9999
>>> cfg-update-1.8.2-r1: Creating checksum index...
>>> Unpacking source...
 * Updating /usr/distfiles/hg-src/photivo/hg from https://photivo.googlecode.com/hg/
pulling from https://photivo.googlecode.com/hg/
searching for changes
no changes found
 * Creating working directory in /tmp/portage/media-gfx/photivo-9999/work/photivo-9999 (target revision: b6e851283ac3)

mercurial.eclass actually sets EHG_REVISION="default" if this variable is still unset.
Comment 1 Alexander Stein 2013-12-16 21:38:03 UTC
Created attachment 365478 [details, diff]
patch removing EHG_REVISION
Comment 2 Marios Andreopoulos 2013-12-17 13:57:57 UTC
When we created the ebuild, the mercurial.eclass used to prefer the tip instead of the default branch.

Photivo doesn't have versions, so the latest revision in the default branch is always usable and this is what the developers suggest their users use. On the other hand the tip doesn't always compile.

If mercurial.eclass' behavior changed, I don't have any problem with your suggestion, it is the correct thing to do.
If it still uses the tip by default, I would prefer to keep it as is.
Comment 3 Alexander Stein 2013-12-17 18:35:52 UTC
(In reply to Marios Andreopoulos from comment #2)
> When we created the ebuild, the mercurial.eclass used to prefer the tip
> instead of the default branch.

First off, I don't know the semantics on mercurial, I'm more into git.

> Photivo doesn't have versions, so the latest revision in the default branch
> is always usable and this is what the developers suggest their users use. On
> the other hand the tip doesn't always compile.

I have a problem with artifacts presumably caused by some filters. To test with an older version I tried using EHG_REVISION as described in the eclass, which didn't work :(
That's why I proposed that patch.
 
> If mercurial.eclass' behavior changed, I don't have any problem with your
> suggestion, it is the correct thing to do.
> If it still uses the tip by default, I would prefer to keep it as is.

I removed the line which sets
> EHG_REVISION="default"
mercurial.eclass contains this line:
> : ${EHG_REVISION:="default"}
so IMHO it gets set to default by the eclass, if unset, same as from within the ebuild.
But if this is set from the ebuild I can't overwrite it from command line.
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2013-12-17 21:14:07 UTC
The proposed solution seems correct to me. The eclass will do the correct thing if no EHG_REVISION is specified. Thanks for reporting it.

+  17 Dec 2013; Markos Chandras <hwoarang@gentoo.org> photivo-9999.ebuild:
+  Drop EHG_REVISION so it can be overridden by command line. Bug #494474 by
+  Alexander Stein <alexander.stein@informatik.tu-chemnitz.de>
+