Bugzilla Bug 49427

This is basically an update of bug #48672 - the easytag gtk2 patch doesn't
quite work with gcc2...

gcc -DHAVE_CONFIG_H -I. -I. -I.. -DLOCALE=\"/usr/share/locale\"
-DPACKAGE_DATA_DIR=\"/
usr/share/easytag\"    -mcpu=i686 -O3 -pipe -Wall -I/usr/include/gtk-2.0
-I/usr/lib/gt
k-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0
-I/usr/X11R6/include -I/
usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -c
`test -
f 'et_core.c' || echo './'`et_core.c
et_core.c: In function `ET_Display_File_Info_To_UI':
et_core.c:2341: parse error before `*'
et_core.c:2348: `text' undeclared (first use in this function)
et_core.c:2348: (Each undeclared identifier is reported only once
et_core.c:2348: for each function it appears in.)
et_core.c:2368: `size' undeclared (first use in this function)
et_core.c:2369: `size1' undeclared (first use in this function)
et_core.c:2377: `time' undeclared (first use in this function)
et_core.c:2378: `time1' undeclared (first use in this function)
easytag.c: In function `Action_Remove_Selected_Tags':
easytag.c:1153: parse error before `double'
easytag.c:1154: `fraction' undeclared (first use in this function)
easytag.c:1154: (Each undeclared identifier is reported only once
easytag.c:1154: for each function it appears in.)
easytag.c: In function `Save_List_Of_Files':
easytag.c:1351: parse error before `progress_bar_text'
easytag.c:1352: `progress_bar_text' undeclared (first use in this function)
easytag.c:1380: parse error before `double'
easytag.c:1381: `fraction' undeclared (first use in this function)
et_core.c: In function `ET_Debug_Print_File_List':
et_core.c:3637: warning: unsigned int format, pointer arg (arg 4)
et_core.c: In function `ET_Debug_Print_Artist_Album_List':
et_core.c:3719: warning: unsigned int format, pointer arg (arg 4)
make[3]: *** [et_core.o] Error 1
make[3]: *** Waiting for unfinished jobs....
easytag.c: At top level:
et_core.h:191: warning: `ETFileDescription' defined but not used
make[3]: *** [easytag.o] Error 1
make[3]: Leaving directory
`/var/tmp/portage/easytag-0.31_pre2-r3/work/easytag-0.30.2/
src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory
`/var/tmp/portage/easytag-0.31_pre2-r3/work/easytag-0.30.2/
src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/var/tmp/portage/easytag-0.31_pre2-r3/work/easytag-0.30.2'
make: *** [all] Error 2

!!! ERROR: media-sound/easytag-0.31_pre2-r3 failed.
!!! Function src_compile, Line 60, Exitcode 2
!!! (no error message)


Reproducible: Always
Steps to Reproduce:
1.
2.
3.




Portage 2.0.50-r6 (default-1.0, gcc-2.95.3, glibc-2.2.5-r9, 2.4.25)
==============================================================
===
System uname: 2.4.25 i686 Transmeta(tm) Crusoe(tm) Processor TM5800
Gentoo Base System version 1.4.9
distcc 2.13 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632)
[disabled]
Autoconf: sys-devel/autoconf-2.59-r3
Automake: sys-devel/automake-1.8.3
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-mcpu=i686 -O3 -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER=""
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config 
/usr/kde/3/share/config 
/usr/share/config /usr/share/texmf/dvipdfm/config/ 
/usr/share/texmf/dvips/config/ 
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ 
/usr/share/texmf/xdvi/ 
/var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-mcpu=i686 -O3 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache digest sandbox strict"
GENTOO_MIRRORS="http://128.213.5.34/gentoo/ http://gentoo.mirrors.pair.com/ 
http://mirror.
clarkson.edu/pub/distributions/gentoo/ http://csociety-ftp.ecn.purdue.
edu/pub/gentoo/ http:
//gentoo.chem.wisc.edu/gentoo/ http://mirrors.tds.net/gentoo http:
//open-systems.ufl.
edu/mirrors/gentoo http://mirror.tucdemonic.org/gentoo/ http://ftp.easynet.
nl/mirror/gentoo/ http:
//mirror.cpsc.ucalgary.ca/mirror/gentoo.org"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.namerica.gentoo.org/gentoo-portage"
USE="X X509 aalib alsa apache2 apm avi berkdb bonobo cdr crypt cups curses dga 
dvd emacs 
encode esd ethereal evo fbcon foomaticdb gdbm gif gnome-libs gpm gtk gtk2 
gtkhtml guile imap 
imlib java jpeg lcms ldap libg++ libwww mmx motif mpeg mysql nas ncurses odbc 
oggvorbis oss 
pam pcmcia pda pdflib perl pic plotutils png pnp python quicktime readline
samba 
sdl skey slang 
smooth snmp spell ssl stroke svga tcltk tcpd tetex tiff truetype trusted usb 
vim-with-x x86 xml xml2 
xmms xv zlib"

Created an attachment (id=30350) [edit]
patch to fix easytag gtk2 compilation with gcc2

Gah..I'll never win :)
Thanks Tristan.

Jeremy, please could you modify the ebuild to apply the attached patch - it looks good.

Don't worry about it, I don't mind doing these patches.
I'm just glad gentoo hasn't forgotten about us old gcc2 users :-)

testing...

looks good... in portage

Tristan.. one thing that I meant to mention before
If you do any more patches like this in the future, could you please use "diff -up" ?
The -p will make it show the C function name in the diff, which is useful for me, as I like to apply these by hand to check them properly.
thanks.

Sure, diff -up it is.

Although hopefully we won't need any more of these patches... :-)