Created attachment 365232 [details, diff] remove some deprecated code /var/tmp/portage/www-client/firefox-26.0/work/mozilla-release/js/src/vm/Runtime.cpp: In constructor 'JSRuntime::JSRuntime(JSUseHelperThreads)': /var/tmp/portage/www-client/firefox-26.0/work/mozilla-release/js/src/vm/Runtime.cpp:292:33: error: 'kind' was not declared in this scope distcc[24822] ERROR: compile /var/tmp/portage/www-client/firefox-26.0/work/mozilla-release/js/src/vm/Runtime.cpp on localhost failed make[4]: *** [Runtime.o] Error 1 Apparently (most of) this code was moved to <mozilla-release/js/src/jsapi.cpp>.
DO NOT open a bug upstream unless you are 100% is is from upstream. The bug you have filed is caused by code we have injected from the patchset in GENTOO. Please get direction from the mozilla herd before opening a bug upstream that is effecting GENTOO.
Thanks for reporting, I have updated patchset and pushed updated ebuild to tree.
You are wrong, Jory. Upstream moved all the code _around_ the code in question to a different file. It's true that my new patch was applied on top of that other patch, but the 4 lines should still be removed. I'll update the patch sent upstream. No biggy.
I fixed it for you.
You were way too quick on that one.
Created attachment 370156 [details, diff] firefox-27.0-remove-obsolete-code.patch It's still there, only the context changed for 27.0.
--- firefox-26.0/firefox-26.0-remove-obsolete-code.patch 2014-02-11 15:55:47.000000000 +0100 +++ firefox-27.0/firefox-27.0-remove-obsolete-code.patch 2014-02-11 15:04:26.000000000 +0100 @@ -1,10 +1,9 @@ ---- a/mozilla-release/js/src/vm/Runtime.cpp -+++ b/mozilla-release/js/src/vm/Runtime.cpp -@@ -287,10 +287,6 @@ - PodZero(&debugHooks); - PodZero(&atomState); +--- a/js/src/vm/Runtime.cpp ++++ b/js/src/vm/Runtime.cpp +@@ -300,9 +300,6 @@ PodArrayZero(nativeStackQuota); -- + PodZero(&asmJSCacheOps); + -#if JS_STACK_GROWTH_DIRECTION > 0 - nativeStackLimit = UINTPTR_MAX; -#endif
(In reply to Jeroen Roovers from comment #6) > Created attachment 370156 [details, diff] [details, diff] > firefox-27.0-remove-obsolete-code.patch > > It's still there, only the context changed for 27.0. Same for 27.0.1 and 28.0.
And 29.0...
(In reply to Jeroen Roovers from comment #9) > And 29.0... Jer, upstream is wanting more info... https://bugzilla.mozilla.org/show_bug.cgi?id=950822#c7 If you could respond there, or post info here on the platform(s) this is failing on for you then I'll update that bug.
(In reply to Ian Stakenvicius from comment #10) > (In reply to Jeroen Roovers from comment #9) > > And 29.0... > > Jer, upstream is wanting more info... > https://bugzilla.mozilla.org/show_bug.cgi?id=950822#c7 > > If you could respond there, or post info here on the platform(s) this is > failing on for you then I'll update that bug. No thanks. Look at the rest of that bug report to see why I'd rather not come between Anarchy and Mozilla any more. The compiler error is pretty obvious in view of the changes to the other code path, so figuring out this patch is correct really isn't rocket surgery.
Created attachment 376258 [details, diff] make-possibly-obsolete-code-actually-work-on-hppa Right.. so, upstream thinks this code should stay, to be safe, since there's no guarantee that the RecalculateStackLimit() is called in time to initialize these values properly. So I got an irc-based review+ on this patch. Jer, could you test and confirm it works? If all is good, I'll push this and the others to mozilla's try (not that they test hppa) and get them landed upstream.
If you feel I have closed your bug and it is still a current issue, please reopen and update it completely. We will not work bugs that have no ebuild in tree any longer or can not be reproduced with a current system. Thank You for your support and understanding The Mozilla Team
