Created attachment 364936 [details, diff] cmake-2.8.11.2-FindFreetype.patch old include path: /usr/include/freetype2/freetype/config/ftheader.h new include path: /usr/include/freetype2/config/ftheader.h
(In reply to Julian Ospald (hasufell) from comment #0) > Created attachment 364936 [details, diff] [details, diff] > cmake-2.8.11.2-FindFreetype.patch > > old include path: > /usr/include/freetype2/freetype/config/ftheader.h > > new include path: > /usr/include/freetype2/config/ftheader.h Please send this patch upstream and link back here.
Created attachment 364938 [details, diff] cmake-2.8.11.2-FindFreetype.patch
upstream does not appreciate patches, so have a guess
Created attachment 364954 [details, diff] attachment 364938 [details, diff] modified (In reply to Julian Ospald (hasufell) from comment #3) > upstream does not appreciate patches, so have a guess but it seems upstream might be right about the patch looking odd I haven't tested this patch, but this version looks like it would fit the original macro a bit more.
(In reply to Rafał Mużyło from comment #4) > Created attachment 364954 [details, diff] [details, diff] > attachment 364938 [details, diff] [details, diff] modified > > (In reply to Julian Ospald (hasufell) from comment #3) > > upstream does not appreciate patches, so have a guess > > but it seems upstream might be right about the patch looking odd > > I haven't tested this patch, but this version looks like it would fit the > original macro a bit more. odd?
If I'm reading your changes correctly, the macro would discover freetype, but FREETYPE_INCLUDE_DIR_freetype2 would be set to an incorrect value.
that was my first version of the patch, but I wasn't sure what the include-path is supposed to look like pkg-config and freetype-config both report "/usr/include/freetype2", so I guess yours is right (except for the redundancy)
Created attachment 364956 [details, diff] cmake-2.8.11.2-FindFreetype.patch fixed
upstream is interested in a volunteer who will maintain the module any1?
what I meant is... upstream will not merge this patch, so waiting for that doesn't make sense
*** Bug 493600 has been marked as a duplicate of this bug. ***
this already broke 3 packages I (help) maintain, so what is holding this back?
(In reply to Julian Ospald (hasufell) from comment #12) > this already broke 3 packages I (help) maintain, so what is holding this > back? Patch does not apply on latest testing...
(In reply to Johannes Huber from comment #13) > (In reply to Julian Ospald (hasufell) from comment #12) > > this already broke 3 packages I (help) maintain, so what is holding this > > back? > > Patch does not apply on latest testing... Yeah, it wasn't written for "latest testing". It applies on 2.8.11.2 and 2.8.12.1.
Thanks for reporting and the patch. Path to the find module was adjusted by me in the patch to get this cleanly applied. This is fixed in cvs. Please sync. + + 14 Dec 2013; Johannes Huber <johu@gentoo.org> +cmake-2.8.12.1-r2.ebuild, + +files/cmake-2.8.12.1-FindFreetype.patch, -cmake-2.8.12.1-r1.ebuild: + Revision bump add patch by Julian Ospald <hasufell@gentoo.org> to unbreak find + logic for media-libs/freetype-2.5.1, bug #493656. +
*** Bug 493590 has been marked as a duplicate of this bug. ***
*** Bug 493606 has been marked as a duplicate of this bug. ***
*** Bug 504938 has been marked as a duplicate of this bug. ***
