Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 493440 - sys-block/thin-provisioning-tools: src_test(): g++: error: gmock-1.6.0//gtest/src/gtest-all.cc: No such file or directory
Summary: sys-block/thin-provisioning-tools: src_test(): g++: error: gmock-1.6.0//gtest...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks:
 
Reported: 2013-12-06 13:49 UTC by Jeroen Roovers (RETIRED)
Modified: 2016-05-09 03:26 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for the Makefile.in's to use the system-installed gmock & gtest instead of a local copy (thin-provisioning-tools-0.3.2-testfixes.patch,2.04 KB, patch)
2014-09-02 10:48 UTC, ahudson.news
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen Roovers (RETIRED) gentoo-dev 2013-12-06 13:49:44 UTC
Looks like it expects unpacked gmock/gtest sources.

I don't think this should block bug #493400 since that appears to fix other USE=test related issues anyway.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2014-08-24 13:43:29 UTC
Same with 0.3.2-r1.
Comment 2 ahudson.news 2014-09-01 12:02:54 UTC
This looks to me as being less of a test failure and more a problem of the test Makefile vs. the build environment. The ebuild depends on (test? dev-cpp/gmock), but the test Makefiles are hard-coded to expect a worktree-local copy of specifically gmock-1.6.0 (see also the README.md there). So while probably the intention was to have it use a globally installed gmock package, the current Makefiles do not respect that and are not patched to do so.
Comment 3 ahudson.news 2014-09-02 10:48:51 UTC
Created attachment 384094 [details, diff]
patch for the Makefile.in's to use the system-installed gmock & gtest instead of a local copy

Had a look at patching the Makefile(.in)s: patch attached, tests compile and pass with this.

When integrating this into the ebuild, for safety please enhance the "test?" -dependencies:
- change dev-cpp/gmock to >=dev-cpp/gmock-1.6.0 (since that is what the original downloads and expects; I don't know enough about gmock to be able to tell whether it would work with older versions)
- add >=dev-cpp/gtest-1.6.0 (note this is a pre-req of gmock as well, but since the build process explicitly requires -lgtest we probably should have the dependency?)
Comment 4 SpanKY gentoo-dev 2016-05-09 03:26:59 UTC
(In reply to ahudson.news from comment #3)

thanks, done that now:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e63c09a12fba1f6506fb92344f6f43e465caa55c