Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 493044 - sys-apps/baobab should depend on x11-themes/gnome-icon-theme-extras
Summary: sys-apps/baobab should depend on x11-themes/gnome-icon-theme-extras
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-01 17:13 UTC by poncho
Modified: 2013-12-09 01:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
ebuild patch (icon.patch,351 bytes, patch)
2013-12-01 17:18 UTC, poncho 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description poncho 2013-12-01 17:13:04 UTC 
sys-apps/baobab uses the drive-harddisk-system icon
see https://git.gnome.org/browse/baobab/tree/src/baobab-location.vala?h=gnome-3-8#n128
and this icon is part of x11-themes/gnome-icon-theme-extras

equery b /usr/share/icons/gnome/*/*/drive-harddisk-system.png
 * Searching for /usr/share/icons/gnome/16x16/devices/drive-harddisk-system.png,/usr/share/icons/gnome/22x22/devices/drive-harddisk-system.png,/usr/share/icons/gnome/24x24/devices/drive-harddisk-system.png,/usr/share/icons/gnome/256x256/devices/drive-harddisk-system.png,/usr/share/icons/gnome/32x32/devices/drive-harddisk-system.png,/usr/share/icons/gnome/48x48/devices/drive-harddisk-system.png ... 
x11-themes/gnome-icon-theme-extras-3.6.2 (/usr/share/icons/gnome/22x22/devices/drive-harddisk-system.png)
x11-themes/gnome-icon-theme-extras-3.6.2 (/usr/share/icons/gnome/256x256/devices/drive-harddisk-system.png)
x11-themes/gnome-icon-theme-extras-3.6.2 (/usr/share/icons/gnome/16x16/devices/drive-harddisk-system.png)
x11-themes/gnome-icon-theme-extras-3.6.2 (/usr/share/icons/gnome/32x32/devices/drive-harddisk-system.png)
x11-themes/gnome-icon-theme-extras-3.6.2 (/usr/share/icons/gnome/48x48/devices/drive-harddisk-system.png)
x11-themes/gnome-icon-theme-extras-3.6.2 (/usr/share/icons/gnome/24x24/devices/drive-harddisk-system.png)
Comment 1 poncho 2013-12-01 17:18:33 UTC 
Created attachment 364346 [details, diff]
ebuild patch
Comment 2 Pacho Ramos gentoo-dev 2013-12-01 21:24:23 UTC 
+  01 Dec 2013; Pacho Ramos <pacho@gentoo.org> -baobab-3.6.4.ebuild,
+  -baobab-3.8.1.ebuild, baobab-3.8.2.ebuild:
+  x11-themes/gnome-icon-theme-extras is needed (#493044 by poncho), update
+  homepage, drop old.
+
Comment 3 Mart Raudsepp gentoo-dev 2013-12-07 09:47:22 UTC 
Why wasn't the gnome-icon-theme-extras dep put into the RDEPEND only section, like in the attached patch, but in COMMON_DEPEND, which sounds wrong?
Comment 4 Pacho Ramos gentoo-dev 2013-12-07 09:59:50 UTC 
Was a mistake I think, please feel free to go ahead and change it
Comment 5 poncho 2013-12-09 01:05:13 UTC 
Please fix the baobab-3.10.1.ebuild in the gnome overlay as well.