Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 492574 - =sys-fs/eudev should check whether to print "rc-update add udev-postmount default" message
Summary: =sys-fs/eudev should check whether to print "rc-update add udev-postmount def...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: AMD64 Linux
: Normal minor (vote)
Assignee: eudev team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-11-26 05:55 UTC by Sergey S. Starikoff
Modified: 2014-03-28 20:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey S. Starikoff 2013-11-26 05:55:11 UTC
On today's update (includeing eudev-1.1 → eudev-1.3) I've seen the following message:
 * Please add the udev-postmount init script to your default runlevel
 * to ensure the legacy rule-generator functionality works as reliably
 * as possible.
 * 	rc-update add udev-postmount default
 * 

But I already have udev-postmount script in my default runlevel:
# rc-update show | grep udev-postmount
       udev-postmount |      default

Ebuild (sys-fs/eudev/eudev-1.3.ebuild) contains the following conditions for this message:
"if use rule-generator && use openrc; then"

To my mind portage also should perform a check about udev-postmount script status and echo this message only if it isn't present in auto-start (rc-update show) list.
Comment 1 Oleh 2014-03-14 15:07:01 UTC
1. udev-init-scripts, which is a dependency for eudev, suggests to remove udev-postmount from any of runlevels. It's not used by sys-fs/udev.
2. Why udev-postmount (eudev's) supposed to run in default runlevel?
Comment 2 Ian Stakenvicius (RETIRED) gentoo-dev 2014-03-14 16:03:26 UTC
sys-fs/udev doesn't do any rule-generation since version 183; eudev does, however, when built with USE="rule-generator".  The udev-postmount init script is specifically meant to be run after all (at least local) filesystems have been mounted, so that any generated rules can be saved to disk.

I concur with the original poster; this message only -needs- to be specified when eudev is built with USE="rule-generator" enabled.  Technically, if we follow the other recent elog recommendations, it shouldn't show up unless USE="rule-generator" goes from disabled to enabled, regardless of whether it is actually in a runlevel.

We will adjust for the next revision.  Thanks for reporting!
Comment 3 Anthony Basile gentoo-dev 2014-03-28 18:19:42 UTC
(In reply to Ian Stakenvicius from comment #2)
> sys-fs/udev doesn't do any rule-generation since version 183; eudev does,
> however, when built with USE="rule-generator".  The udev-postmount init
> script is specifically meant to be run after all (at least local)
> filesystems have been mounted, so that any generated rules can be saved to
> disk.
> 
> I concur with the original poster; this message only -needs- to be specified
> when eudev is built with USE="rule-generator" enabled.  Technically, if we
> follow the other recent elog recommendations, it shouldn't show up unless
> USE="rule-generator" goes from disabled to enabled, regardless of whether it
> is actually in a runlevel.
> 
> We will adjust for the next revision.  Thanks for reporting!

Ian can you take care of this in 1.5.3-r1 and -9999.
Comment 4 Ian Stakenvicius (RETIRED) gentoo-dev 2014-03-28 19:06:56 UTC
(In reply to Anthony Basile from comment #3)
> (In reply to Ian Stakenvicius from comment #2)
> > sys-fs/udev doesn't do any rule-generation since version 183; eudev does,
> > however, when built with USE="rule-generator".  The udev-postmount init
> > script is specifically meant to be run after all (at least local)
> > filesystems have been mounted, so that any generated rules can be saved to
> > disk.
> > 
> > I concur with the original poster; this message only -needs- to be specified
> > when eudev is built with USE="rule-generator" enabled.  Technically, if we
> > follow the other recent elog recommendations, it shouldn't show up unless
> > USE="rule-generator" goes from disabled to enabled, regardless of whether it
> > is actually in a runlevel.
> > 
> > We will adjust for the next revision.  Thanks for reporting!
> 
> Ian can you take care of this in 1.5.3-r1 and -9999.

Done.

I also patched udev-init-scripts so that it doesn't ask users to remove the runlevel anymore if eudev[rule-generator] is installed, that should be a big help.
Comment 5 Anthony Basile gentoo-dev 2014-03-28 20:44:20 UTC
(In reply to Ian Stakenvicius from comment #4)
> (In reply to Anthony Basile from comment #3)
> > (In reply to Ian Stakenvicius from comment #2)
> > > sys-fs/udev doesn't do any rule-generation since version 183; eudev does,
> > > however, when built with USE="rule-generator".  The udev-postmount init
> > > script is specifically meant to be run after all (at least local)
> > > filesystems have been mounted, so that any generated rules can be saved to
> > > disk.
> > > 
> > > I concur with the original poster; this message only -needs- to be specified
> > > when eudev is built with USE="rule-generator" enabled.  Technically, if we
> > > follow the other recent elog recommendations, it shouldn't show up unless
> > > USE="rule-generator" goes from disabled to enabled, regardless of whether it
> > > is actually in a runlevel.
> > > 
> > > We will adjust for the next revision.  Thanks for reporting!
> > 
> > Ian can you take care of this in 1.5.3-r1 and -9999.
> 
> Done.
> 
> I also patched udev-init-scripts so that it doesn't ask users to remove the
> runlevel anymore if eudev[rule-generator] is installed, that should be a big
> help.

Looks good thanks!