Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 491038 - =dev-util/buildbot-slave-0.8.8: Add systemd support
Summary: =dev-util/buildbot-slave-0.8.8: Add systemd support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo systemd Team
URL:
Whiteboard:
Keywords: NeedPatch
Depends on:
Blocks: 487736
  Show dependency tree
 
Reported: 2013-11-11 21:03 UTC by Markos Chandras (RETIRED)
Modified: 2013-12-22 08:57 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markos Chandras (RETIRED) gentoo-dev 2013-11-11 21:03:46 UTC
Hi,

Could you add systemd support to buildbot-slave-0.8.8 so it can go stable along with buildbot-0.8.8 (bug #487736) ?

Thanks
Comment 1 Pacho Ramos gentoo-dev 2013-11-17 12:27:13 UTC
What is the proper way to start buildbot-slave?
I thought it was simply:
# /usr/bin/buildslave start
error reading '/usr/portage/app-emulation/virtualbox-modules/buildbot.tac': No such file or directory
invalid buildslave directory '/usr/portage/app-emulation/virtualbox-modules'

But it fails as you can see :S
Comment 2 Markos Chandras (RETIRED) gentoo-dev 2013-11-24 20:30:48 UTC
See here

http://docs.buildbot.net/current/tutorial/firstrun.html#creating-a-slave

so assuming your /home/pacho/workdir/slavedir is your slave box working directory

you should 'cd /home/pacho/workdir' and then 'buildslave start slavedir'

Also look at the current init script.
Comment 3 Pacho Ramos gentoo-dev 2013-12-14 08:01:15 UTC
Yeah, I was wondering about why init.d script doesn't use that and, instead, runs:
--exec /usr/bin/python -- /usr/bin/twistd

:/
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2013-12-14 10:41:56 UTC
(In reply to Pacho Ramos from comment #3)
> Yeah, I was wondering about why init.d script doesn't use that and, instead,
> runs:
> --exec /usr/bin/python -- /usr/bin/twistd
> 
> :/

I don't know to be honest, but the buildbot master is also doing this and you also added a systemd file there

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/dev-util/buildbot/files/buildmaster.initd?revision=1.4&view=markup

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/dev-util/buildbot/files/buildbot.service?revision=1.1&view=markup
Comment 5 Pacho Ramos gentoo-dev 2013-12-14 13:08:33 UTC
Ah, I guess it's because for buildbot I was able to pass the directory at the end of the command... will try for this one too then ;)
Comment 6 Pacho Ramos gentoo-dev 2013-12-22 08:57:01 UTC
+*buildbot-slave-0.8.8-r1 (22 Dec 2013)
+
+  22 Dec 2013; Pacho Ramos <pacho@gentoo.org> +buildbot-slave-0.8.8-r1.ebuild,
+  +files/buildslave.service:
+  Add unit file (#491038)
+