Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 489504 - media-video/vlc-2.1.0 - freerdp dependency still automagic
Summary: media-video/vlc-2.1.0 - freerdp dependency still automagic
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tom Wijsman (TomWij) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-26 19:59 UTC by Jouni Kosonen
Modified: 2013-10-26 20:50 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log with USE=-rdp (media-video:vlc-2.1.0:20131026-192411.log,441.01 KB, text/plain)
2013-10-26 20:03 UTC, Jouni Kosonen
Details
emerge --info (emerge_info,6.68 KB, text/plain)
2013-10-26 20:05 UTC, Jouni Kosonen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jouni Kosonen 2013-10-26 19:59:19 UTC
media-video/vlc-2.1.0 compiles against freerdp if it installed, regardless of USE=-rdp.
Comment 1 Jouni Kosonen 2013-10-26 20:03:44 UTC
Created attachment 362012 [details]
build log with USE=-rdp

from work/vlc-2.1.0/config.log:

configure:54357: WARNING: unrecognized options: --disable-freerdp

from $(work/vlc-2.1.0/configure --help):

--enable-libfreerdp     (RDP/Remote Desktop client support) [default=auto]

Suggested fix:
357c357
<                 $(use_enable rdp freerdp) \
---
>                 $(use_enable rdp libfreerdp) \

Also, the dependency should probably be raised to
>=net-misc/freerdp-1.1.0_beta1_20130710:0=
because of files/vlc-2.1.0-newer-rdp.patch
Comment 2 Jouni Kosonen 2013-10-26 20:05:17 UTC
Created attachment 362014 [details]
emerge --info
Comment 3 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-10-26 20:50:10 UTC
Yes, after removing it from all versions except 9999 I have added it again, which caused me to backport the wrong name; so, this is fixed nw:

+  26 Oct 2013; Tom Wijsman <TomWij@gentoo.org> vlc-2.1.0.ebuild,
+  vlc-2.1.9999.ebuild, vlc-9999.ebuild:
+  Corrected name of freerdp configure flag; reported by Jouni Kosonen, fixes bug
+  #489504. Since it was automatically enabled and a rather minor feature in
+  terms of size, not worth the compile time of a revision bump.

And upon more carefully checking, I've put back 9999 as it should be:

+  26 Oct 2013; Tom Wijsman <TomWij@gentoo.org> vlc-9999.ebuild:
+  Actually, upon checking I now see that in the 9999 branch the configure flag
+  was renamed from libfreerdp to freerdp; it is due to this that the bug occured
+  as I was changing the backport of the freerdp USE flag right before committing
+  2.1.0.

Thank you for reporting and helping to increase the quality of the new versions.