Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 488422 - net-misc/livestreamer - A Command Line Interface that pipes video streams from various services into a video player.
Summary: net-misc/livestreamer - A Command Line Interface that pipes video streams fro...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Default Assignee for New Packages
URL:
Whiteboard:
Keywords: EBUILD, InVCS
Depends on: 488510
Blocks:
  Show dependency tree
 
Reported: 2013-10-17 20:23 UTC by Nikos Chantziaras
Modified: 2013-10-30 18:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
livestreamer-1.6.1.ebuild (livestreamer-1.6.1.ebuild,674 bytes, text/plain)
2013-10-17 20:23 UTC, Nikos Chantziaras
Details
livestreamer-1.6.1.ebuild (livestreamer-1.6.1.ebuild,674 bytes, text/plain)
2013-10-18 17:21 UTC, Nikos Chantziaras
Details
livestreamer-1.6.1.ebuild (livestreamer-1.6.1.ebuild,673 bytes, text/plain)
2013-10-28 22:05 UTC, Nikos Chantziaras
Details
livestreamer-1.6.1.ebuild (livestreamer-1.6.1.ebuild,647 bytes, text/plain)
2013-10-28 22:15 UTC, Nikos Chantziaras
Details
livestreamer-1.6.1.ebuild (livestreamer-1.6.1.ebuild,631 bytes, text/plain)
2013-10-30 15:56 UTC, Nikos Chantziaras
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikos Chantziaras 2013-10-17 20:23:37 UTC
Created attachment 361162 [details]
livestreamer-1.6.1.ebuild

This is an ebuild for Livestreamer. Upstream description:

  Livestreamer is a Command Line Interface that pipes video streams from
  various services into a video player, such as VLC. The main purpose of
  Livestreamer is to allow the user to avoid buggy and CPU heavy flash
  plugins but still be able to enjoy various streamed content.

In short, it's used to watch live streams from sites like twitch.tv but without having to go through the bugs and pains of Adobe Flash.

The ebuild is very minimal and thus hopefully low maintainance.

The software comes with different licenses. One is MIT, though it doesn't match any version in /usr/portage/licenses (neither MIT, MIT-with-advertising nor MIT_Plus). It matches the MIT license as given by OSI:

  http://opensource.org/licenses/MIT

I've chosen "MIT-with-advertising" in the ebuild, due to lack of an actual original copy of the MIT license within portage.

The other licenses used are BSD-2 and Apache-2.0. See the LICENSE* files in:

  https://github.com/chrippa/livestreamer

Not that the licenses are no in an OR relation to each other; they all apply simultaneously.

One of the deps for this package is python-librtmp, which is not in portage. Fortunately, it's an optional dep.

The media-video/rtmpdump and dev-python/pycrypto deps are actually also optional, but I'm not sure if it's worth introducing USE flags for them. Please comment on it if you think USE flags are needed. rtmpdump, even though optional, would cripple the software if missing so I guess it's not worth a USE flag. pycrypto could possibly be pulled in by a "crypt" USE flag?
Comment 1 Nikos Chantziaras 2013-10-17 20:24:56 UTC
Oh, btw, the category should probably be "net-misc".
Comment 2 Tom Wijsman (TomWij) (RETIRED) gentoo-dev 2013-10-17 23:22:05 UTC
Review:

1. First line does not match /usr/portage/header.txt, the start date is required.
2. Consider EAPI="5" and migration to distutils-r1 (see [1])
3. Consider to sort variables like KEYWORDS and (R)DEPEND for easier maintenance.

Looks good for the rest.

This package has no maintainer so this bug may go unnoticed for a long time.
Gentoo has a dedicated team[2] for assisting users in maintaining orphaned
packages. If you are interested in maintaining this package, please contact
proxy-maint@gentoo.org. 

 [1]: http://wiki.gentoo.org/wiki/Python-r1#Migrating_distutils_packages
 [2]: http://www.gentoo.org/proj/en/qa/proxy-maintainers/index.xml
Comment 3 Nikos Chantziaras 2013-10-18 17:21:18 UTC
Created attachment 361246 [details]
livestreamer-1.6.1.ebuild

Thanks. This is an updated ebuild including all suggested changes.

Since it turns out that Livestreamer needs a newer rtmpdump version than is available in Portage in order to have good Twitch.tv support (probably the most popular of the streaming sites), I will open a bump request for it and make this one depend on it. So for now, this ebuild is in no hurry :-)
Comment 4 Markos Chandras (RETIRED) gentoo-dev 2013-10-21 10:53:23 UTC
Bug #488510 is now resolved, and the attachment here looks good. So all we need now it to convince you to become the maintainer of this package.
Comment 5 Markos Chandras (RETIRED) gentoo-dev 2013-10-26 10:23:11 UTC
(In reply to Nikos Chantziaras from comment #3)
> Created attachment 361246 [details]
> livestreamer-1.6.1.ebuild
> 
> Thanks. This is an updated ebuild including all suggested changes.
> 
> Since it turns out that Livestreamer needs a newer rtmpdump version than is
> available in Portage in order to have good Twitch.tv support (probably the
> most popular of the streaming sites), I will open a bump request for it and
> make this one depend on it. So for now, this ebuild is in no hurry :-)

I have a few comments here. First it appears the rtmpdump is still wrong. It seems it should be >2.4 and not >=. Also the dev-python/requests dependency looks weird. It feels wrong to only require a subset of the available versions. This will most likely create conflicts and other update problems with other packages. does it really not work with 0.X or 2.X?
Comment 6 Nikos Chantziaras 2013-10-28 22:05:57 UTC
Created attachment 362178 [details]
livestreamer-1.6.1.ebuild

(In reply to Markos Chandras from comment #5)
> I have a few comments here. First it appears the rtmpdump is still wrong. It
> seems it should be >2.4 and not >=.

Yep. I updated the ebuild. (Well, technically it works with 2.4, it's just that twitch.tv is crippled with that version. So I suppose >2.4 is a good idea.)


> Also the dev-python/requests dependency
> looks weird. It feels wrong to only require a subset of the available
> versions. This will most likely create conflicts and other update problems
> with other packages. does it really not work with 0.X or 2.X?

Unfortunately, it does't:

  Traceback (most recent call last):
    File "/usr/lib/python-exec/python3.2/livestreamer", line 5, in <module>
      from pkg_resources import load_entry_point
    File "/usr/lib64/python3.2/site-packages/pkg_resources.py", line 2793, in
      <module>
      working_set.require(__requires__)
    File "/usr/lib64/python3.2/site-packages/pkg_resources.py", line 673, in
      require
      needed = self.resolve(parse_requirements(requirements))
    File "/usr/lib64/python3.2/site-packages/pkg_resources.py", line 576, in
      resolve
      raise DistributionNotFound(req)
  pkg_resources.DistributionNotFound: requests>=1.0,<3.0

So for now, it seems the deps are needed. I'll file an upstream bug for this though.
Comment 7 Nikos Chantziaras 2013-10-28 22:15:04 UTC
Created attachment 362180 [details]
livestreamer-1.6.1.ebuild

No, wait, actually it works fine with 2.x. It only doesn't work with 0.x. So the only dep that's needed in the ebuild is:

  >=dev-python/requests-1.0

I removed the other one.
Comment 8 Markos Chandras (RETIRED) gentoo-dev 2013-10-29 08:23:58 UTC
This is much better. I will take care of it tonight
Comment 9 Markos Chandras (RETIRED) gentoo-dev 2013-10-29 18:45:41 UTC
Where did you find the dev-python/pbs dependency? It does not exist in the portage tree.
Comment 10 Nikos Chantziaras 2013-10-30 15:56:53 UTC
Created attachment 362302 [details]
livestreamer-1.6.1.ebuild

(In reply to Markos Chandras from comment #9)
> Where did you find the dev-python/pbs dependency? It does not exist in the
> portage tree.

Oops. It didn't register as an error since I have pbs from the palmer overlay. I used the livestreamer ebuild from palmer as the starting point for this one and I assumed that dev-python/pbs is needed *and* in portage.

It looks like it's not actually needed at all. I removed the dep.
Comment 11 Markos Chandras (RETIRED) gentoo-dev 2013-10-30 18:23:00 UTC
+*livestreamer-1.6.1 (30 Oct 2013)
+
+  30 Oct 2013; Markos Chandras <hwoarang@gentoo.org> +livestreamer-1.6.1.ebuild,
+  +metadata.xml:
+  Initial commit. Bug #488422. Thanks to Nikos Chantziaras <realnc@gmail.com>
+  for the ebuild and for agreeing to become the maintainer