Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 488272 - dev-libs/json-c: Add gx86-multilib support
Summary: dev-libs/json-c: Add gx86-multilib support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Multilib team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: gx86-multilib 484252
  Show dependency tree
 
Reported: 2013-10-16 19:52 UTC by Reinis Danne
Modified: 2013-11-30 18:35 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
json-c-0.11.ebuild.patch (json-c-0.11.ebuild.patch,1.80 KB, patch)
2013-10-16 19:53 UTC, Reinis Danne
Details | Diff
Alternative gx86 patch with working tests (json-c-0.11.ebuild.patch,1.83 KB, patch)
2013-11-12 17:58 UTC, Steven Newbury
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Reinis Danne 2013-10-16 19:52:09 UTC
Dependency of 32bit pulsaudio.

Reproducible: Always
Comment 1 Reinis Danne 2013-10-16 19:53:04 UTC
Created attachment 361066 [details, diff]
json-c-0.11.ebuild.patch
Comment 2 Markos Chandras (RETIRED) gentoo-dev 2013-10-23 11:57:16 UTC
Reassigning to multilib as i am not that familiar with these eclasses yet.
Comment 3 Steven Newbury 2013-11-12 17:58:33 UTC
Created attachment 363136 [details, diff]
Alternative gx86 patch with working tests

A little duplication of effort, but my version keeps FEATURES=test working.
Comment 4 Steven Newbury 2013-11-12 18:06:27 UTC
Between the two patches, one thing that could be combined (improved in my patch) would be using INCLUDES=-I${S} for the tests, rather than symlinking the headers.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-11-24 10:58:05 UTC
I've taken another route and added in-source build support to autotools-multilib. This allowed me to convert the ebuild with minimal changes.

+*json-c-0.11-r1 (24 Nov 2013)
+
+  24 Nov 2013; Michał Górny <mgorny@gentoo.org> +json-c-0.11-r1.ebuild:
+  Enable multilib support, bug #488272.

No blockers since it doesn't seem to collide with emul-linux (library name change?)
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-11-25 19:47:12 UTC
The json-c in emul-linux has different SONAME than converted one.

Let's keep this open once we decide if we want to convert an older version as well, or just bump emul-linux.
Comment 7 Pacho Ramos gentoo-dev 2013-11-25 20:51:05 UTC
(In reply to Michał Górny from comment #6)
> The json-c in emul-linux has different SONAME than converted one.
> 
> Let's keep this open once we decide if we want to convert an older version
> as well, or just bump emul-linux.

I don't think we need to convert older versions, this is a "classical" issue with old emul sets -> we need to wait until next round to get all libs in sync with native ones :/
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-11-30 15:06:07 UTC
So shall I replace json-c with the multilib dep when bumping emul-linux, or just keep old json-c there?
Comment 9 Pacho Ramos gentoo-dev 2013-11-30 17:15:23 UTC
Are you talking about emul-linux ebuild when 32 bits USE is enabled? (the "metadata" usage of the ebuild?) In that case I think there is no problem on it pulling the newer version :/ (at least for this concrete case)
Comment 10 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-11-30 18:35:01 UTC
Added json-c to remove-native as well then.