488114 – dev-db/redis: systemd unit file

Bug 488114 - dev-db/redis: systemd unit file

Summary: dev-db/redis: systemd unit file

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Johan Bergström

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	install-systemd-unit
	Show dependency tree

Reported:	2013-10-15 12:18 UTC by Julien Sanchez
Modified:	2013-10-15 18:35 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Redis systemd unit file (redis.service,799 bytes, text/plain) 2013-10-15 12:18 UTC, Julien Sanchez	Details
redis-2.6.15.ebuild diff (redis-2.6.15.ebuild.patch,604 bytes, patch) 2013-10-15 12:19 UTC, Julien Sanchez	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Julien Sanchez archtester

2013-10-15 12:18:13 UTC

Created attachment 360936 [details]
Redis systemd unit file

I have added systemd unit file for redis ebuild. I kept the same defaults as in the current default confd file.

Could you review both ebuild patch and service files? (Of course, I have tested them on my system).

Just a side note, isn't there an inconsistency between confd and initd files about PID file path? confd file's default is /var/run/redis/redis.pid and initd file's one is /run/redis/redis.pid. 
What is Gentoo ebuild policy about {/var/run,/run} files? Should /run paths be always used now?

Comment 1 Julien Sanchez archtester

2013-10-15 12:19:21 UTC

Created attachment 360938 [details, diff]
redis-2.6.15.ebuild diff

Comment 2 Pacho Ramos gentoo-dev

2013-10-15 18:35:37 UTC

+*redis-2.6.15-r1 (15 Oct 2013)
+
+  15 Oct 2013; Pacho Ramos <pacho@gentoo.org> +files/redis.service,
+  +files/redis.tmpfiles, +redis-2.6.15-r1.ebuild:
+  Add unit file (#488114 by Julien Sanchez)
+