Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 487354 - media-libs/grilo: improvement for use of python-any-r1
Summary: media-libs/grilo: improvement for use of python-any-r1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-08 20:59 UTC by Michał Górny
Modified: 2013-10-14 20:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild diff (grilo-0.2.7.ebuild.diff,838 bytes, patch)
2013-10-08 21:00 UTC, Michał Górny
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-10-08 20:59:39 UTC
+++ This bug was initially created as a clone of Bug #487352 +++

python-any-r1 has been given a new 'python_gen_any_dep' [1] function that can be used to generate deps that will enforce that all packages will have at least one matching python impl (along with python_check_deps()).

I'm attaching a diff that makes use of the new function. It applies to both ebuilds using the eclass.

Please either commit the change or let me know that you're ok with it. Since it's fairly trivial, I will commit it on the weekend if I get no reply. If you have any questions, feel free to ask here or on the IRC.

[1]:http://wiki.gentoo.org/wiki/Python/python-any-r1#python_gen_any_dep
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-10-08 21:00:07 UTC
(sorry, hit 'enter' too fast)
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-10-08 21:00:39 UTC
Created attachment 360436 [details, diff]
Ebuild diff
Comment 3 Pacho Ramos gentoo-dev 2013-10-08 21:37:47 UTC
Only one note:
+	[[ ${MERGE_TYPE} != binary ]] && use test && python-any-r1_pkg_setup

Is there any case needing python-any-r1_pkg_setup with "binary"? If not, why not move that part inside "python-any-r1_pkg_setup" (returning when "binary")?
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-10-08 21:41:42 UTC
I don't see a good reason to enforce a design limitation like this. I guess some packages may actually need Python during pkg_*.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-10-14 20:12:15 UTC
Committed.