Bugzilla Bug 48672

I can't build media-sound/easytag-0.31_pre2-r2 with gcc 2.95. The problems seem
to be in the gtk2 patch (easytag-0.30.2-dsd3.patch.bz2). I have attached a
patch which fixes the problems. It is a lot larger than the usual gcc2 patches
that I submit, so it probably should be tested before being committed.

gcc -DHAVE_CONFIG_H -I. -I. -I.. -DLOCALE=\"/usr/share/locale\"
-DPACKAGE_DATA_DIR=\"/
usr/share/easytag\"    -mcpu=i686 -O3 -pipe -Wall -I/usr/include/gtk-2.0
-I/usr/lib/gt
k-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0
-I/usr/X11R6/include -I/
usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -c
`test -
f 'cddb.c' || echo './'`cddb.c
browser.c: In function `Browser_List_Remove_File':
browser.c:1137: parse error before `row'
browser.c:1143: `row' undeclared (first use in this function)
browser.c:1143: (Each undeclared identifier is reported only once
browser.c:1143: for each function it appears in.)
browser.c:1145: `currentPath' undeclared (first use in this function)
browser.c:1149: `currentIter' undeclared (first use in this function)
browser.c:1150: `currentETFile' undeclared (first use in this function)
browser.c: In function `Browser_List_Select_File_By_Etfile':
browser.c:1168: parse error before `row'
browser.c:1174: `row' undeclared (first use in this function)
browser.c:1176: `currentPath' undeclared (first use in this function)
browser.c:1180: `currentIter' undeclared (first use in this function)
browser.c:1181: `currentETFile' undeclared (first use in this function)
browser.c: In function `Browser_List_Unselect_File_By_Etfile':
browser.c:1233: parse error before `row'
browser.c:1239: `row' undeclared (first use in this function)
browser.c:1241: `currentPath' undeclared (first use in this function)
browser.c:1245: `currentIter' undeclared (first use in this function)
browser.c:1246: `currentETFile' undeclared (first use in this function)
browser.c: In function `Browser_Display_Tree_Or_Artist_Album_List':
browser.c:1640: parse error before `*'
browser.c:1641: `list' undeclared (first use in this function)
browser.c: At top level:
et_core.h:191: warning: `ETFileDescription' defined but not used
make[3]: *** [browser.o] Error 1
make[3]: *** Waiting for unfinished jobs....
cddb.c: In function `Cddb_Search_String_In_Result':
cddb.c:856: parse error before `itercopy'
cddb.c:886: `itercopy' undeclared (first use in this function)
cddb.c:886: (Each undeclared identifier is reported only once
cddb.c:886: for each function it appears in.)
cddb.c: In function `Cddb_Set_Track_Infos_To_File_List':
cddb.c:2167: parse error before `*'
cddb.c:2168: `cddbtrackalbum' undeclared (first use in this function)
cddb.c: In function `Cddb_Generate_Cddb_Id':
cddb.c:2300: warning: unsigned int format, long unsigned int arg (arg 2)
cddb.c: At top level:
et_core.h:191: warning: `ETFileDescription' defined but not used
make[3]: *** [cddb.o] Error 1
make[3]: Leaving directory
`/var/tmp/portage/easytag-0.31_pre2-r2/work/easytag-0.30.2/
src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory
`/var/tmp/portage/easytag-0.31_pre2-r2/work/easytag-0.30.2/
src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/var/tmp/portage/easytag-0.31_pre2-r2/work/easytag-0.30.2'
make: *** [all] Error 2

!!! ERROR: media-sound/easytag-0.31_pre2-r2 failed.
!!! Function src_compile, Line 56, Exitcode 2
!!! (no error message)


Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Actual Results:  
Portage 2.0.50-r6 (default-1.0, gcc-2.95.3, glibc-2.2.5-r9, 2.4.25)
==============================================================
===
System uname: 2.4.25 i686 Transmeta(tm) Crusoe(tm) Processor TM5800
Gentoo Base System version 1.4.9
distcc 2.13 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632)
[disabled]
Autoconf: sys-devel/autoconf-2.59-r3
Automake: sys-devel/automake-1.8.3
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-mcpu=i686 -O3 -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER=""
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3/share/config 
/usr/share/config /usr/share/texmf/dvipdfm/config/
/usr/share/texmf/dvips/config/ 
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/texmf/xdvi/ 
/var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-mcpu=i686 -O3 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache digest sandbox strict"
GENTOO_MIRRORS="http://128.213.5.34/gentoo/ http://gentoo.mirrors.pair.com/
http://mirror.
clarkson.edu/pub/distributions/gentoo/
http://csociety-ftp.ecn.purdue.edu/pub/gentoo/ http:
//gentoo.chem.wisc.edu/gentoo/ http://mirrors.tds.net/gentoo
http://open-systems.ufl.
edu/mirrors/gentoo http://mirror.tucdemonic.org/gentoo/
http://ftp.easynet.nl/mirror/gentoo/ http:
//mirror.cpsc.ucalgary.ca/mirror/gentoo.org"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.namerica.gentoo.org/gentoo-portage"
USE="X X509 aalib alsa apache2 apm avi berkdb bonobo cdr crypt cups curses dga
dvd emacs 
encode esd ethereal evo fbcon foomaticdb gdbm gif gnome-libs gpm gtk gtk2
gtkhtml guile imap 
imlib java jpeg lcms ldap libg++ libwww mmx motif mpeg mysql nas ncurses odbc
oggvorbis oss 
pam pcmcia pda pdflib perl pic plotutils png pnp python quicktime readline
samba sdl skey slang 
smooth snmp spell ssl stroke svga tcltk tcpd tetex tiff truetype trusted usb
vim-with-x x86 xml xml2 
xmms xv zlib"

Created an attachment (id=29811) [details]
patch to fix compilation with gcc-2.95 (`use gtk2`)

Jeremy: I'll take this one, i'm the author of the easytag GTK2 porting work.

Took a quick glance, and it looks good. I'll apply this into the newer patch
I'll be releasing over the weekend sometime.
Thanks.

it's already in portage.  I left it open because i hadn't sent it upstream
yet... but sindce you're the upstream dev, I guess you have it now ;)