Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 486632 - =mail-client/trojita-0.3.96 configure time check, missing dep, seems to require dev-qt/qttest
Summary: =mail-client/trojita-0.3.96 configure time check, missing dep, seems to requi...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-01 07:14 UTC by Matthew Thode ( prometheanfire )
Modified: 2013-10-04 11:48 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch-trojita-cmake.patch (patch-trojita-cmake.patch,858 bytes, patch)
2013-10-02 12:15 UTC, Jan Kundrát (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2013-10-01 07:14:22 UTC
-- Found Qt4: /usr/bin/qmake (found suitable version "4.8.4", minimum required is "4.6") 
Qt QTTEST library not found.
-- Qt4 module QTTEST is required because of WITH_TESTS
CMake Error at cmake/TrojitaOption.cmake:141 (message):
  Qt4 module QTTEST was not found
Call Stack (most recent call first):
  CMakeLists.txt:74 (trojita_check_qt4_module)


-- Configuring incomplete, errors occurred!
 * ERROR: mail-client/trojita-0.3.96::gentoo failed (configure phase):
 *   cmake failed
 * 
 * Call stack:
 *     ebuild.sh, line   93:  Called src_configure
 *   environment, line 3106:  Called cmake-utils_src_configure
 *   environment, line  775:  Called _execute_optionaly 'src_configure'
 *   environment, line  258:  Called enable_cmake-utils_src_configure
 *   environment, line 1133:  Called die
 * The specific snippet of code:
 *       "${CMAKE_BINARY}" "${cmakeargs[@]}" "${CMAKE_USE_DIR}" || die "cmake failed";
Comment 1 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2013-10-01 07:40:22 UTC
Confirmed by installing =dev-qt/qttest-4.8.4 before retrying.
Comment 2 Agostino Sarubbo gentoo-dev 2013-10-01 12:06:23 UTC
the problem should be in the syntax, it enables the test also with -test.

It didn't fail for me because I have qttest installed
Comment 3 Jan Kundrát (RETIRED) gentoo-dev 2013-10-02 12:15:31 UTC
Created attachment 359968 [details, diff]
patch-trojita-cmake.patch

Sorry about that. The attached patch fixes the configure-time options by:

- properly using an array instead of bash string
- setting up correct flag names

Apart from that, a small cleanup:
- the qt4-r2 is no longer required
- The minimal Qt version is bumped to 4.8 because that's the version which offers extra features. While trojita works with 4.6, there's no reason to support such ancient stuff on Gentoo.

Please apply this to both -0.3.96 and -9999.

BTW, as an upstream, I absolutely do want anyone who builds Trojita to run the test suite. How can I do this on Gentoo?
Comment 4 Matthew Thode ( prometheanfire ) archtester Gentoo Infrastructure gentoo-dev Security 2013-10-02 16:00:39 UTC
We can add testing support, we just need explicit dependencies for it and what we need to invoke in order to run the tests.
Comment 5 Jan Kundrát (RETIRED) gentoo-dev 2013-10-02 21:32:41 UTC
The patch I attached earlier today fixes the issue reported here.

Please ignore the comment about the desirability to run the tests during the build, it seems that the current EAPIs do not offer that possibility except when the user has explicitly set FEATURES=test. Otherwise, the ebuild has full support for tests using the standard ebuild mechanisms (src_test).

I don't have write access to the gentoo-x86. Dear KDE team, please put this patch into the tree.
Comment 6 Agostino Sarubbo gentoo-dev 2013-10-04 11:48:35 UTC
done