Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 486404 - dev-util/ccache: use readme.gentoo.eclass
Summary: dev-util/ccache: use readme.gentoo.eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords: Inclusion, PATCH
Depends on:
Blocks: 434250
  Show dependency tree
 
Reported: 2013-09-29 00:20 UTC by Christoph Junghans (RETIRED)
Modified: 2013-10-21 21:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch against ccache-3.1.9-r2.ebuild (ccache-3.1.9-r3.ebuild.patch,2.17 KB, patch)
2013-09-29 00:20 UTC, Christoph Junghans (RETIRED)
Details | Diff
patch against ccache-3.1.9-r2.ebuild (ccache-3.1.9-r3.ebuild.patch,1.99 KB, patch)
2013-09-29 01:23 UTC, Christoph Junghans (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Junghans (RETIRED) gentoo-dev 2013-09-29 00:20:38 UTC
Created attachment 359708 [details, diff]
patch against ccache-3.1.9-r2.ebuild

Just moved the elog messages into DOC_CONTENTS.
Comment 1 SpanKY gentoo-dev 2013-09-29 01:04:44 UTC
Comment on attachment 359708 [details, diff]
patch against ccache-3.1.9-r2.ebuild

>+	DOC_CONTENTS="To use ccache with **non-Portage** C compiling, add
>+		${EPREFIX}/usr/$(get_libdir)/ccache/bin to the beginning of your path, before ${EPREFIX}usr/bin.
>+		Portage 2.0.46-r11+ will automatically take advantage of ccache with
>+		no additional steps.  If this is your first install of ccache, type
>+		something like this to set a maximum cache size of 2GB:\\n# ccache -M 2G\\n
>+		If you are upgrading from an older version than 3.x you should clear all of your caches like so:\\n
>+		# CCACHE_DIR='${CCACHE_DIR:-${PORTAGE_TMPDIR}/ccache}' ccache -C\\n
>+		ccache now supports sys-devel/clang and dev-lang/icc, too!"

this isn't readable at all

move it to the end of src_install before you call create doc and reformat it:

    DOC_CONTENTS="
To use ccache with **non-Portage** C compiling, add .....
......\\n
# ccache -M 2G\\n
If you are upgrading from an older version ......
"
Comment 2 SpanKY gentoo-dev 2013-09-29 01:05:39 UTC
the other alternative is to not use a README at all.  instead, put the documentation into ccache-config --help.  that's where people usually start.
Comment 3 Christoph Junghans (RETIRED) gentoo-dev 2013-09-29 01:23:50 UTC
Created attachment 359710 [details, diff]
patch against ccache-3.1.9-r2.ebuild

Reformatted! I will leave it to somebody else to modity ccache-config --help.
Comment 4 SpanKY gentoo-dev 2013-09-29 01:42:29 UTC
Comment on attachment 359710 [details, diff]
patch against ccache-3.1.9-r2.ebuild

(In reply to Christoph Junghans from comment #3)

i meant doing the --help in place of the gentoo readme, not in addition to

feel free to commit this patch though
Comment 5 Pacho Ramos gentoo-dev 2013-09-29 06:34:18 UTC
I would replace the readme.gentoo_pkg_postinst by readme.gentoo_print_elog and move it to the pkg_postinst phase
Comment 6 Christoph Junghans (RETIRED) gentoo-dev 2013-10-21 21:40:13 UTC
+*ccache-3.1.9-r3 (21 Oct 2013)
+
+  21 Oct 2013; Christoph Junghans <ottxor@gentoo.org> +ccache-3.1.9-r3.ebuild:
+  use readme.gentoo.eclass (bug #486404)
+