Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 486158 - dev-python/mako-1.0.0 version bump
Summary: dev-python/mako-1.0.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
: 520440 (view as bug list)
Depends on:
Blocks: 512242
  Show dependency tree
 
Reported: 2013-09-27 06:37 UTC by eroen
Modified: 2014-10-01 11:51 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dev-python:mako-0.9.0:20130927-192833.log (20130927-192833.log,67.45 KB, text/plain)
2013-09-27 19:30 UTC, eroen
Details

Note You need to log in before you can comment on or make changes to this bug.
Description eroen 2013-09-27 06:37:46 UTC
mako-0.9.0 is released a while ago, please include new version in Gentoo.

Of particular interest is that the current mako package in Gentoo does not support python3.3. The changelog mentions several python3 related changes, one would hope support is now possible.

## Changelog since 0.7.3 (http://www.makotemplates.org/CHANGES):
0.9.0
- [bug] The Context.locals_() method becomes a private underscored
  method, as this method has a specific internal use. The purpose
  of Context.kwargs has been clarified, in that it only delivers
  top level keyword arguments originally passed to template.render().
  [ticket:219]

- [bug] Fixed the babel plugin to properly interpret ${} sections
  inside of a "call" tag, i.e. <%self:some_tag attr="${_('foo')}"/>.
  Code that's subject to babel escapes in here needs to be
  specified as a Python expression, not a literal.  This change
  is backwards incompatible vs. code that is relying upon a _('')
  translation to be working within a call tag.

- [bug] The Babel plugin has been repaired to work on Python 3.
  [ticket:187]

- [bug] Using <%namespace import="*" module="somemodule"/> now
  skips over module elements that are not explcitly callable,
  avoiding TypeError when trying to produce partials.
  [ticket:207]

- [bug] Fixed Py3K bug where a "lambda" expression was not
  interpreted correctly within a template tag; also
  fixed in Py2.4.  [ticket:190]

0.8.1
- [bug] Changed setup.py to skip installing markupsafe
  if Python version is < 2.6 or is between 3.0 and
  less than 3.3, as Markupsafe now only supports 2.6->2.X,
  3.3->3.X. [ticket:216]

- [bug] Fixed regression where "entity" filter wasn't
  converted for py3k properly (added tests.)
  [ticket:214]

- [bug] Fixed bug where mako-render script wasn't
  compatible with Py3k.  [ticket:212]

- [bug] Cleaned up all the various deprecation/
  file warnings when running the tests under
  various Pythons with warnings turned on.
  [ticket:213]

0.8.0
- [feature] Performance improvement to the
  "legacy" HTML escape feature, used for XML
  escaping and when markupsafe isn't present,
  courtesy George Xie.

- [bug] Fixed bug whereby an exception in Python 3
  against a module compiled to the filesystem would
  fail trying to produce a RichTraceback due to the
  content being in bytes. [ticket:209]

- [bug] Change default for compile()->reserved_names
  from tuple to frozenset, as this is expected to be
  a set by default.  [ticket:208]

- [feature] Code has been reworked to support Python 2.4->
  Python 3.xx in place.  2to3 no longer needed.

- [feature] Added lexer_cls argument to Template,
  TemplateLookup, allows alternate Lexer classes
  to be used.

- [feature] Added future_imports parameter to Template
  and TemplateLookup, renders the __future__ header
  with desired capabilities at the top of the generated
  template module.  Courtesy Ben Trofatter.
Comment 1 eroen 2013-09-27 19:30:16 UTC
Created attachment 359644 [details]
dev-python:mako-0.9.0:20130927-192833.log

With the following changes, dropping the patch and 2to3 call, mako-0.9.0 passes tests and seems to work for simple experiments using python{2.7,3.2,3.3} on an almost-~amd64 system.

--- mako-0.7.3-r1.ebuild	2013-09-27 16:44:01.732696696 +0200
+++ mako-0.9.0.ebuild	2013-09-27 17:00:46.481460894 +0200
@@ -4,7 +4,7 @@
 
 EAPI=5
 
-PYTHON_COMPAT=( python{2_6,2_7,3_2} )
+PYTHON_COMPAT=( python{2_6,2_7,3_2,3_3} )
 
 inherit distutils-r1
 
@@ -27,20 +27,9 @@
 
 S="${WORKDIR}/${MY_P}"
 
-PATCHES=(
-	"${FILESDIR}/test-fix.patch"
-)
-
 python_test() {
 	cp -r -l test "${BUILD_DIR}"/ || die
 
-	if [[ ${EPYTHON} == python3.* ]]; then
-		# Notes:
-		#   -W is not supported by python3.1
-		#   -n causes Python to write into hardlinked files
-		2to3 --no-diffs -w "${BUILD_DIR}"/test || die
-	fi
-
 	cd "${BUILD_DIR}"/test || die
 	nosetests || die "Tests fail with ${EPYTHON}"
 }
Comment 2 eroen 2013-09-27 20:03:34 UTC
Sorry, I missed that I had dev-python/beaker from ::progress installed on the test box, which has python3_3 enabled.
Comment 3 eroen 2013-09-27 20:58:44 UTC
Beaker is listed as an optional dependency in setup.py, though. All tests still succeed if beaker is not installed at all.
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2014-08-21 22:26:34 UTC
*** Bug 520440 has been marked as a duplicate of this bug. ***
Comment 5 Ben de Groot (RETIRED) gentoo-dev 2014-09-30 07:10:23 UTC
+  30 Sep 2014; Ben de Groot <yngwin@gentoo.org> +mako-1.0.0.ebuild:
+  Version bump, thanks to eroen in bug #486158. As this is a major version bump,
+  it's masked for testing.
Comment 6 Ben de Groot (RETIRED) gentoo-dev 2014-10-01 11:51:22 UTC
Since I got no negative feedback, I've unmasked this.