Bug 485816 – www-client/firefox-24.0 passes unused configure options tracejit and methodjit

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Benjamin Peterson 2013-09-24 04:15:31 UTC]

The firefox ebuild passes --(enable|disable)-tracejit and --(enable|disable)-methodjit. Neither of these do anything, since the trace jit was removed long ago and the method jit fairly recently.

Reproducible: Always

[Comment 1 Jory A. Pratt 2013-09-24 13:32:16 UTC]

methodjit is still used, tracejit has been drop. I will fix this later tonight.

[Comment 2 Benjamin Peterson 2013-09-24 13:37:40 UTC]

Well, methodjit is definitely gone in 24...

[Comment 3 Jory A. Pratt 2013-09-24 13:45:39 UTC]

(In reply to Benjamin Peterson from comment #2)
> Well, methodjit is definitely gone in 24...

You can grep js/src/ you will see methodjit is not gone. Please double check the code before you assume a changelog or portage output is correct.

[Comment 4 Benjamin Peterson 2013-09-24 13:49:58 UTC]

In js/src, I see

js/src/tests/shell.js
619:        optionName != "methodjit" &&
620:        optionName != "methodjit_always" &&

js/src/jsopcode.cpp
1468:     * the methodjit has "splatted" the arguments array, bumping the caller's

js/src/assembler/assembler/SparcAssembler.h
20:#include "methodjit/Logging.h"

js/src/assembler/assembler/MIPSAssembler.h
38:#include "methodjit/Logging.h"

js/src/jsscript.cpp
2600:        /* Step mode has been enabled or disabled. Alert the methodjit. */

js/src/jit-test/tests/jaeger/bug659456.js
2:function foo() { return "tracejit,methodjit"; };

js/src/jit-test/tests/jaeger/recompile/bug648843.js
6:function options() { return "methodjit"; }

js/src/jit-test/tests/jaeger/bug719918.js
12:// run function a lot to trigger methodjit compile

js/src/jit-test/tests/auto-regress/bug743071.js
25:        optionName != "methodjit_always")

js/src/gc/Marking.h
229:/* Direct value access used by the write barriers and the methodjit. */

js/src/gc/Verifier.cpp
599:     * We need to bump gcNumber so that the methodjit knows that jitcode has

js/src/jsdbgapi.h
66: * to and interact with running methodjit-ed frames. In particular, it causes

which is just random crap left over from methodjit removal...

[Comment 5 Ian Stakenvicius (RETIRED) 2013-09-24 14:51:21 UTC]

+*firefox-24.0-r1 (24 Sep 2013)
+
+  24 Sep 2013; Ian Stakenvicius <[e-mail]> +firefox-24.0-r1.ebuild,
+  -firefox-24.0.ebuild:
+  Fix bug #485838 and bug #485816

Note regarding methodjit -- it's definitely still used but you're right in that there's no configure option to explicitly enable/disable it anymore.  We'll have to adjust ebuilds again.

--- grep -i methodjit mozilla-23/js/src/configure.in
+++ grep -i methodjit mozilla-24/js/src/configure.in
@@ -8,13 +8,6 @@
     ENABLE_METHODJIT_TYPED_ARRAY=1
     ENABLE_METHODJIT=1
     ENABLE_METHODJIT_TYPED_ARRAY=1
-MOZ_ARG_DISABLE_BOOL(methodjit,
-[  --disable-methodjit           Disable method JIT support],
-  ENABLE_METHODJIT= )
-MOZ_ARG_ENABLE_BOOL(methodjit-spew,
-[  --enable-methodjit-spew      Enable method JIT spew support],
-  ENABLE_METHODJIT_SPEW=1,
-  ENABLE_METHODJIT_SPEW= )
 AC_SUBST(ENABLE_METHODJIT)
 AC_SUBST(ENABLE_METHODJIT_SPEW)
 if test "$ENABLE_METHODJIT"; then

[Comment 6 Jory A. Pratt 2013-09-24 22:45:46 UTC]

Completely removed methodjit/tracejit in both fx-24.0 and tb-24.0