Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 485398 - dev-python/irc-8.5.1 should not DEPEND on dev-python/hgtools and app-text/dos2unix
Summary: dev-python/irc-8.5.1 should not DEPEND on dev-python/hgtools and app-text/dos...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords: EBUILD, PATCH
Depends on:
Blocks:
 
Reported: 2013-09-19 11:06 UTC by Bertrand Jacquin
Modified: 2013-09-19 16:11 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
dev-python/irc-8.5.1.ebuild.diff (dev-python-irc-8.5.1.ebuild-nohg.diff,846 bytes, patch)
2013-09-19 11:06 UTC, Bertrand Jacquin 		Details | Diff
files/8.5.1-remove-hg-dependencies.diff (8.5.1-remove-hg-dependencies.diff,583 bytes, patch)
2013-09-19 11:07 UTC, Bertrand Jacquin 		Details | Diff
dev-python/irc-8.5.1.ebuild-clenup-DEPEND.diff (dev-python-irc-8.5.1.ebuild-cleanup-DEPEND.diff,765 bytes, patch)
2013-09-19 12:10 UTC, Bertrand Jacquin 		Details | Diff
files/8.5.1-cleanup-requires.diff (8.5.1-cleanup-requires.diff,339 bytes, patch)
2013-09-19 12:11 UTC, Bertrand Jacquin 		Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bertrand Jacquin 2013-09-19 11:06:22 UTC 
dev-python/irc has build time dependency on dev-python/hgtools, but ebuild src_prepare() force to not use hg_version. The attached patch remove dependency on hg-tools in ebuild and setup.py.

This permit us to remove the dos2unix trick done on setup.py to not prevent setup from downloading hgtools package.

Reproducible: Always
Comment 1 Bertrand Jacquin 2013-09-19 11:06:48 UTC 
Created attachment 358996 [details, diff]
dev-python/irc-8.5.1.ebuild.diff
Comment 2 Bertrand Jacquin 2013-09-19 11:07:10 UTC 
Created attachment 358998 [details, diff]
files/8.5.1-remove-hg-dependencies.diff
Comment 3 Bertrand Jacquin 2013-09-19 12:10:22 UTC 
Created attachment 359008 [details, diff]
dev-python/irc-8.5.1.ebuild-clenup-DEPEND.diff

v2, previous was leading to mismatch in egg-info version.

This also remove dependency on unneeded dev-python/pytest-runner
Comment 4 Bertrand Jacquin 2013-09-19 12:11:26 UTC 
Created attachment 359010 [details, diff]
files/8.5.1-cleanup-requires.diff

v2: also remove pytest-runner
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2013-09-19 14:57:05 UTC 
The dos2unix dependency is not needed anyhow. A simple sed script does the job, and eutils.eclass already "implements" this in edos2unix().
Comment 6 Bertrand Jacquin 2013-09-19 15:50:20 UTC 
(In reply to Jeroen Roovers from comment #5)
> The dos2unix dependency is not needed anyhow. A simple sed script does the
> job, and eutils.eclass already "implements" this in edos2unix().

Yep have been removed. python handle CRLF nicely. So need to more work in this case.
Comment 7 Mike Gilbert gentoo-dev 2013-09-19 16:11:52 UTC 
+  19 Sep 2013; Mike Gilbert <floppym@gentoo.org>
+  +files/irc-8.5.1-setup_requires.patch, -files/irc-8-setup.py.patch,
+  -files/irc-setup.py.3.4.2.patch, -files/irc-setup.py.8.0.1.patch,
+  -files/irc-setup.py.patch, -irc-8.2.ebuild, -irc-8.3-r1.ebuild,
+  -irc-8.3.1.ebuild, -irc-8.3.ebuild, -irc-8.4.ebuild, -irc-8.5.ebuild,
+  irc-8.5.1.ebuild:
+  Restore patch to drop hgtools dep, thanks to Bertrand Jacquin on bug 485398.
+  Remove old ebuilds and patches.
+