Bug 484840 – Add QA warning for -Waggressive-loop-optimizations

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Ryan Hill (RETIRED) 2013-09-14 06:58:48 UTC]

Created attachment 358616 [details, diff]
portage-2.2.3-qa-aggressive-loop.patch

Just ran into an infinite loop bug in a package with gcc 4.8.  We should flag these warnings (enabled by -Wall) to catch problems like this which will usually only appear at runtime.

linux/gl_draw.c: In function 'gl_drawwin':
cc1: warning: iteration 222u invokes undefined behavior [-Waggressive-loop-optimizations]
linux/gl_draw.c:329:5: note: containing loop
     for (i = 0; i < 224; i++)
     ^

This one kind of sucks because the filename/line won't be in the qawarn but it's better than nothing.

[Comment 1 Zac Medico 2013-09-15 00:31:13 UTC]

Thanks, this is in git:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=bb6f7fc22b59a8949dfd4bb362d4522b1cc6d048

[Comment 2 Zac Medico 2013-09-15 11:28:02 UTC]

This is fixed in 2.2.5.