Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 484422 - media-gfx/cropgui: re-implements python wrapping manually
Summary: media-gfx/cropgui: re-implements python wrapping manually
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA (vote)
Assignee: Mikle Kolyada (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 484398
  Show dependency tree
 
Reported: 2013-09-09 21:46 UTC by Michał Górny
Modified: 2014-03-13 08:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-09-09 21:46:09 UTC
install_cropgui_wrapper() {
    python_domodule cropgtk.py cropgui_common.py filechooser.py cropgui.glade
    make_wrapper "${PN}-${EPYTHON}" "${PYTHON} $(python_get_sitedir)/${PN}/cropgtk.py"
}

src_install() {
    local python_moduleroot="${PN}"
    python_foreach_impl install_cropgui_wrapper
    dosym python-exec /usr/bin/"${PN}"


Not that I have a really good idea how to fix this but please at least keep this bug open for reference.
Comment 1 Sergey Popov gentoo-dev 2013-09-10 06:30:42 UTC
(In reply to Michał Górny from comment #0)
> Not that I have a really good idea how to fix this but please at least keep
> this bug open for reference.

IMO the only way to fix this without upstream intervention is to drop support for multiple ABIs which definitely would be a regression for our users.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-09-17 20:19:13 UTC
FYI: I've forced python-exec:0 in the ebuild now. We will probably revisit this near python-exec:2 going stable, so please keep the bug open.
Comment 3 Raphaël Droz 2014-02-13 16:54:54 UTC
In case of a version bump (or simply ebuild fix):

For cropgui to work:
sed 's/import Image/from PIL import Image/' filechooser.py cropgui_common.py
# 4 occurences (2 Image, 1 ImageFilter, 1 ImageDraw)

Please note that README and LICENCE were added recently in the upstream git tree.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-03-13 08:12:52 UTC
+*cropgui-0.1.1-r3 (13 Mar 2014)
+
+  13 Mar 2014; Michał Górny <mgorny@gentoo.org> +cropgui-0.1.1-r3.ebuild:
+  Use python_doexe() to make it non-dependant on Python wrapping implementation,
+  bug #484422.