Bug 48425 – gnome-terminal-2.6.1 compile failure with GCC 3.4.0

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Robert Moss (RETIRED) 2004-04-19 19:41:56 UTC]

There's a pretty daft error in the gnome-terminal-2.6.1 release which prevents compilation with GCC 3.4.0. It's very easy to fix, though. There's a couple of functions which are defined differently in the header and C files. A fix will follow.

Reproducible: Always
Steps to Reproduce:
1. Emerge gcc 3.4.0 prerelease (unsure if this is necessary).
2. Emerge gnome-terminal-2.6.1.
3. Crunch.
Actual Results:  
See 3 above.

Expected Results:  
Not 3.

Portage 2.0.50-r6 (default-x86-2004.0, gcc-3.4.0, glibc-2.3.3_pre20040207-r0,
2.6.5-gentoo-r1)
=================================================================
System uname: 2.6.5-gentoo-r1 i686 AMD Athlon(tm) XP 1600+
Gentoo Base System version 1.4.9
Autoconf: sys-devel/autoconf-2.59-r3
Automake: sys-devel/automake-1.8.3
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-O3 -march=athlon-xp -momit-leaf-frame-pointer -fomit-frame-pointer
-funroll-loops -ffast-math -ftracer -fprefetch-loop-arrays -finline-limit=600
-mfpmath=387 -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3/share/config /usr/lib/mozilla/defaults/pref /usr/share/config
/usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/texmf/xdvi/ /var/qmail/control"CONFIG_PROTECT_MASK="/etc/gconf
/etc/terminfo /etc/env.d"
CXXFLAGS="-O3 -march=athlon-xp -momit-leaf-frame-pointer -fomit-frame-pointer
-funroll-loops -ffast-math -ftracer -fprefetch-loop-arrays -finline-limit=600
-mfpmath=387 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs fixpackages sandbox"
GENTOO_MIRRORS="ftp://mirror.ac.uk/sites/www.ibiblio.org/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage/local /usr/local/portage/gnome-current"
SYNC="rsync://rsync.de.gentoo.org/gentoo-portage"
USE="3dnow X Xaw3d aalib acpi adns alsa avi bonobo cdr crypt cups curl dga dvd
encode esd ethereal faad flac foomatic gdbm ggi gif gnome gnomedb gpm gstreamer
gtk2 gtkhtml guile icu imap imlib innodb ipv6 java joystick jpeg lirc mad md5sum
memlimit mikmod mmx motif mozilla moznocompose moznoirc moznomail mozsvg mpeg
mpi mysql nas ncurses net nls nogcj offensive ofx oggvorbis openal opengl oss
pam parse-clocks pda pdflib perl png ppds python quicktime readline ruby samba
sdl slang slp spell sse ssl svga tcltk tcpd tetex tiff truetype unicode usb
videos vim-with-x wmf x86 xml xml2 xv xvid zlib"

[Comment 1 Robert Moss (RETIRED) 2004-04-19 19:43:32 UTC]

Created attachment 29673 [details, diff]
Patch to fix compilation error

Incorrect usage of GdkModifierType and EggVirtualModifierType - one should be
used, but not both; which should be used is perhaps debatable, I've gone for
the latter so the patch is for the header file and not the C source file.

[Comment 2 foser (RETIRED) 2004-04-27 07:50:07 UTC]

patch added, thnx

has this been reported upstream ? if yes, what is the exact buglink ?

[Comment 3 Robert Moss (RETIRED) 2004-04-27 21:24:11 UTC]

No, it hasn't yet. It will be soon - as soon as I've finished getting everything compiled with GCC 3.4.0, all the patches etc. are going upstream. I want to make extra sure I haven't broken anything - this one is easy, but there are some, like libSDL and mplayer, and openoffice-ximian and STLport in particular, which are VERY tricky...

[Comment 4 foser (RETIRED) 2004-04-28 02:21:04 UTC]

they are all seperate bugs and should be fixed asap, so please just file them right away.