Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 483252 - app-emulation/wine: possible redundant dependencies
Summary: app-emulation/wine: possible redundant dependencies
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Wine Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-01 10:21 UTC by Rafał Mużyło
Modified: 2013-09-05 20:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rafał Mużyło 2013-09-01 10:21:01 UTC
x11-apps/xmessage is almost definitely redundant - it was used by winelauncher script that was removed a few years ago.

There's also x11-libs/libXmu which seems redundant too, which quite likely is redundant too, but I don't have a proof other than configure not checking for it.
Also, due to the silly part of AC_PATH_XTRA macro, it is possible, that one of {libSM,libICE,libXt} (dependencies of libXmu) might still be used, even though wine doesn't explicitly check for those libs.
Comment 1 Alexandre Rostovtsev (RETIRED) gentoo-dev 2013-09-01 14:39:32 UTC
The xmessage dependency was already removed from all wine ebuilds a year ago (bug #431140)

You are correct about libXmu, it's not needed since wine-0.9.27

AC_PATH_XTRA is silly, and unfortunately, it does result in winex11 linking with libSM and libICE.

+  01 Sep 2013; Alexandre Rostovtsev <tetromino@gentoo.org> wine-1.2.3.ebuild,
+  wine-1.3.28.ebuild, wine-1.4.ebuild, wine-1.4.1.ebuild, wine-1.5.0.ebuild,
+  wine-1.5.1.ebuild, wine-1.5.2.ebuild, wine-1.5.3.ebuild, wine-1.5.4.ebuild,
+  wine-1.5.5.ebuild, wine-1.5.6.ebuild, wine-1.5.7.ebuild, wine-1.5.8.ebuild,
+  wine-1.5.9.ebuild, wine-1.5.10-r1.ebuild, wine-1.5.11-r1.ebuild,
+  wine-1.5.12-r1.ebuild, wine-1.5.13-r1.ebuild, wine-1.5.14-r1.ebuild,
+  wine-1.5.15-r2.ebuild, wine-1.5.16-r1.ebuild, wine-1.5.17.ebuild,
+  wine-1.5.18.ebuild, wine-1.5.19.ebuild, wine-1.5.20.ebuild,
+  wine-1.5.21.ebuild, wine-1.5.22.ebuild, wine-1.5.23-r1.ebuild,
+  wine-1.5.24.ebuild, wine-1.5.25.ebuild, wine-1.5.26.ebuild,
+  wine-1.5.27.ebuild, wine-1.5.28.ebuild, wine-1.5.29.ebuild,
+  wine-1.5.30.ebuild, wine-1.5.31.ebuild, wine-1.6.ebuild, wine-1.7.0.ebuild,
+  wine-9999.ebuild:
+  Do not pull in corefonts when USE=truetype; users who need the original
+  corefonts instead of Wine's version can use winetricks (bug #481122, thanks
+  to Luke-Jr). Do not depend on libXmu (not needed), but do depend on libSM and
+  libICE (pulled in due to AC_PATH_XTRA silliness) (bug #483252, thanks to
+  Rafał Mużyło).
Comment 2 Rafał Mużyło 2013-09-01 14:58:01 UTC
OK, I wonder where I was still seeing that xmessage.

However, perhaps instead of dependency on unused libs (if they are really unused), we could come up with an automagic fix ?
Comment 3 Alexandre Rostovtsev (RETIRED) gentoo-dev 2013-09-01 15:28:10 UTC
(In reply to Rafał Mużyło from comment #2)
> However, perhaps instead of dependency on unused libs (if they are really
> unused), we could come up with an automagic fix ?

Please talk with upstream about that :)
Comment 4 Rafał Mużyło 2013-09-05 20:58:36 UTC
Not as much as I wanted to, but http://source.winehq.org/git/wine.git/commit/bb50d6fd9512a9a05306c56112bbcdc6de6c8d65.