Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 483060 - x11-terms/gnome-terminal-3.8.4 fails to build with dev-util/gdbus-codegen-2.36.4, non-UTF8 system locale, and python3 as system python interpreter
Summary: x11-terms/gnome-terminal-3.8.4 fails to build with dev-util/gdbus-codegen-2.3...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 378027
  Show dependency tree
 
Reported: 2013-08-30 20:03 UTC by Fernando (likewhoa)
Modified: 2013-09-01 21:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (gnome-terminal-3.8.4.build.log,15.68 KB, text/x-log)
2013-08-30 20:04 UTC, Fernando (likewhoa)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fernando (likewhoa) 2013-08-30 20:03:00 UTC
seems like a unicode issue. only happening in amd64.

Reproducible: Always

Steps to Reproduce:
1. emerge =x11-terms/gnome-terminal-3.8.4::gentoo
Actual Results:  
>>> Source configured.
>>> Compiling source in /var/tmp/portage/x11-terms/gnome-terminal-3.8.4/work/gnome-terminal-3.8.4 ...
make 
make  all-recursive
make[1]: Entering directory `/var/tmp/portage/x11-terms/gnome-terminal-3.8.4/work/gnome-terminal-3.8.4'
Making all in src
make[2]: Entering directory `/var/tmp/portage/x11-terms/gnome-terminal-3.8.4/work/gnome-terminal-3.8.4/src'
( /usr/bin/glib-genmarshal --prefix=_terminal_marshal ./terminal-marshal.list \
                        --header \
                        --body \
                        --internal > terminal-marshal.c.tmp \
        && mv terminal-marshal.c.tmp terminal-marshal.c ) \
|| ( rm -f terminal-marshal.c.tmp && exit 1 )
( /usr/bin/glib-genmarshal --prefix=_terminal_marshal ./terminal-marshal.list \
                --header \
                --internal > terminal-marshal.h.tmp \
&& mv terminal-marshal.h.tmp terminal-marshal.h ) \
|| ( rm -f terminal-marshal.h.tmp && exit 1 )
/usr/bin/glib-mkenums --template terminal-type-builtins.c.template terminal-enums.h > xgen-ttbc \
&& (cmp -s xgen-ttbc terminal-type-builtins.c || cp xgen-ttbc terminal-type-builtins.c ) \
&& rm -f xgen-ttbc
/usr/bin/glib-mkenums --template terminal-type-builtins.h.template terminal-enums.h > xgen-ttbh \
&& (cmp -s xgen-ttbh terminal-type-builtins.h || cp xgen-ttbh terminal-type-builtins.h ) \
&& rm -f xgen-ttbh \
&& echo timestamp > stamp-terminal-type-builtins.h
/usr/bin/gdbus-codegen \
                --interface-prefix=org.gnome.Terminal \
                --c-namespace=Terminal \
                --c-generate-object-manager \
                --generate-c-code terminal-gdbus-generated \
                org.gnome.Terminal.xml
Traceback (most recent call last):
  File "/usr/bin/gdbus-codegen-python3.2", line 35, in <module>
    sys.exit(codegen_main.codegen_main())
  File "/usr/lib64/python3.2/site-packages/gdbus_codegen/codegen_main.py", line 170, in codegen_main
    xml_data = f.read()
  File "/usr/lib64/python3.2/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 212: ordinal not in range(128)
make[2]: *** [terminal-gdbus-generated.c] Error 1
make[2]: Leaving directory `/var/tmp/portage/x11-terms/gnome-terminal-3.8.4/work/gnome-terminal-3.8.4/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/x11-terms/gnome-terminal-3.8.4/work/gnome-terminal-3.8.4'
make: *** [all] Error 2
 * ERROR: x11-terms/gnome-terminal-3.8.4::gentoo failed (compile phase):
 *   emake failed
 * 



Portage 2.2.1 (default/linux/amd64/13.0/desktop, gcc-4.7.3, glibc-2.17, 3.8.7-hardened x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-3.8.7-hardened-x86_64-Intel-R-_Xeon-R-_CPU_E5420_@_2.50GHz-with-gentoo-2.2
KiB Mem:    28772428 total,   4074100 free
KiB Swap:   33554428 total,  33441532 free
Timestamp of tree: Thu, 29 Aug 2013 00:15:01 +0000
ld GNU ld (GNU Binutils) 2.23.2
distcc 3.1 x86_64-pc-linux-gnu [disabled]
ccache version 3.1.9 [disabled]
app-shells/bash:          4.2_p45
dev-lang/python:          2.7.5-r2, 3.2.5-r2, 3.3.2-r2
dev-util/ccache:          3.1.9
dev-util/cmake:           2.8.11.1
dev-util/pkgconfig:       0.28
sys-apps/baselayout:      2.2
sys-apps/openrc:          0.12
sys-apps/sandbox:         2.6-r1
sys-devel/autoconf:       2.69
sys-devel/automake:       1.11.6, 1.13.4, 1.14
sys-devel/binutils:       2.23.2
sys-devel/gcc:            4.7.3
sys-devel/gcc-config:     1.8
sys-devel/libtool:        2.4.2
sys-devel/make:           3.82-r4
sys-kernel/linux-headers: 3.10 (virtual/os-headers)
sys-libs/glibc:           2.17
Repositories: gentoo
ACCEPT_KEYWORDS="amd64 ~amd64 ~x86"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/themes/oxygen-gtk/gtk-2.0"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/splash /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
USE="X aac accessibility acl acpi alsa amd64 berkdb bindist bluetooth branding bzip2 cairo cdda cdr cli consolekit cracklib crypt cups cxx dbus dri dts dvd dvdr emboss encode exif fam fbcondecor firefox flac fortran gdbm gif gpm gtk iconv ipv6 jpeg kde lcms ldap libnotify livecd loop-aes mad mmx mng modules mpeg mudflap multilib ncurses nls nouveau nptl ogg opengl openmp pam pango pax_kernel pcre pdf png policykit ppds qt3support qt4 readline sdl session socks5 spell sse sse2 ssl startup-notification svg tcpd tiff truetype udev udisks unicode upower usb vorbis wxwidgets xcb xml xv zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_2" RUBY_TARGETS="ruby19 ruby18" USERLAND="GNU" VIDEO_CARDS="fbdev glint intel mach64 mga nouveau nv r128 radeon savage sis tdfx trident vesa via vmware dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, MAKEOPTS, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, SYNC, USE_PYTHON
Comment 1 Fernando (likewhoa) 2013-08-30 20:04:43 UTC
Created attachment 357460 [details]
build log
Comment 2 Pacho Ramos gentoo-dev 2013-08-30 20:21:31 UTC
What locales are you using? Also this looks a bit risky to me:
ACCEPT_KEYWORDS="amd64 ~amd64 ~x86"
Comment 3 Fernando (likewhoa) 2013-08-30 20:26:22 UTC
running 'export LANG="<YOUR LANGUAGE>.UTF-8"' allows emerge to complete.
Comment 4 Fernando (likewhoa) 2013-08-30 20:27:54 UTC
@Pacho Ramos submitted last comment at the same time, anyways i am using default locale.
Comment 5 Pacho Ramos gentoo-dev 2013-08-30 20:32:46 UTC
It fails in python stuff... I think python had some problems with non-utf8 :/
Comment 6 Fernando (likewhoa) 2013-08-30 20:34:11 UTC
(In reply to Pacho Ramos from comment #5)
> It fails in python stuff... I think python had some problems with non-utf8 :/

same with net-im/empathy, I will file that bug also.
Comment 7 Pacho Ramos gentoo-dev 2013-08-30 20:42:30 UTC
CCing python team to clarify this problem
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-08-30 20:53:42 UTC
Pretty common issue in Python. If the script doesn't declare an encoding when opening a file, it is opened with the encoding specified in locale.

Depending on the exact task the code is performing, it either needs to specify the encoding when opening the file (e.g. using io.open(..., encoding='utf8')) or open the file in binary mode. Can't tell much more not knowing the exact internals. In any case, this is upstream issue.
Comment 9 Alexandre Rostovtsev (RETIRED) gentoo-dev 2013-09-01 21:31:39 UTC
In the particular case of building gnome-terminal, the error manifests only when using python3 as the default python interpreter.

But this is a real bug in gdbus-codegen which has existed for a long time and can in theory also happen when using python2. The problem is that gdbus-codegen does not respect the encoding specified in input XML files' declaration, and instead always uses the build environment's encoding.
Comment 10 Alexandre Rostovtsev (RETIRED) gentoo-dev 2013-09-01 21:33:28 UTC
Ah, looks like it's already fixed in upstream git: https://bugzilla.gnome.org/show_bug.cgi?id=696633
Comment 11 Alexandre Rostovtsev (RETIRED) gentoo-dev 2013-09-01 21:56:22 UTC
Fixed, thanks for reporting the problem.

+*gdbus-codegen-2.36.4-r1 (01 Sep 2013)
+*gdbus-codegen-2.34.3-r1 (01 Sep 2013)
+*gdbus-codegen-2.32.4-r2 (01 Sep 2013)
+
+  01 Sep 2013; Alexandre Rostovtsev <tetromino@gentoo.org>
+  +gdbus-codegen-2.32.4-r2.ebuild, +gdbus-codegen-2.34.3-r1.ebuild,
+  -gdbus-codegen-2.36.3.ebuild, +gdbus-codegen-2.36.4-r1.ebuild,
+  +files/gdbus-codegen-2.36.4-input-encoding.patch:
+  Do not open input files as build-environment encoding text when using python3
+  as the python interpreter (bug #483060, thanks to Fernando V. (likewhoa)).