Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 482774 - app-misc/tmux: unnecessary use of EGIT_PROJECT
Summary: app-misc/tmux: unnecessary use of EGIT_PROJECT
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alex Alexander (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: git-2-api-aug2013
  Show dependency tree
 
Reported: 2013-08-28 08:24 UTC by Michał Górny
Modified: 2013-08-28 12:09 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-08-28 08:24:28 UTC
Per eclass docs, the default value is:

    # EGIT_PROJECT="${EGIT_REPO_URI##*/}"

Your ebuild does:

    EGIT_REPO_URI="git://git.code.sf.net/p/tmux/tmux-code"
    EGIT_PROJECT="tmux"

which differs only by the '-code' segment stripped. Please drop that assignment since EGIT_PROJECT is going to be deprecated and removed in near future. Thanks.
Comment 1 Tim Harder gentoo-dev 2013-08-28 08:47:50 UTC
I don't think we should remove functionality that allows checking out into a specified folder name.

This was used previously since the upstream sf repos used to end in "code" so multiple projects would all be checked out into the same "code" directory.

There will continue to be collisions in the future and we should have a method for avoiding them.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-08-28 09:13:43 UTC
I'm working on finding a better method. Likely I'll just use the 'path' part of URI. Explicit EGIT_PROJECT requires ebuilds to control every single repo and that gets into the way of submodules.

Aside from that, there's no real issue with collisions. Git can handle fetching multiple repositories into one repo just fine (see namespaces) but that's another story and something we most likely don't want (though it saves space).
Comment 3 Alex Alexander (RETIRED) gentoo-dev 2013-08-28 12:09:48 UTC
done, cheers