python.eclass is deprecated
+*entropy-216 (22 Aug 2013) + + 22 Aug 2013; Fabio Erculiani <lxnay@gentoo.org> +entropy-216.ebuild: + version bump Fixed.
does entropy use modules from portage? If so, then $PYTHON_USEDEP is missing
Will be fixed on the next bump.
why on the next bump?
more: * PYTHON_REQUIRED_USE is missing * eutils.eclass is unused * dodir in line 55 is redundant * "|| die" in line 50 and 60 are redundant * "cd" in line 49 and 58 are redundant, use "emake -C lib foo" * I'd rather use real bash syntax in pkg_postinst
Entropy is special. It's a package manager like sys-apps/portage and deserves special treatment to avoid breaking upgrade paths. So, any changes in the ebuild will have to be tested in our tinderbox first. I will have a look at the suggested changes and merge the ones I find legitimate. Thanks.
maybe ask the python herd for review before you do a conversion
(In reply to Julian Ospald (hasufell) from comment #5) > more: > * PYTHON_REQUIRED_USE is missing Nope. PYTHON_REQ_USE="sqlite" > * eutils.eclass is unused > * dodir in line 55 is redundant > * "|| die" in line 50 and 60 are redundant > * "cd" in line 49 and 58 are redundant, use "emake -C lib foo" Next time, please attach a diff. > * I'd rather use real bash syntax in pkg_postinst If you really care about this, just send me a patch!
(In reply to Fabio Erculiani from comment #8) > (In reply to Julian Ospald (hasufell) from comment #5) > > more: > > * PYTHON_REQUIRED_USE is missing > > Nope. > PYTHON_REQ_USE="sqlite" > That is incorrect, PYTHON_REQ_USE != PYTHON_REQUIRED_USE See the eclass for details. The manpages seem outdated.
What an unfortunate name :( (REQ_USE vs REQUIRED_USE). Okay, got it. I will bump entropy soon anyway.
yes, the naming is non-intuitive and the docs are outdated
(In reply to Julian Ospald (hasufell) from comment #11) > yes, the naming is non-intuitive and the docs are outdated Which docs would those be? The manpages are generated from the eclass docs when you emerge eclass-manpages.
(In reply to Mike Gilbert from comment #12) > (In reply to Julian Ospald (hasufell) from comment #11) > > yes, the naming is non-intuitive and the docs are outdated > > Which docs would those be? The manpages are generated from the eclass docs > when you emerge eclass-manpages. http://www.gentoo.org/proj/en/Python/python-r1/dev-guide.xml https://wiki.gentoo.org/wiki/Python-r1 https://wiki.gentoo.org/wiki/Python-r1/examples
I delayed the entropy v217 release so I am going to fix the problems in v216 in tree. + 23 Aug 2013; Fabio Erculiani <lxnay@gentoo.org> entropy-216.ebuild: + Fix python-single-r1 usage as reported by hasufell in bug #482032 + Should you have more complaints, please reopen this bug.
